From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67209C433EF for ; Mon, 13 Sep 2021 21:02:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36D7760698 for ; Mon, 13 Sep 2021 21:02:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 36D7760698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9upGSXQQFR0byq52ark9tYJlIqDlavzN4VY6rCfCpRw=; b=gfySBeXxzoGtJgxKT08hj8wtpe KnD7fMQiOqvoWj3LzHG2apjSD7lhXsNl2F7djBZ5Mj5l+xbOzsWWge0xXVHmoGXpIvm8mIXknpcpc v1kwHSnKcygLMwQxEz1nEFi3zN0LrUVrN7aC479dmXmR2xgUZdLentsPiQ4FLDvoXMXdL7zLHy5iz Q5rrT3GieMZHnN8+h0c2cDTLrOsEPgsMtHmZFf8nkebtHTsQTn0GyiP4RykGNPRO629WGa4UVijzE jrp00lK6Tk1Er70TMJ6hPSirswfmi66uwkwWh4XAtPbt3ZkDnqlERKSStnVBTQA7MoB/rd+Z/VGw/ /9Sxk0rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPt2l-003Fbe-3O; Mon, 13 Sep 2021 20:59:12 +0000 Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPszU-003ELt-0K for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 20:55:49 +0000 Received: by mail-ot1-x334.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso15238262ota.8 for ; Mon, 13 Sep 2021 13:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xlOUwRVv/SaM1ZoZrctrKFCQwOAIgRDrG+ihv2UpfRE=; b=hYpUq2fYnjWl98QExTA1Lcm3pKldkQlsz03K4Ceni+OVd4yS3nuQbH84FXn9mymrvU FHRAjNULnrb8zqGIaQf3IZLCJr1mdoFuMD8T8azOCroNQE2U0Z7jCawqQPmCMsajotSH o9p4ellOkdxtgZIeg0x3L9x1+ZZ6Dwtoj/LrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xlOUwRVv/SaM1ZoZrctrKFCQwOAIgRDrG+ihv2UpfRE=; b=NnK20BQHzYdDTMoAihZRLiuBu6asYxK+k3Ky1eIpxuS06bRuRjOkeLWu5ua7Rc5SEa tBt2foEPcG0HmlTgTasnMKQvJFMfLaF+/6HD2WJJEwVVBsC82oj1GzSiucNl7C0ceCMi HHAP+i54kY58B023LGVLvpBFFcRIsSuYkchtBJ+Uc/qMHcPWMGIzfCXO9FaDDsRxOtS8 1Za2wtpaQ513/Fxe/aTfT7tXh8+208hb92z1zgISD8xwHtu0iMoIn69n2dv1WXNCT8fZ St9xq858ue7KwTxtOJAUs4O2WKeM8D2IAbpixHwwpXOym2wi+4zf/52fxLicD3ThkYPS IiXg== X-Gm-Message-State: AOAM5331/QWgMqRwbYXZFPn1nmtMgQ2T8WPVIAxr5M6vXjssX5cZXmFB tb0gEyjSaLuNmFjTcnM9eOjOIQ== X-Google-Smtp-Source: ABdhPJxX6VLJs0ZE/xnRItZvUlnzABjm694fEoRvXc78iBIISqm0Sa0k2us+ag+7HT07CwsTKbCfmQ== X-Received: by 2002:a05:6830:818:: with SMTP id r24mr11477370ots.2.1631566547004; Mon, 13 Sep 2021 13:55:47 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id z1sm2139510ooj.25.2021.09.13.13.55.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Sep 2021 13:55:46 -0700 (PDT) Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Brendan Higgins , Arnd Bergmann Cc: Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development , Shuah Khan References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> From: Shuah Khan Message-ID: <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> Date: Mon, 13 Sep 2021 14:55:44 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_135548_139277_D93B02B5 X-CRM114-Status: GOOD ( 24.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/8/21 3:24 PM, Brendan Higgins wrote: > On Wed, Sep 8, 2021 at 10:16 AM Shuah Khan wrote: >> >> On 9/8/21 11:05 AM, Arnd Bergmann wrote: >>> On Wed, Sep 8, 2021 at 4:12 PM Shuah Khan wrote: >>>> On 9/7/21 5:14 PM, Linus Torvalds wrote: >>>>> The KUNIT macros create all these individually reasonably small >>>>> initialized structures on stack, and when you have more than a small >>>>> handful of them the KUNIT infrastructure just makes the stack space >>>>> explode. Sometimes the compiler will be able to re-use the stack >>>>> slots, but it seems to be an iffy proposition to depend on it - it >>>>> seems to be a combination of luck and various config options. >>>>> >>>> >>>> I have been concerned about these macros creeping in for a while. >>>> I will take a closer look and work with Brendan to come with a plan >>>> to address it. >>> >>> I've previously sent patches to turn off the structleak plugin for >>> any kunit test file to work around this, but only a few of those patches >>> got merged and new files have been added since. It would >>> definitely help to come up with a proper fix, but my structleak-disable >>> hack should be sufficient as a quick fix. >>> >> >> Looks like these are RFC patches and the discussion went cold. Let's pick >> this back up and we can make progress. >> >> https://lore.kernel.org/lkml/CAFd5g45+JqKDqewqz2oZtnphA-_0w62FdSTkRs43K_NJUgnLBg@mail.gmail.com/ > > I can try to get the patch reapplying and send it out (I just figured > that Arnd or Kees would want to send it out :-) since it was your > idea). > Brendan, Would you like to send me the fix with Suggested-by for Arnd or Kees? thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel