From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C52CCD11BF for ; Sat, 23 Mar 2024 10:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8GvQFF08U8VuQZkTjD4ReEVhhX/lSmB+Xu6Hr5LzzFI=; b=4nD5yqJX09KMi9 zyp+M1Pk+v3AwJxOOSeq/H23lIDiW5Fn6xDQkbWnO6+bIGnmHtbkhmcN4lusmwaWDdLX41d6+Phpf QpFe50J3MjzGqVpJdOxlOykOXDr/VA4T/21uIC0l+7lV8AF3XrbSwgKYADs5pzijbJ5Jnl4YxTy8/ 84hvlXaZZYbmhYq7cpDBBGNF9bgZPqIg6S5ZKFdCDpe06S6sEJNiY5MBgpMevRhbqmvj4WLmlAwYj N915dZ7YRSERuih6JrJKJNGmlI8oF9Bn4QqRKwXc4WyiZAN41WHWf5ADMIitpZsLNeKHny5E/G4u6 x3q8FiR+UW/dcUrTV72A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnz39-0000000ADZi-0upp; Sat, 23 Mar 2024 10:56:31 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnz36-0000000ADYf-3tf9; Sat, 23 Mar 2024 10:56:30 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-33d90dfe73cso1582441f8f.0; Sat, 23 Mar 2024 03:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711191382; x=1711796182; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T89lugZZm+sK/OwQC/VrSH4+YBlryHzMWMY+9vJ7rZ4=; b=QFI+kVmIEV9c/Yr9DbsV8wBg1Boj7YJn3fxIipoKz4Fk3XPkc2q/6VLcr5HRKu7j4W pycj/yT+UyjTaIppYnyDCN5csGluTNHtYevnz6I8FXbMVlFFQvoA32rVyJkMbZw87XC3 SBut74AFt8kICeK+6V9wd2IYLypntEUVaeUcxyFjnxI+I/y5Wq41koyDP6M2oT95SYWz TsNLm/VvLLZdavQD/1WSW3IX9Np1l4sOKJzFEOL7xSaDHsW5IbAXtOk5+0SELTbZiiaL ZZdoEDlPdKKLHw8op9GkELIN6BVlCAEvyeaX3lbhlBGyWle0vU03NvK+nyQ4itLhYRz0 DMbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711191382; x=1711796182; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T89lugZZm+sK/OwQC/VrSH4+YBlryHzMWMY+9vJ7rZ4=; b=f5bUnMOwn/suT157NIW9L5+WW50XeFNOYb4qIyrLz4H2zPLZgt3b96A9cVXKL4g7Db 08Ab2zNOC/qDwDPR0S17Z5M8TjUYagF0kqRAIeo3vBXjvnaQyVpd9hu3n4+qT9Y7+4mo 8Q/FrbNmnldCEalXuygPm/z4oXAGTsdh/fMnOhfb+Lb3vrNwMKUUwVIoE3y4Lk+r3egg hSL0jw+T8fcJzW9h9pfOdo6AX/B5xrzNl37zDHXjcV31u7Mqpkbq72YZ2aTc91gH0SJ8 KXqPXlAC4TGrKTnEUyV4eEJQSDiRlZvfPJwsHrsx8+Wg2Ufx3uCJj5aoNY+IHpr/dDOA qoRA== X-Forwarded-Encrypted: i=1; AJvYcCXIdHgNvgC83ATg4Es7pi6xhqfwKKyP//wT0wV/bMrJxOmZxSQfoOGDYkzF2NXWW2t4TWJCwN5xO5SBRMQ1k+SJBQoTa1vwH8sm4UUA7OMyHjTTyq5SItjDqSERfM0oBVDzR+gVsvoYAwzA9iAX1yafMPwfk+Rz1xk= X-Gm-Message-State: AOJu0YzNhPkj+os/6xeSA6XBPk7gVIV0Zsu1zrthupL/t84XxL07RQ9I dIEe8j9rvx2VuQpL40mlBRc4d2+AZNUbsi89SOLe3xv0lRTdfbU= X-Google-Smtp-Source: AGHT+IFjvMTxrAPgAxiFi0hukZKVkQEPlqo+pP4JejA5ZZnSvnrZv+lDfiAlrQrGGNVKjpgzQkOaGQ== X-Received: by 2002:adf:fb4a:0:b0:33e:6760:5298 with SMTP id c10-20020adffb4a000000b0033e67605298mr1287289wrs.29.1711191381500; Sat, 23 Mar 2024 03:56:21 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:fbb8:7547:139d:a40f? ([2a02:810b:f40:4600:fbb8:7547:139d:a40f]) by smtp.gmail.com with ESMTPSA id n14-20020a5d51ce000000b0033e9fca1e49sm4160326wrv.60.2024.03.23.03.56.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 03:56:21 -0700 (PDT) Message-ID: <3c0d5aa2-55fb-4827-bcd4-256e6ae55ee9@gmail.com> Date: Sat, 23 Mar 2024 11:56:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add rk816 binding Content-Language: en-US, de-DE To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Linus Walleij , Liam Girdwood , Mark Brown Cc: Chris Zhong , Zhang Qing , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20240323085852.116756-1-knaerzche@gmail.com> <20240323085852.116756-2-knaerzche@gmail.com> From: Alex Bee In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240323_035629_046343_3481A5AB X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Am 23.03.24 um 11:32 schrieb Krzysztof Kozlowski: > On 23/03/2024 09:58, Alex Bee wrote: >> Add DT binding document for Rockchip's RK816 PMIC >> >> Signed-off-by: Alex Bee >> --- >> changes since v1: >> - lowercase/hyphens for regulator node names >> - rename "-reg" to "-regulator" to make node names generic > I don't understand why did you do it. I did not ask for it. If you want > to rename, drop redundant regulator or reg suffix from node names. You didn't ask for that, thats true. I did it regardless, since node names should be generic and the "-reg" suffix is not. They are all subnodes of "regulators", indeed, but I don't think dropping the suffix completely makes the binding any better, since there is a boost(-switch) and an otg-switch which are also subnodes of "regulators" and they are just switches. Alex > >> - dropped superfluous description for clock-output-names and >> wakeup-source >> - dropped "|" for text blocks that don't require to preserve formatting >> - use full path for `$ref`s >> - added pins description to the binding >> - added charger function to description >> >> .../bindings/mfd/rockchip,rk816.yaml | 269 ++++++++++++++++++ >> 1 file changed, 269 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml >> new file mode 100644 >> index 000000000000..9664162f4f75 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk816.yaml >> @@ -0,0 +1,269 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/rockchip,rk816.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: RK816 Power Management Integrated Circuit >> + >> +maintainers: >> + - Chris Zhong >> + - Zhang Qing >> + >> +description: >> + Rockchip RK816 series PMIC. This device consists of an i2c controlled MFD >> + that includes regulators, a RTC, a GPIO controller, a power button, and a >> + battery charger manager with fuel gauge. >> + >> +properties: >> + compatible: >> + enum: >> + - rockchip,rk816 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + '#clock-cells': >> + description: >> + See for clock IDs. >> + const: 1 >> + >> + clock-output-names: >> + maxItems: 2 >> + >> + gpio-controller: true >> + >> + '#gpio-cells': >> + const: 2 >> + >> + system-power-controller: >> + type: boolean >> + description: >> + Telling whether or not this PMIC is controlling the system power. >> + >> + wakeup-source: >> + type: boolean >> + >> + vcc1-supply: >> + description: >> + The input supply for dcdc1-regulator. >> + >> + vcc2-supply: >> + description: >> + The input supply for dcdc2-regulator. >> + >> + vcc3-supply: >> + description: >> + The input supply for dcdc3-regulator. >> + >> + vcc4-supply: >> + description: >> + The input supply for dcdc4-regulator. >> + >> + vcc5-supply: >> + description: >> + The input supply for ldo1-regulator, ldo2-regulator, and ldo3-regulator. >> + >> + vcc6-supply: >> + description: >> + The input supply for ldo4-regulator, ldo5-regulator, and ldo6-regulator. >> + >> + vcc7-supply: >> + description: >> + The input supply for boost. >> + >> + vcc8-supply: >> + description: >> + The input supply for otg-switch. >> + >> + regulators: >> + type: object >> + patternProperties: >> + "^(boost|dcdc[1-4]-regulator|ldo[1-6]-regulator|otg-switch)$": >> + type: object >> + $ref: /schemas/regulator/regulator.yaml# >> + unevaluatedProperties: false >> + unevaluatedProperties: false >> + >> +patternProperties: >> + '-pins$': > Keep consistent quotes, so either ' or ". > >> + type: object >> + additionalProperties: false >> + $ref: /schemas/pinctrl/pinmux-node.yaml >> + >> + properties: >> + function: >> + enum: [pin_fun_gpio, pin_fun_thermistor] > gpio, thermistor > (pin_fun is redundant) > >> + >> + pins: >> + $ref: /schemas/types.yaml#/definitions/string >> + const: gpio0 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - "#clock-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + >> + i2c { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + rk816: pmic@1a { >> + compatible = "rockchip,rk816"; >> + reg = <0x1a>; >> + interrupt-parent = <&gpio0>; >> + interrupts = ; >> + clock-output-names = "xin32k", "rk816-clkout2"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmic_int_l>; >> + gpio-controller; >> + system-power-controller; >> + wakeup-source; >> + #clock-cells = <1>; >> + #gpio-cells = <2>; >> + >> + vcc1-supply = <&vcc_sys>; >> + vcc2-supply = <&vcc_sys>; >> + vcc3-supply = <&vcc_sys>; >> + vcc4-supply = <&vcc_sys>; >> + vcc5-supply = <&vcc33_io>; >> + vcc6-supply = <&vcc_sys>; > Add pins node to the example. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel