From: Andre Przywara <andre.przywara@arm.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Richard Cochran <richardcochran@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH RFC/RFT 0/2] net: stmmac: Add support for Allwinner A733 GMAC210
Date: Thu, 6 Aug 2026 14:06:47 +0200 [thread overview]
Message-ID: <3c39665b-5fe0-4015-ae96-c97e0ce8e9c2@arm.com> (raw)
In-Reply-To: <20260731-allwinner-a733-gmac-support-v1-0-d0a8732bfa82@baylibre.com>
Hi,
On 7/31/26 18:30, Jerome Brunet wrote:
> The A733 GMAC210 is a DesignWare MAC 5.20 with an Allwinner glue close to
> the A523 GMAC200 already supported by dwmac-sun55i, but with a few
> significant differences:
>
> * The glue configuration registers are a dedicated MMIO region of the
> controller instead of a syscon register.
> * That region is inside the controller reset domain, so the reset must be
> released before the configuration is written, and must not be asserted
> again afterwards or the configuration is lost.
> * The DMA channels have their own interrupt lines.
> * A PTP reference clock and an AHB reset are needed.
> * The controllers do not require a power domain (AFAIK).
> * The TX clock delay value is 5 bits wide instead of 3, split over 2
> register fields.
>
> The DT changes for the A733 and the Cubie A7A board are not part of this
> series and will be sent separately through the sunxi tree.
>
> Tested on a Cubie A7A, RGMII with an external PHY on GMAC0.
>
> Full disclosure: at the moment there is a problem with EEE/LPI while
> testing on the Cubie A7A. If the device stays in LPI mode long enough, the
> link sometimes (but not always) goes down, coming back up when the device
> exits LPI mode.
I saw that the MAXIO PHY *vendor* driver disables exactly those two
modes, so is this maybe more of a PHY problem?
Cheers,
Andre
>
> I'm currently working around the problem by adding the following
> properties to the PHY node:
>
> eee-broken-100tx;
> eee-broken-1000t;
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> Jerome Brunet (2):
> dt-bindings: net: sun8i-emac: Add A733 GMAC210 compatible
> net: stmmac: Add support for Allwinner A733 GMAC210
>
> .../bindings/net/allwinner,sun8i-a83t-emac.yaml | 130 +++++++++++++++---
> drivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c | 145 ++++++++++++++++++---
> 2 files changed, 242 insertions(+), 33 deletions(-)
> ---
> base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
> change-id: 20260731-allwinner-a733-gmac-support-163bde10c152
>
> Best regards,
> --
> Jerome
>
>
prev parent reply other threads:[~2026-08-06 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 16:30 [PATCH RFC/RFT 0/2] net: stmmac: Add support for Allwinner A733 GMAC210 Jerome Brunet
2026-07-31 16:30 ` [PATCH RFC/RFT 1/2] dt-bindings: net: sun8i-emac: Add A733 GMAC210 compatible Jerome Brunet
2026-07-31 16:30 ` [PATCH RFC/RFT 2/2] net: stmmac: Add support for Allwinner A733 GMAC210 Jerome Brunet
2026-08-06 12:06 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c39665b-5fe0-4015-ae96-c97e0ce8e9c2@arm.com \
--to=andre.przywara@arm.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox