From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC49EC2D0DB for ; Fri, 24 Jan 2020 14:29:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91CA2206F0 for ; Fri, 24 Jan 2020 14:29:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pSs5StaR"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="vzClSq3P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91CA2206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K9IQmbCMAyvB1OyTfBvGjD+sB4VjR3X+UErYFpdaZbk=; b=pSs5StaRjQcmQB8ereeuXqXfG 70D7/M4GPb3bXS5qnUnMGjnrngr9pIhKvJHI3oAMGuQxnPvlmLJj7Ua+uw7Om0MqffaAsuN/qdaSe 8lmsTdsfGAeQQGuk0oRxyjLJ2Pw2fiD42XAHsuvqdoj9O89KIzlyHxCi17IqX48lvmqPc+v+oGl6x ls5jEoMUBZcnLCRdASKpiN8/KTQsP8HKQcKQqad9GfYzWFMm/ICeMKMt2EllQLXwwCVK/97aYO/DY kczVqeXluCJ1KDxYTY4WCoKvY/UCKMuQVO4Uh8x6dqrSpV9aJaaecCRJFDVSDRK62P5I4NMK01uUT KmL0br4NA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuzxt-0005FS-L0; Fri, 24 Jan 2020 14:29:41 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iuzqO-0004ZC-4N for linux-arm-kernel@lists.infradead.org; Fri, 24 Jan 2020 14:21:58 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1579875716; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=jiI1uJZF61zF9q0RLqAiLf10/keLiT+nvZg6ovSERgc=; b=vzClSq3PzlOv4BtnZbI4b+7ECCXlP7zeMBDvnk/sJB+9YiesLUsOdI4iOye9MvZ/A4bWR5Gn 2cPU9Aur64x+IVE+NM0iNbH+0ptgTCrDMYHyH3HqcP3SjX7ZgdnO0LHI49yioxFK/Iqot2y/ i+KJ5pwLgeMH9Zvx/RiBDwMYrgw= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e2afd80.7f0d838b5d88-smtp-out-n02; Fri, 24 Jan 2020 14:21:52 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CEFE9C447AE; Fri, 24 Jan 2020 14:21:51 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5B7F4C433CB; Fri, 24 Jan 2020 14:21:49 +0000 (UTC) MIME-Version: 1.0 Date: Fri, 24 Jan 2020 19:51:49 +0530 From: Sai Prakash Ranjan To: James Morse Subject: Re: [PATCH 1/2] dt-bindings: edac: Add DT bindings for Kryo EDAC In-Reply-To: <312fc8b8-7019-0c74-6a92-c6740cab5dad@arm.com> References: <0101016ed57a3259-eee09e9e-e99a-40f1-ab1c-63e58a42615c-000000@us-west-2.amazonses.com> <312fc8b8-7019-0c74-6a92-c6740cab5dad@arm.com> Message-ID: <3c3b1d8107a26bbbf8daca3a6c43caca@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200124_062156_566209_87FDD394 X-CRM114-Status: GOOD ( 28.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Tony Luck , psodagud@codeaurora.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , tsoni@codeaurora.org, linux-kernel@vger.kernel.org, Rob Herring , Bjorn Andersson , Andy Gross , Borislav Petkov , Evan Green , Robert Richter , baicar@os.amperecomputing.com, Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 2020-01-16 00:18, James Morse wrote: > Hi Sai, > > (CC: +Tyler) > > On 05/12/2019 09:53, Sai Prakash Ranjan wrote: >> This adds DT bindings for Kryo EDAC implemented with RAS >> extensions on KRYO{3,4}XX CPU cores for reporting of cache >> errors. > > KRYO{3,4}XX isn't the only SoC with the RAS extensions. The DT needs > to convey the range > of ways this armv8 RAS extensions stuff can be wired up. > Right, but I was going for Kryo specific implementation and hence the binding as such. > The folk who look after the ACPI specs have made a start: > https://static.docs.arm.com/den0085/a/DEN0085_RAS_ACPI_1.0_BETA_1.pdf > > (I suspect that isn't the latest version, I'll try and find out) > That would be helpful, thanks. > I'd like the ACPI table and DT to convey the same information so that > we don't need to > convert or infer things in the driver. If something is missing, we > should get it added! > Sure, I think it is decided now that kernel first RAS implementation will be generic. > >> diff --git >> a/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml >> b/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml >> new file mode 100644 >> index 000000000000..1a39429a73b4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/edac/qcom-kryo-edac.yaml >> @@ -0,0 +1,67 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/edac/qcom-kryo-edac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Kryo Error Detection and Correction(EDAC) >> + >> +maintainers: >> + - Sai Prakash Ranjan >> + >> +description: | >> + Kryo EDAC is defined to describe on-chip error detection and >> correction >> + for the Kryo CPU cores which implement RAS extensions. > > Please don't make this Kryo specific, otherwise this binding becomes > an extra thing we > need to support with a 'v8.2 RAS' driver. > > What I'd like is a single 'armv82_ras' edac driver that handles faults > and errors reported > by interrupts, and interacts with the arch code's handling of > 'external aborts'. This > should work for all platforms using v8.2 RAS and later. > > Ok sure. >> + It will report >> + all Single Bit Errors and Double Bit Errors found in L1/L2 caches >> in >> + in two registers ERXSTATUS_EL1 and ERXMISC0_EL1. L3-SCU cache >> errors >> + are reported in ERR1STATUS and ERR1MISC0 registers. >> + ERXSTATUS_EL1 - Selected Error Record Primary Status Register, >> EL1 >> + ERXMISC0_EL1 - Selected Error Record Miscellaneous Register 0, >> EL1 >> + ERR1STATUS - Error Record Primary Status Register >> + ERR1MISC0 - Error Record Miscellaneous Register 0 >> + Current implementation of Kryo ECC(Error Correcting Code) mechanism >> is >> + based on interrupts. > > Your SoC picked the system registers as the interface to these > component's registers. > The binding would need to specify which index the 'l1-l2' records > start at, and how many > there are. The same for the 'l3-scu'. You can't hard code these, they > are different on > other platforms. > Ok will keep this in mind for the next version. > There is also an MMIO interface which needs a base address, along with > the index and > ranges. (which may be different). The same component may use both the > system register and > the MMIO interface. > I have some doubts here, Where do I get this info? Will this be implementation specific? > This stuff is likely to vary on big/little systems, so you need a way > of describing which > CPUs the settings refer to. This probably isn't something the ACPI > tables capture as ACPI > machines are typically homogenous. > Our SoCs are based on big.LITTLE arch, so this will be needed. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel