From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9AA5C54E67 for ; Sun, 17 Mar 2024 18:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gOz8ECVBykS5ZzOlXwNKE/5FKil1XzkkRXNXtRm1nSk=; b=nb+emhCvCFeW3v AWeyhryrqVFW8aBnrP16FZUgvVSir4Ajk1uO6Q7ivdkG1greQ758UImGUePCD2HLpPkiUNgloUC4r MHTwieYGRI5Qjqhybb1bU4oIovFhKM6i3/v+4infcyfbE9JEcOxZHy71kNdTh4P3LOLeDCDHeaR9l CThXnG5YSmloQswSQ6oPz+bO9A5DfVaJxFpydO8hzL7ERFHUeBoT28HGZWmH2jjqJh8KJraRMwh8a A0s1FJnx4ykDyP0pNyeR3pa5TnZRVnAGgw3q3+JQr1/JAoa5bB8W02Rn+AkCiSwIs5rufk5kMOzS0 0Alp4PzpUb6r3MbtD40w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlvdf-000000066Hs-1JNT; Sun, 17 Mar 2024 18:53:43 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlvdb-000000066HG-3shp for linux-arm-kernel@lists.infradead.org; Sun, 17 Mar 2024 18:53:41 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a4644bde1d4so479509466b.3 for ; Sun, 17 Mar 2024 11:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710701618; x=1711306418; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KBdAvz6eCK2ZQJ5K3dkyN1YHXiIV5pwGENdhV0W8wZk=; b=wimD6Dij+dkw1w9ByQr25JXj/gGifDJXaqvC2L4PKk4mw070eM64+a+pvAeHvqZxkk /a2yFR4yXfyBWZvbDdDyyBwLGzM2XWGzm/HJAcaznzt5CKqEIQwBeewTmqlmY56enrwe gTFr3/i7mAN+5SxInhKZ6WUM3U0+K+QhnWnuo1wCcdWwvO3iQObRirqV0lNros9Mhdo1 OSK/aj5w8dJlBRLhiO54ZA9CZxvTO+4cOcO77cNzysM9RdxpTNCtjhaqQe12tvLnd7EN jU+Jezx72bXLCC7+PnpzQDo4g16No/MOfMiK2/1xESIknhhf5+p5DDeqk3mAuv98h0MB Polw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710701618; x=1711306418; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KBdAvz6eCK2ZQJ5K3dkyN1YHXiIV5pwGENdhV0W8wZk=; b=ahNMUtKEJ4qSPqSXFbqrIU/gizSjsZ/SsMKZib8+UY/giFx02k+aBlLUn0SIk2Z9cj /rHKWaAcPcQsegHpwp5QxBu9XpSeRkQsmy9WaC2eGj2N1va4pa221V4jDo9nloHh05D6 M+spyzrj/XEVvsfMpY8f7MNY9xIJPrO3AtGMLPSns8kwb4oNy01DrOIJlg6v7+1xLt+e cKyndQL4Y3rkqgelRWsKAcJIndDlBzMUMXO8KkLC7hQFiU1PVvUMrkNSSk028/tS15sB s5fOhi2/2vzgZGfQMtr51oOmgnlKcmNLnzJtGt1yuzhHWXR6CrlE8n4idc5sfIB+hNnE 0Uhw== X-Forwarded-Encrypted: i=1; AJvYcCXdMWrYQfJUFLSe/0ZaKFmmLawic85gXT3MsxjBlLf5YTtWhJ0rACvrd4BbsJaN6ywGUkC7Wibb43TheHOxTOkR/I7ZGLjJ7PT46MfhcwC4OY+CtR0= X-Gm-Message-State: AOJu0YzSjQEQi++H/DP8+r2gCOnYJLwaLcMqP80wO6CiilTzmKtPxof5 r8tah5ln7HGnPx2tbU/1gab8ArR5jGBbl5Vk+yNMJ2ZD22jq4jdJq9N11aljMO0= X-Google-Smtp-Source: AGHT+IH3cEAGS8z1AAB9YfW5ngjiqPq1pkCeukyPnzkD2SaocEGWL5AMib1cCOtc6Ke/m2Pq/T4Liw== X-Received: by 2002:a17:906:d9b:b0:a46:a041:d1a with SMTP id m27-20020a1709060d9b00b00a46a0410d1amr2936982eji.70.1710701618132; Sun, 17 Mar 2024 11:53:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id r17-20020a1709067fd100b00a466782e438sm4004900ejs.139.2024.03.17.11.53.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Mar 2024 11:53:37 -0700 (PDT) Message-ID: <3ca1c419-d185-4318-92ed-3c4e40dcf5bb@linaro.org> Date: Sun, 17 Mar 2024 19:53:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform Content-Language: en-US To: Tanmay Shah , andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240315211533.1996543-1-tanmay.shah@amd.com> <20240315211533.1996543-3-tanmay.shah@amd.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240315211533.1996543-3-tanmay.shah@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240317_115340_039400_3647E2CB X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2024 22:15, Tanmay Shah wrote: > AMD-Xilinx Versal-NET platform is successor of Versal platform. It > contains multiple clusters of cortex-R52 real-time processing units. > Each cluster contains two cores of cortex-R52 processors. Each cluster > can be configured in lockstep mode or split mode. > > Each R52 core is assigned 128KB of TCM memory. ATCM memory is 64KB, BTCM > and CTCM memoreis are 32KB each. Each TCM memory has its own dedicated > power-domain that needs to be requested before using it. > > Signed-off-by: Tanmay Shah > --- > .../remoteproc/xlnx,zynqmp-r5fss.yaml | 220 +++++++++++++++--- > 1 file changed, 184 insertions(+), 36 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > index 711da0272250..55654ee02eef 100644 > --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > @@ -18,7 +18,9 @@ description: | > > properties: > compatible: > - const: xlnx,zynqmp-r5fss > + enum: > + - xlnx,zynqmp-r5fss > + - xlnx,versal-net-r52fss > > "#address-cells": > const: 2 > @@ -64,7 +66,9 @@ patternProperties: > > properties: > compatible: > - const: xlnx,zynqmp-r5f > + enum: > + - xlnx,zynqmp-r5f > + - xlnx,versal-net-r52f > > reg: > minItems: 1 > @@ -135,9 +139,11 @@ required: > allOf: > - if: > properties: > - xlnx,cluster-mode: > - enum: > - - 1 > + compatible: > + contains: > + enum: > + - xlnx,versal-net-r52fss Why do you touch these lines? > + > then: > patternProperties: > "^r5f@[0-9a-f]+$": > @@ -149,16 +155,14 @@ allOf: > items: > - description: ATCM internal memory > - description: BTCM internal memory > - - description: extra ATCM memory in lockstep mode > - - description: extra BTCM memory in lockstep mode > + - description: CTCM internal memory > > reg-names: > minItems: 1 > items: > - - const: atcm0 > - - const: btcm0 > - - const: atcm1 > - - const: btcm1 > + - const: atcm > + - const: btcm > + - const: ctcm > > power-domains: > minItems: 2 > @@ -166,33 +170,70 @@ allOf: > - description: RPU core power domain > - description: ATCM power domain > - description: BTCM power domain > - - description: second ATCM power domain > - - description: second BTCM power domain > + - description: CTCM power domain > > else: > - patternProperties: > - "^r5f@[0-9a-f]+$": > - type: object > - > - properties: > - reg: > - minItems: 1 > - items: > - - description: ATCM internal memory > - - description: BTCM internal memory > - > - reg-names: > - minItems: 1 > - items: > - - const: atcm0 > - - const: btcm0 > - > - power-domains: > - minItems: 2 > - items: > - - description: RPU core power domain > - - description: ATCM power domain > - - description: BTCM power domain > + allOf: > + - if: > + properties: > + xlnx,cluster-mode: > + enum: > + - 1 Whatever you did here, is not really readable. You have now multiple if:then:if:then embedded. > + then: > + patternProperties: > + "^r5f@[0-9a-f]+$": > + type: object > + > + properties: > + reg: > + minItems: 1 > + items: > + - description: ATCM internal memory > + - description: BTCM internal memory > + - description: extra ATCM memory in lockstep mode > + - description: extra BTCM memory in lockstep mode > + > + reg-names: > + minItems: 1 > + items: > + - const: atcm0 > + - const: btcm0 > + - const: atcm1 > + - const: btcm1 > + > + power-domains: > + minItems: 2 > + items: > + - description: RPU core power domain > + - description: ATCM power domain > + - description: BTCM power domain > + - description: second ATCM power domain > + - description: second BTCM power domain > + > + else: > + patternProperties: > + "^r5f@[0-9a-f]+$": > + type: object > + > + properties: > + reg: > + minItems: 1 > + items: > + - description: ATCM internal memory > + - description: BTCM internal memory > + > + reg-names: > + minItems: 1 > + items: > + - const: atcm0 > + - const: btcm0 > + > + power-domains: > + minItems: 2 > + items: > + - description: RPU core power domain > + - description: ATCM power domain > + - description: BTCM power domain > > additionalProperties: false > > @@ -386,4 +427,111 @@ examples: > }; > }; > }; > + > + - | > + // Versal-NET split configuration > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + Don't add examples per each platform. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel