From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECB69C433F5 for ; Mon, 25 Oct 2021 16:44:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B620460555 for ; Mon, 25 Oct 2021 16:44:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B620460555 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k0alLwWEq6pNoGHxhcMYUybD7npLYMVeHINg2ucR6oc=; b=ui9wYkq/jxwtnDi64AFoSz3TQE 7DrDe3juZ3kOdwUdEFXp494RdnVcUD4bLyJ93MiaE6psouBKzy1Siw+Ff80wDGWZGnvsDg2fXGOv/ J+ktP4UDqJswOrKjII8uMn7LwyF9IFyPibQe/HFhLwz1fMbl44AlWtdH9USdDSCD6ph/92CHLHLmX /4o7Y8iGNsNeaoA5Oxk+OBMbNZGvxy3mGrRgRlyNR0RJj3j78nklho5hR5uFFt7JVk1PJpHPMPdRp F2i3+MdmU3gkmtH+XMxi6WAKj6XZOkFrlJwgTPJcTS3ZKHPHvqAIm1VVAnoLRXzvgaBcn6JsrqBjG r6CUFwkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf34F-00H6DY-9d; Mon, 25 Oct 2021 16:43:23 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf34B-00H6BX-0b for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 16:43:20 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 498441FB; Mon, 25 Oct 2021 09:43:16 -0700 (PDT) Received: from [10.57.21.241] (unknown [10.57.21.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 006DD3F5A1; Mon, 25 Oct 2021 09:43:12 -0700 (PDT) Subject: Re: [PATCH v2 0/5] Refactor thermal pressure update to avoid code duplication To: rafael@kernel.org, viresh.kumar@linaro.org, daniel.lezcano@linaro.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, linux@armlinux.org.uk, gregkh@linuxfoundation.org, amitk@kernel.org, amit.kachhap@gmail.com, thara.gopinath@linaro.org, bjorn.andersson@linaro.org, agross@kernel.org References: <20211015144550.23719-1-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: <3cc80fea-1320-9a1a-9954-85b30f3d933a@arm.com> Date: Mon, 25 Oct 2021 17:43:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20211015144550.23719-1-lukasz.luba@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_094319_149479_7662C00A X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/15/21 3:45 PM, Lukasz Luba wrote: > Hi all, > > This patch set v2 aims to refactor the thermal pressure update > code. There are already two clients which do similar thing: > convert the capped frequency value into the capacity of > affected CPU and call the 'set' function to store the > reduced capacity into the per-cpu variable. > There might be more than two of these users. In near future > it will be scmi-cpufreq driver, which receives notification > from FW about reduced frequency due to thermal. Other vendors > might follow. Let's avoid code duplication and potential > conversion bugs. Move the conversion code into the arch_topology.c > where the capacity calculation setup code and thermal pressure sit. > > Apart from that $subject patches, there is one patch (3/5) which fixes > issue in qcom-cpufreq-hw.c when the thermal pressure is not > updated for offline CPUs. It's similar fix that has been merged > recently for cpufreq_cooling.c: > 2ad8ccc17d1e4270cf65a3f2 > > Changes: > v2: > - added Reviewed-by from Thara for patch 3/5 > - changed the doxygen comment and used mult_frac() > according to Thara's suggestion in patch 1/5 > v1 -> [1] > Gentle ping. Viresh, Daniel, Rafael could you have a look at this, please? Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel