From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next regression caused by "gpiolib: request the gpio before querying its direction"
Date: Wed, 30 Aug 2017 07:31:41 -0500 [thread overview]
Message-ID: <3cce6903-d167-1bfc-38b4-1fdd7b3ff24b@codeaurora.org> (raw)
In-Reply-To: <20170830112424.7a3a7c36@windsurf.lan>
On 8/30/17 4:24 AM, Thomas Petazzoni wrote:
> Therefore, with Timur's commit applied, when the system boots, we get
> serial output, up to the point where gpiochip_add_data() is called, and
> requests all GPIOs. Since our UART pins are not requested at the
> pinctrl level, the gpio_request succeeds and re-muxes those pins as
> GPIOs: we lose the UART.
This part I don't understand. My patch just only impacts the code that
queries the direction of the GPIO. It does not set the direction.
When gpiochip_add_data() calls chip->request, what function is that calling?
The only thing I can think of is that the ->request function is not just
returning status, but is also muxing the GPIO. If so, then I think
that's a bug.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2017-08-30 12:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 9:24 linux-next regression caused by "gpiolib: request the gpio before querying its direction" Thomas Petazzoni
2017-08-30 12:31 ` Timur Tabi [this message]
2017-08-30 13:59 ` Gregory CLEMENT
2017-08-30 14:17 ` Thomas Petazzoni
2017-08-30 14:22 ` Timur Tabi
2017-08-30 14:32 ` Thomas Petazzoni
2017-08-30 16:24 ` jmondi
2017-08-30 19:38 ` Geert Uytterhoeven
2017-08-31 7:08 ` Linus Walleij
2017-08-31 7:18 ` Thomas Petazzoni
2017-08-31 7:30 ` Geert Uytterhoeven
2017-08-31 9:22 ` Russell King - ARM Linux
2017-08-31 9:39 ` Thomas Petazzoni
2017-08-31 18:39 ` Timur Tabi
2017-08-31 9:50 ` Geert Uytterhoeven
2017-08-31 13:05 ` Timur Tabi
2017-08-31 10:08 ` Maxime Ripard
2017-08-31 7:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cce6903-d167-1bfc-38b4-1fdd7b3ff24b@codeaurora.org \
--to=timur@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox