From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F401C4363D for ; Thu, 24 Sep 2020 13:10:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4189206B6 for ; Thu, 24 Sep 2020 13:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PYzo1B0J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4189206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2RDdyWqjV1VLfGU8NbBQpFpWp4iZJq9Iu2JtxFARO3g=; b=PYzo1B0JITvXqRNZ8ssNPVTHK mzFW6Cx2P50y0cuHD4JFX4dpM0ywamSTvVWFUoB3h9Zio84a2eWVC4xJ9WK3F5DS2dxzWy+z1XkO9 yJjpbaDrvXIQLzsvBtNxllv50h/05O6KgqAid9hiHgaha1EKZzMzjXFb+cd5u9SKIrw02JQLRXx3x +XP4ipJY3IExzLkhMxNi/O8b+vP0JhFX6xf/SFHaWo8K4ayqJqWycdZIz/l6tVHdXOKE3qLFmR+Z8 bNCuSXGLnwhIxvQBDWhoa5J6q7Nr125g8tpzJiAKK4QqeLZdAP7jp4qG3AIrnbd3uOG1kiTGrl39Z CzXraDyxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLQzq-0000Y7-I3; Thu, 24 Sep 2020 13:09:14 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLQzn-0000XR-4y for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 13:09:12 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 4742929CF4D Subject: Re: [PATCH v3 16/16] ARM: Remove custom IRQ stat accounting To: Marc Zyngier References: <20200901144324.1071694-1-maz@kernel.org> <20200901144324.1071694-17-maz@kernel.org> <875z83r08a.wl-maz@kernel.org> From: Guillaume Tucker Message-ID: <3cd270a8-ddff-b3aa-5d7f-e7224deefbcc@collabora.com> Date: Thu, 24 Sep 2020 14:09:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <875z83r08a.wl-maz@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_090911_292261_9937FA98 X-CRM114-Status: GOOD ( 26.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Garg , Florian Fainelli , Russell King , Jason Cooper , Saravana Kannan , Andrew Lunn , Catalin Marinas , Gregory Clement , linux-kernel@vger.kernel.org, kernelci-results@groups.io, Will Deacon , Thomas Gleixner , kernel-team@android.com, Valentin Schneider , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/09/2020 10:29, Marc Zyngier wrote: > Hi Guillaume, > > On Thu, 24 Sep 2020 10:00:09 +0100, > Guillaume Tucker wrote: >> >> Hi Marc, >> >> On 01/09/2020 15:43, Marc Zyngier wrote: >>> Let's switch the arm code to the core accounting, which already >>> does everything we need. >>> >>> Reviewed-by: Valentin Schneider >>> Signed-off-by: Marc Zyngier >>> --- >>> arch/arm/include/asm/hardirq.h | 17 ----------------- >>> arch/arm/kernel/smp.c | 20 ++++---------------- >>> 2 files changed, 4 insertions(+), 33 deletions(-) >> >> This appears to be causing a NULL pointer dereference on >> beaglebone-black, it got bisected automatically several times. >> None of the other platforms in the KernelCI labs appears to be >> affected. > > Hmm. My bet is that because this is a UP machine running an SMP > kernel, and I fell into the trap of forgetting about this 32bit > configuration. > > I expect the following patch to fix it. Please give it a go if you can > (I'm away at the moment and can't test much, and do not have any > physical 32bit machine to test this on). OK thanks, that worked: https://lava.baylibre.com/scheduler/job/143170 I've added this fix to the kernel branch used on staging.kernelci.org which is based on linux-next, so it will get fully verified a bit later today. Guillaume > diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c > index 00327fa74b01..b4e3d336dc33 100644 > --- a/arch/arm/kernel/smp.c > +++ b/arch/arm/kernel/smp.c > @@ -531,7 +531,12 @@ void show_ipi_list(struct seq_file *p, int prec) > unsigned int cpu, i; > > for (i = 0; i < NR_IPI; i++) { > - unsigned int irq = irq_desc_get_irq(ipi_desc[i]); > + unsigned int irq; > + > + if (!ipi_desc[i]) > + continue; > + > + irq = irq_desc_get_irq(ipi_desc[i]); > seq_printf(p, "%*s%u: ", prec - 1, "IPI", i); > > for_each_online_cpu(cpu) > > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel