Re: [PATCH v2 00/11] ACPI: APEI: share GHES CPER helpers and add DT FFH provider

[Ahmed Tiba <ahmed.tiba@arm.com>]

On 26/02/2026 07:05, Himanshu Chauhan wrote:
> On Fri, Feb 20, 2026 at 7:14 PM Ahmed Tiba <ahmed.tiba@arm.com> wrote:
>>
>> This is v2 of the GHES refactor series. The goal is to reuse existing
>> GHES CPER handling for non-ACPI platforms without changing the GHES
>> flow or naming, and add a DT firmware-first CPER provider, while
>> keeping the changes mechanical and reviewable.
> 
> It seems almost all the code is being moved from ghes.c to ghes_cper.c
> in multiple patches. It is not making sense and looks like an
> unnecessary churn.
> What is that which can't be handled in a separate file for non-ACPI platforms?

The intent is to reuse the existing GHES CPER parsing
and reporting logic for non‑ACPI platforms without duplicating it.
That does require moving the shared CPER handling into a common helper 
file so both GHES and the DT provider call the same code.

>>
>> Signed-off-by: Ahmed Tiba <ahmed.tiba@arm.com>
>> ---
>> Changes in v2:
>> - Dropped the proposed "estatus core" and kept GHES naming/flow intact
>>    (per Borislav Petkov).
>> - Re-sliced the series into smaller mechanical steps (per Mauro Carvalho Chehab).
>> - Minor DT binding fixes based on Krzysztof Kozlowski's feedback.
>> - Removed fixmap slot usage from the DT FFH driver (per Will Deacon).
>>
>> Series structure:
>> - Patches 1-8 are mechanical moves only and do not change behavior.
>> - Patch 9 wires the shared helpers back into GHES.
>> - The DT firmware-first CPER buffer provider is added in the final patches.
>> - "ACPI: APEI: introduce GHES helper" is internal build glue only
>>    and does not introduce a new user-visible configuration option.
>>
>> - Link to v1: https://lore.kernel.org/r/20251217112845.1814119-1-ahmed.tiba@arm.com
>>
>> ---
>> Ahmed Tiba (11):
>>        ACPI: APEI: GHES: share macros via a private header
>>        ACPI: APEI: GHES: add ghes_cper.o stub
>>        ACPI: APEI: GHES: move CPER read helpers
>>        ACPI: APEI: GHES: move GHESv2 ack and alloc helpers
>>        ACPI: APEI: GHES: move estatus cache helpers
>>        ACPI: APEI: GHES: move vendor record helpers
>>        ACPI: APEI: GHES: move CXL CPER helpers
>>        ACPI: APEI: introduce GHES helper
>>        ACPI: APEI: share GHES CPER helpers
>>        dt-bindings: firmware: add arm,ras-ffh
>>        RAS: add DeviceTree firmware-first CPER provider
>>
>>   Documentation/admin-guide/RAS/main.rst             |   18 +
>>   .../devicetree/bindings/firmware/arm,ras-ffh.yaml  |   71 ++
>>   MAINTAINERS                                        |    6 +
>>   drivers/Makefile                                   |    1 +
>>   drivers/acpi/Kconfig                               |    4 +
>>   drivers/acpi/apei/Kconfig                          |    1 +
>>   drivers/acpi/apei/apei-internal.h                  |   10 +-
>>   drivers/acpi/apei/ghes.c                           | 1024 +------------------
>>   drivers/acpi/apei/ghes_cper.c                      | 1026 ++++++++++++++++++++
>>   drivers/ras/Kconfig                                |   12 +
>>   drivers/ras/Makefile                               |    1 +
>>   drivers/ras/esource-dt.c                           |  264 +++++
>>   include/acpi/ghes.h                                |   10 +-
>>   include/acpi/ghes_cper.h                           |  143 +++
>>   include/cxl/event.h                                |    2 +-
>>   15 files changed, 1558 insertions(+), 1035 deletions(-)
>> ---
>> base-commit: 8bf22c33e7a172fbc72464f4cc484d23a6b412ba
>> change-id: 20260220-topics-ahmtib01-ras_ffh_arm_internal_review-bfddc7fc7cab
>>
>> Best regards,
>> --
>> Ahmed Tiba <ahmed.tiba@arm.com>
>>
>>