From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B323CC0218A for ; Thu, 30 Jan 2025 10:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e62YlGUXIAw8wozyK1kiiHHdUZMhPFXjOjYgl63mVoA=; b=QZlgOYRgYlGhL1rO2c6q0S1vGd Y4lniBbQfDcCpentnZijgHqlG9V2RMEeXSlUlobXUHlrc7idRF0J1dmC2iYjT1dY95NNQ+NuDKkU7 smeMOAwGiAGI5McX5DYk5Gl1csoKAxIOiFo0PsvzrbNAerXQtea61dwDqtc+Cd5dNKn2PrOlzaEOl qMqGP418mSHRCJMBf6Z8kjKYd3bvBeCwoiAOIPeXc9u0FGjhxYExIdlDoXoQu42lq2TGArBbnKf5F iI537sDbuRDgxtCB9eSVJPkyy4eyhqcZShAoAv/AdsAXVU7DV/JkJQAVQIarTOef2tH1yJHHtzsOK 40YWKQZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tdS95-00000008fMV-2LRT; Thu, 30 Jan 2025 10:51:39 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tdS7m-00000008f8g-2ebm for linux-arm-kernel@lists.infradead.org; Thu, 30 Jan 2025 10:50:19 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-aaeef97ff02so115912366b.1 for ; Thu, 30 Jan 2025 02:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1738234217; x=1738839017; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=e62YlGUXIAw8wozyK1kiiHHdUZMhPFXjOjYgl63mVoA=; b=H4W1KCdDKLzSFCUq5McVCy4jSpsSZEqkMUk/V8gLTDCovnoVp1wFnTrzXB/+F+UFJ8 QQaS6MgCo608mugGeomoeNRKfLTLyv8cixA+630hxeQihiS4T0jZ0QzyjNoiA1mon/A9 By9jEi6oXmW7usACWKzd1GYGCBwFJJAzhTcy6vkgDT5gpNG82llLBLMZET271I3rzDrb 33NeCnEy9F2c0AtA/sLgCtJdNYzmHvwGh3FmwvPaOMsXexFLE1jV7giqHt3lj2DDlnbN x3d39e+4VJtBqTeUNhFWmoZVau6Lzj5rzGThh+a+6R59JK67A01e6juaU+giJDyPySWW e94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738234217; x=1738839017; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e62YlGUXIAw8wozyK1kiiHHdUZMhPFXjOjYgl63mVoA=; b=Yb23CFtLBKsQVBlJv3AL0bWC6wyoAXFRnbOfhL8mTgUy6VpZ7qrs5rtFY5RmaRfWHb h9h3Dv0lJZ7mrQ/YtqgijWX9Bk/8MVJW2LUjWPbxbRoPEVG9qJGH3V1ujDkptZz6I6mh eFoHCAFg/vJ1tnBi6AMKzUE48d/EjFTPNIN3fURL0X6Pu6WgTRJ29zeOzmIIWQrGcrns cqStgYOUd9T0S4T7Kgx0XJnIFebPqVFV+e7ktwtCGEOOXRypcaSsaC4oOjmHLC6Z2rtz gR8yMX1oH5XMFyQvyj4RIisHh4XkwEfaLy8A6MD1fmK9xBsepQ6qMs3fNV3eTwiBpUIG Fl2w== X-Forwarded-Encrypted: i=1; AJvYcCVtWb0XVsIU6bcJS3d3L9k5TuJlInQZdYWeejs8+9Y9HbxAfIJ9JgmW/ayGVikBUGiVHwyGPO+OYZ5UOMwAyEWv@lists.infradead.org X-Gm-Message-State: AOJu0Yy6jwsDKkfLOep8oZRGbHhBvpD1PDsseW5TGPXeWQOij0OcpHGk X6p/3Wa+vYWgmHSGzZeUflG2jhC2bqoRXkIpxAZX8GLTgUQzW+oXzKVn7DgtBR0= X-Gm-Gg: ASbGncukitRMSrjI+fSPt/n/OIQA6Kfbqn7XreSaENeh+upvJa7RLFLONoiKKuMvHen OKAPBQnmYSnuBOmwpYjh5qCA3q3amnozuAiT0zj9asZflMUPIDGSctdCidIotXMYyYgQFEIjFKG 2FzbkF71cNVd0xkNv82eSv5m6oACFYHx393lWc6/PRPevYkngnks3VTAVyGV7jNslvnmafZrpKD dAD6ug/HsxjKEy/1E8blVHQF16GdRIbkENosc+eg9pKj625tVZnJC7VL24IqBe3qoT15WvZvwRz UP1KkQXKptQQfBDj3WydmiAI X-Google-Smtp-Source: AGHT+IHWoNagdbyI+0VCJRCuNUgGA7SE/I4LH2LJrOHgZ3deawOyjrGsdrBIZ5qzd2KNDtUu3ZBA4Q== X-Received: by 2002:a17:906:178a:b0:ab6:d467:811b with SMTP id a640c23a62f3a-ab6d467849emr482692566b.32.1738234216026; Thu, 30 Jan 2025 02:50:16 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.173]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e47a7df0sm100215566b.2.2025.01.30.02.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 02:50:15 -0800 (PST) Message-ID: <3d1abbd5-8ca6-4cd3-9800-e9aeda398e86@tuxon.dev> Date: Thu, 30 Jan 2025 12:50:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] thermal: of: Export non-devres helper to register/unregister thermal zone From: Claudiu Beznea To: Daniel Lezcano Cc: rafael@kernel.org, rui.zhang@intel.com, lukasz.luba@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, ulf.hansson@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Claudiu Beznea References: <20250103163805.1775705-1-claudiu.beznea.uj@bp.renesas.com> <20250103163805.1775705-3-claudiu.beznea.uj@bp.renesas.com> <65a16c3f-456e-40ec-91b0-afb57269ed46@tuxon.dev> <6ed7d545-82d7-4bca-95ec-95447586bb58@tuxon.dev> Content-Language: en-US In-Reply-To: <6ed7d545-82d7-4bca-95ec-95447586bb58@tuxon.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250130_025018_676099_14A17D1B X-CRM114-Status: GOOD ( 27.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30.01.2025 12:30, Claudiu Beznea wrote: > > > On 30.01.2025 12:07, Daniel Lezcano wrote: >> On Thu, Jan 30, 2025 at 11:08:03AM +0200, Claudiu Beznea wrote: >>> Hi, Daniel, >>> >>> On 29.01.2025 19:24, Daniel Lezcano wrote: >>>> Hi Claudiu, >>>> >>>> On Fri, Jan 03, 2025 at 06:38:01PM +0200, Claudiu wrote: >>>>> From: Claudiu Beznea >>>>> >>>>> On the Renesas RZ/G3S (and other Renesas SoCs, e.g., RZ/G2{L, LC, UL}), >>>>> clocks are managed through PM domains. These PM domains, registered on >>>>> behalf of the clock controller driver, are configured with >>>>> GENPD_FLAG_PM_CLK. In most of the Renesas drivers used by RZ SoCs, the >>>>> clocks are enabled/disabled using runtime PM APIs. >>>>> >>>>> During probe, devices are attached to the PM domain controlling their >>>>> clocks. Similarly, during removal, devices are detached from the PM domain. >>>>> >>>>> The detachment call stack is as follows: >>>>> >>>>> device_driver_detach() -> >>>>> device_release_driver_internal() -> >>>>> __device_release_driver() -> >>>>> device_remove() -> >>>>> platform_remove() -> >>>>> dev_pm_domain_detach() >>>>> >>>>> In the upcoming Renesas RZ/G3S thermal driver, the >>>>> struct thermal_zone_device_ops::change_mode API is implemented to >>>>> start/stop the thermal sensor unit. Register settings are updated within >>>>> the change_mode API. >>>>> >>>>> In case devres helpers are used for thermal zone register/unregister the >>>>> struct thermal_zone_device_ops::change_mode API is invoked when the >>>>> driver is unbound. The identified call stack is as follows: >>>>> >>>>> device_driver_detach() -> >>>>> device_release_driver_internal() -> >>>>> device_unbind_cleanup() -> >>>>> devres_release_all() -> >>>>> devm_thermal_of_zone_release() -> >>>>> thermal_zone_device_disable() -> >>>>> thermal_zone_device_set_mode() -> >>>>> rzg3s_thermal_change_mode() >>>>> >>>>> The device_unbind_cleanup() function is called after the thermal device is >>>>> detached from the PM domain (via dev_pm_domain_detach()). >>>>> >>>>> The rzg3s_thermal_change_mode() implementation calls >>>>> pm_runtime_resume_and_get()/pm_runtime_put_autosuspend() before/after >>>>> accessing the registers. However, during the unbind scenario, the >>>>> devm_thermal_of_zone_release() is invoked after dev_pm_domain_detach(). >>>>> Consequently, the clocks are not enabled, as the device is removed from >>>>> the PM domain at this time, leading to an Asynchronous SError Interrupt. >>>>> The system cannot be used after this. >>>> >>>> I've been through the driver before responding to this change. What is the >>>> benefit of powering down / up (or clock off / on) the thermal sensor when >>>> reading the temperature ? >>>> >>>> I can understand for disable / enable but I don't get for the classic usage >>>> where a governor will be reading the temperature regularly. >>> >>> I tried to be as power saving as possible both at runtime and after the IP >>> is not used anymore as the HW manual doesn't mentioned anything about >>> accuracy or implications of disabling the IP clock at runtime. We use >>> similar approach (of disabling clocks at runtime) for other IPs in the >>> RZ/G3S SoC as well. >>> >>>> >>>> Would the IP need some cycles to capture the temperature accurately after the >>>> clock is enabled ? >>> >>> There is nothing about this mentioned about this in the HW manual of the >>> RZ/G3S SoC. The only points mentioned are as described in the driver code: >>> - wait at least 3us after each IIO channel read >>> - wait at least 30us after enabling the sensor >>> - wait at least 50us after setting OE bit in TSU_SM >>> >>> For this I chose to have it implemented as proposed. >> >> IMO, disabling/enabling the clock between two reads through the pm runtime may >> not be a good thing, especially if the system enters a thermal situation where >> it has to mitigate. If it's not 100% safe I can drop the runtime PM support. >> >> Without any testing capturing the temperatures and compare between the always-on >> and on/off, it is hard to say if it is true or not. Up to you to test that or >> not. If you think it is fine, then let's go with it. > > I tested it with and w/o the runtime PM and on/off support (so, everything > ON from the probe) and the reported temperature values were similar. > > Thank you, > Claudiu > >> >>> If any, the HW manual is available here >>> https://www.renesas.com/en/document/mah/rzg3s-group-users-manual-hardware?r=25458591 >>> (an archive is here; the manual is in Deliverables/r01uh1014ej0110-rzg3s.pdf) >>> >>> Thank you for your review, >>> Claudiu >>> >>>> >>>>> Add thermal_of_zone_register()/thermal_of_zone_unregister(). These will >>>>> be used in the upcomming RZ/G3S thermal driver. >>>>> >>>>> Signed-off-by: Claudiu Beznea >>> >> >