From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4208C433EF for ; Fri, 17 Jun 2022 14:14:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=63yaWcc75hxAuWA2rIvOJgOERcw7vLwSCxdUmkBRY6E=; b=wVfolZ2mu5aGIB vwXOb5hPzeL8ccCUkBVE0xuJkvLymy6Qi2MzQXycw/GsHneXAXnjPBqo9gWjphwVYP5QD8LVwczNy 56Mh3xkA5x05KcXAOLCjAYa+QwzFxGWXO6ri/fKGcoh/S7RX8tJ0YB+0fcQFYCEcb1E7GzuEjvVSB E9Lt2MM+uE3D+Ops/bWQxEPBR1/HqZr8CYjieWSM7ik2TxRnCR0jUGRrmzYlP/gIMTV6Bake58So0 t98/Ujz3mFXr5om/ddgrnt2tq6QgIeOtuhGGL547PABHu7g5zYF8Crf+kD9r8bfDVw6X+f7ZDHmQu zdCZjXmBn5ZdxoTRf3Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Cil-007wFR-Uf; Fri, 17 Jun 2022 14:13:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o2Cij-007wEO-80 for linux-arm-kernel@lists.infradead.org; Fri, 17 Jun 2022 14:13:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D5E71474; Fri, 17 Jun 2022 07:13:07 -0700 (PDT) Received: from [10.57.84.65] (unknown [10.57.84.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DFD203F7D8; Fri, 17 Jun 2022 07:13:05 -0700 (PDT) Message-ID: <3d35c330-acfe-c6d1-8963-4b9b6d44dbb5@arm.com> Date: Fri, 17 Jun 2022 15:13:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region Content-Language: en-GB To: Matt Ranostay , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marc Zyngier , Nishanth Menon References: <20220617140207.444298-1-mranostay@ti.com> From: Robin Murphy In-Reply-To: <20220617140207.444298-1-mranostay@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220617_071309_365361_2AFC7191 X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-06-17 15:02, Matt Ranostay wrote: > GICD region was overlapping with GICR causing the latter to not map > successfully, and in turn the gic-v3 driver would fail to initialize. > > This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") > replaced of_iomap() calls with of_io_request_and_map() that internally > called request_mem_region(). > > Respective console output before this patchset: > > [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0 > > Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") I think that should be b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") - the GIC change is the point at which Linux started *noticing* that the DT was wrong, but it's not what made the DT wrong. Thanks, Robin. > Cc: Marc Zyngier > Cc: Robin Murphy > Cc: Nishanth Menon > Signed-off-by: Matt Ranostay > --- > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Changes from v1: > * Add missing Fixes: in commit messages > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > index be7f39299894..19966f72c5b3 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > @@ -33,7 +33,7 @@ gic500: interrupt-controller@1800000 { > ranges; > #interrupt-cells = <3>; > interrupt-controller; > - reg = <0x00 0x01800000 0x00 0x200000>, /* GICD */ > + reg = <0x00 0x01800000 0x00 0x100000>, /* GICD */ > <0x00 0x01900000 0x00 0x100000>, /* GICR */ > <0x00 0x6f000000 0x00 0x2000>, /* GICC */ > <0x00 0x6f010000 0x00 0x1000>, /* GICH */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel