From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 718C2C3DA64 for ; Mon, 5 Aug 2024 01:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zG5v+zpozCaoOLhCrLuC7vaMI7L7GfteQK+VhLPBe7k=; b=hO0YnL+OG9E6dZQLo6bZj3paKk nL+JtmpQLvbt9oZj03yqWEHpahIQkNwmj28bPQ/RGjXw6+3ZYq01fmgAEaZWcBhKaMF3TaUy43bEf QyZ4PVP0cJWkee+cbM9wr4nI6oFwM16+sGTuPtMzoaFRqN62J7uL3WtvoVkipBzEh1dlbAXXuxLuM FSURp2/9TrKokNCo0CMRHWf9AjrKgTanxQdyZXtg+z31YKOKLY/6+v1cALoVqgCh9EmWB/ULxoTtT tINGDrGz3htBiZVPFcGCs9IiD7veQzzi7x/viLJBAUthhy61bu1w8dGYKEqvVMJgEbH6/lnQdvz9x hkCYtN9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1samtM-0000000ELFk-0AS7; Mon, 05 Aug 2024 01:52:08 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1samsr-0000000ELB0-0MDK for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 01:51:38 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4750WHCA021197; Mon, 5 Aug 2024 01:51:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zG5v+zpozCaoOLhCrLuC7vaMI7L7GfteQK+VhLPBe7k=; b=NnTschHZvs+ywtci DRnRXK1VlR8hyzTJlqwt7O/tshWxIivp4G0PsVOMG9mq2nbWcqn0FJmmQlvJ8LyV LB4ovdXaHjvu6cYU959Ho7T5TQd10cuYgndG6CZ3ipJze7NQpsV86FMAyjCFdNRi XqnySrUq84gAghX6UnOZeIC1AF8wyO+C4zqqtcC1hXNJA83MTZ1MlTNecZduc+ar 8Wtb+DbzEACXQlS0FoRRSXsQZx94LKBEYwJhGFWhWe9cwkw4qTPWsMtaBfyptKT5 sACmCTxnOf8KegvBs+38xPN7I1tfAqrwqCP2YVFPISwtVwStGay6RyoD0tDz5YMI E9YZzw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40scmtth3y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Aug 2024 01:51:25 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 4751pO9N016985 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Aug 2024 01:51:24 GMT Received: from [10.239.132.204] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Sun, 4 Aug 2024 18:51:18 -0700 Message-ID: <3d3bd0be-5b8a-4a3f-bc82-cb1b72fc1899@quicinc.com> Date: Mon, 5 Aug 2024 09:51:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] arm64: defconfig: Enable interconnect for SM4450 To: Krzysztof Kozlowski , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon CC: , , , , , References: <20240801-sm4450_interconnect-v3-0-8e364d0faa99@quicinc.com> <20240801-sm4450_interconnect-v3-3-8e364d0faa99@quicinc.com> <0bc3c40d-f6ec-4db2-ba7d-ad6d3a0c6d38@kernel.org> From: Tengfei Fan In-Reply-To: <0bc3c40d-f6ec-4db2-ba7d-ad6d3a0c6d38@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: fGE0689bDTbYlYOovzNMIAhFvfdbbozo X-Proofpoint-GUID: fGE0689bDTbYlYOovzNMIAhFvfdbbozo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-04_14,2024-08-02_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 clxscore=1015 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408050012 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240804_185137_275720_A91531A4 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/2/2024 3:20 PM, Krzysztof Kozlowski wrote: > On 01/08/2024 10:54, Tengfei Fan wrote: >> Add the SM4450 interconnect driver as built-in. > > This we see from the diff. Tell us instead: why? > > That's a standard requirement for every defconfig change. Damn, for > every change. Don't say what the diff is saying, unless it is > non-trivial. Say why you are doing things. > > Best regards, > Krzysztof > In the next version of the patch series, I will describe in the comment message why this config needs to be enabled. -- Thx and BRs, Tengfei Fan