From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6588DC432BE for ; Tue, 31 Aug 2021 08:57:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E872604D7 for ; Tue, 31 Aug 2021 08:57:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E872604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=b67GQyQvSrU4pAS0vF8782LXRt8ycayxzvwo7hm/lSk=; b=MKqDtvcaZJyyB83OJFo5sKj/23 SP3NL7s+JTh/ao6l4L97QDdjd74VT5PUJxyWZ5A2KmfQUFQx2MX0dU+0sidNzyMgz8kxR4lpbZW1/ J1FuG+9BelBEcuzUnHplWmER5mweEMbWlzdTKRNAJzOEHm4We0dEZxGZFLt/IjHqUYsZ0dJf9wxhZ Rhy3EnyRXkvBSlp1Xg/FhVGMbimkJPWBBx1SeIOanKYpJGNKUFXv6qwcr4PQYG5ysUxSJC58FikAt 7dZ79XaizhbGerKmrN+vzpImvlR8PGm6s6ZJ6IKweTs3XzzAEsscoFwEIuG9+UIJeFAgV29SOF2O9 gEFj38WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKzXn-001qQM-BQ; Tue, 31 Aug 2021 08:54:59 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKzXf-001qNU-Jk; Tue, 31 Aug 2021 08:54:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 803EB1FB; Tue, 31 Aug 2021 01:54:44 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FE993F5A1; Tue, 31 Aug 2021 01:54:40 -0700 (PDT) Subject: Re: [PATCH V3 0/9] Add callback to register with energy model To: Viresh Kumar , Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Quentin Perret , Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org References: From: Dietmar Eggemann Message-ID: <3d5b823f-259a-8fc6-27ab-2a5d5df89844@arm.com> Date: Tue, 31 Aug 2021 10:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_015451_750957_4839DA69 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/08/2021 06:35, Viresh Kumar wrote: > Many cpufreq drivers register with the energy model for each policy and > do exactly the same thing. Follow the footsteps of thermal-cooling, to > get it done from the cpufreq core itself. > > Provide a new callback, which will be called, if present, by the cpufreq > core at the right moment (more on that in the code's comment). Also > provide a generic implementation that uses dev_pm_opp_of_register_em(). > > This also allows us to register with the EM at a later point of time, > compared to ->init(), from where the EM core can access cpufreq policy > directly using cpufreq_cpu_get() type of helpers and perform other work, > like marking few frequencies inefficient, this will be done separately. > > This is build/boot tested by the bot for a couple of boards. > > https://gitlab.com/vireshk/pmko/-/pipelines/351965580 > > FWIW, I have queued up the series for linux-next to get more testing, but your > reviews are welcome. Thanks. > > V2->V3: > - Drop the auto-register part from all logs, this isn't called auto registration > anymore. > - Call register_em() only for new policies. > - Update scmi driver to register with EM only when required. > - Add Rby tags. LGTM. Tested on TC2 (vexpress-spc), Juno-r0 (scpi-cpufreq and scmi). Reviewed-by: Dietmar Eggemann _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel