From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FCD8C433EF for ; Sat, 23 Apr 2022 07:06:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=thHTARRROQPaVWmEj5rqGPDaZjwm7VDZx07MjNscBRc=; b=JGOp2U9RvUUg6LXy/q4l0X2vYV xF7wUM+caKAX4iMiZSw7t3RXPjXSEJuUnlCz8fPkJ0pxVktdM0hTCXKHJZgf8vBo8cqxxRgj/YKlE Br8DXa3JVFGQq2x2mXRaFozWW4xw4ThAR1dr7WvOD+25ht2CJK3ZVImd5GInsLFTAH1EBq1qCM1Fi 2vPmoNdptRZY5+z9yjjo5fIRcb0ULUQNzG8ftliWwIQ88ZBaKwq8V0qoxtKPRkXsM5p1JSAWY/qOV lB1Ehbw41Ra5Mk1EuwEz/KIE53gYkf9ih5hmESzjIwoqd4tLU+HOqAeSPd6WsxXj5SQp4lSP3HJJk QsYtvhYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni9pi-003dig-Kw; Sat, 23 Apr 2022 07:05:30 +0000 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ni9pf-003dh2-8N for linux-arm-kernel@lists.infradead.org; Sat, 23 Apr 2022 07:05:28 +0000 Received: by mail-lj1-x232.google.com with SMTP id y19so790732ljd.4 for ; Sat, 23 Apr 2022 00:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=/OlakjqnRmEAn/ytZGVcF22kYWzHUx0JWp7WuYws5xc=; b=dG3Cqw8W+risw5HhgeGUsOV40IIJN9LsfZ/mAt53EHPXci8Nh+AS0Ukg7ugAniPlvf 2kMqWG/94faucQwjCFPGSlPgAniNw53bC+/Z2jpnNhuAfFOMslvUk8ffO+xJWC6elags DzBBmQPsl2ZWmlUpiBBlF/kAFNvs75hTOMhy9PUF8hRWso+0p7sI8aZARWWvGdyHQMw0 cypec0klqiA/oNpDbS1oDR0knRoiDjcnaD2T5jJwo8w/NfJqc7VmUFOYOb4PF9TfGnUo fX5HlQ1of/u1PYZ2DZwtWGBh26oESoG/Q5kRpeZnQCI1cefaGnb0XbPe80ZES01fcHCu V0bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=/OlakjqnRmEAn/ytZGVcF22kYWzHUx0JWp7WuYws5xc=; b=R5uSNeZnhaPCH1zrX16Vpm9tPkaq42MlbbrYwiYEKJoij40rYrXPbJrjr5YZU+dzbl zY5uhZR9Hb3xqEJID4OF1h7WOb8eZ4dRxClVNmavNf6hT2JC5c/+p3PWLTEWJLiHoYIY U/0OHyZ8JZblY0kjdeQrQO0nh9RdyiDmNXnQ12End7GtlGR3ytVUEBGZPOLcD7JpTUpl zLadU5y5/baXdAb0KykrJ0nQFwVnjJC2hpV2gTRqz/TwZBSqgQLqGImEU5gi/r499OPR Pvk28e3IEqc4cpX+k21qsj6Q+ovAHjRPkJnrQMtY2JEQtYlRQ6MQXMZJJeMC4VUkHmzj pRIw== X-Gm-Message-State: AOAM533EmjPUvnVfkB397FTfIcu6W5+ZpJTGSTU9KIK9W6j7aR2rjIJk Gvh/6CCKC8SsHnFvzmuPqNs= X-Google-Smtp-Source: ABdhPJzYqUou0JMTdEbgFu+n32xCOhNS5ykDoZom+OkX0kkYiAJxNaDtFp7tRuvODxqjyVzBcqPIcg== X-Received: by 2002:a2e:9345:0:b0:24b:451:7ce1 with SMTP id m5-20020a2e9345000000b0024b04517ce1mr4877723ljh.258.1650697524590; Sat, 23 Apr 2022 00:05:24 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id d6-20020a056512320600b0047196449b7fsm507662lfe.92.2022.04.23.00.05.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Apr 2022 00:05:23 -0700 (PDT) Subject: Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Boris Ostrovsky , Julien Grall , Oleksandr Tyshchenko , "Michael S. Tsirkin" , Christoph Hellwig References: <1650646263-22047-1-git-send-email-olekstysh@gmail.com> <1650646263-22047-4-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: <3de2852b-0a94-fd1d-2eb6-fd818f33fc88@gmail.com> Date: Sat, 23 Apr 2022 10:05:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------1C2D46C789FB115F1F5DE02D" Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220423_000527_344845_59D80B29 X-CRM114-Status: GOOD ( 26.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a multi-part message in MIME format. --------------1C2D46C789FB115F1F5DE02D Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 23.04.22 02:00, Stefano Stabellini wrote: Hello Stefano > On Fri, 22 Apr 2022, Oleksandr Tyshchenko wrote: >> From: Juergen Gross >> >> Introduce Xen grant DMA-mapping layer which contains special DMA-mapping >> routines for providing grant references as DMA addresses to be used by >> frontends (e.g. virtio) in Xen guests. >> >> In order to support virtio in Xen guests add a config option XEN_VIRTIO >> enabling the user to specify whether in all Xen guests virtio should >> be able to access memory via Xen grant mappings only on the host side. >> >> As this also requires providing arch_has_restricted_virtio_memory_access >> implementation, switch from a pure stub to a real function on Arm >> and combine with existing implementation for the SEV guests on x86. >> >> Add the needed functionality by providing a special set of DMA ops >> handling the needed grant operations for the I/O pages. >> >> Signed-off-by: Juergen Gross >> Signed-off-by: Oleksandr Tyshchenko > There are a couple of minor things that checkpatch.pl reports, Thank you for pointing this out, my fault. > but aside > from those the patch looks fine to me. good The attached diff to be squashed for the new version. One thing remains: checkpatch.pl says regarding drivers/xen/grant-dma-ops.c: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #151: new file mode 100644 Which, I assume, this is not an issue as new file falls under XEN HYPERVISOR INTERFACE maintainership? scripts/get_maintainer.pl -f drivers/xen/grant-dma-ops.c Boris Ostrovsky (supporter:XEN HYPERVISOR INTERFACE) Juergen Gross (supporter:XEN HYPERVISOR INTERFACE) Stefano Stabellini (reviewer:XEN HYPERVISOR INTERFACE) xen-devel@lists.xenproject.org (moderated list:XEN HYPERVISOR INTERFACE) linux-kernel@vger.kernel.org (open list) [snip] -- Regards, Oleksandr Tyshchenko --------------1C2D46C789FB115F1F5DE02D Content-Type: text/x-patch; charset=UTF-8; name="0001-fixup.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="0001-fixup.patch" >From 8d36fc5a3604a69848c300a42f1a78f8ace41829 Mon Sep 17 00:00:00 2001 From: Oleksandr Tyshchenko Date: Sat, 23 Apr 2022 09:23:04 +0300 Subject: [PATCH] fixup Signed-off-by: Oleksandr Tyshchenko --- drivers/xen/Kconfig | 2 ++ drivers/xen/grant-dma-ops.c | 21 ++++++++++++--------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index b95581f..1727337 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -350,4 +350,6 @@ config XEN_VIRTIO guest type this will require special support on the backend side (qemu or kernel, depending on the virtio device types used). + If in doubt, say n. + endmenu diff --git a/drivers/xen/grant-dma-ops.c b/drivers/xen/grant-dma-ops.c index 70d5d77..b9d93d7 100644 --- a/drivers/xen/grant-dma-ops.c +++ b/drivers/xen/grant-dma-ops.c @@ -139,7 +139,7 @@ static struct page *xen_grant_dma_alloc_pages(struct device *dev, size_t size, enum dma_data_direction dir, gfp_t gfp) { - WARN_ONCE(1, "xen_grant_dma_alloc_pages size %zu\n", size); + WARN_ONCE(1, "%s: size %zu\n", __func__, size); return NULL; } @@ -147,7 +147,7 @@ static void xen_grant_dma_free_pages(struct device *dev, size_t size, struct page *vaddr, dma_addr_t dma_handle, enum dma_data_direction dir) { - WARN_ONCE(1, "xen_grant_dma_free_pages size %zu\n", size); + WARN_ONCE(1, "%s: size %zu\n", __func__, size); } static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page, @@ -160,7 +160,8 @@ static dma_addr_t xen_grant_dma_map_page(struct device *dev, struct page *page, grant_ref_t grant; dma_addr_t dma_handle; - BUG_ON(dir == DMA_NONE); + if (WARN_ON(dir == DMA_NONE)) + return DMA_MAPPING_ERROR; data = find_xen_grant_dma_data(dev); if (!data) @@ -190,7 +191,8 @@ static void xen_grant_dma_unmap_page(struct device *dev, dma_addr_t dma_handle, unsigned int i, n_pages = PFN_UP(size); grant_ref_t grant; - BUG_ON(dir == DMA_NONE); + if (WARN_ON(dir == DMA_NONE)) + return; data = find_xen_grant_dma_data(dev); if (!data) @@ -219,7 +221,8 @@ static void xen_grant_dma_unmap_sg(struct device *dev, struct scatterlist *sg, struct scatterlist *s; unsigned int i; - BUG_ON(dir == DMA_NONE); + if (WARN_ON(dir == DMA_NONE)) + return; for_each_sg(sg, s, nents, i) xen_grant_dma_unmap_page(dev, s->dma_address, sg_dma_len(s), dir, @@ -233,7 +236,8 @@ static int xen_grant_dma_map_sg(struct device *dev, struct scatterlist *sg, struct scatterlist *s; unsigned int i; - BUG_ON(dir == DMA_NONE); + if (WARN_ON(dir == DMA_NONE)) + return -EINVAL; for_each_sg(sg, s, nents, i) { s->dma_address = xen_grant_dma_map_page(dev, sg_page(s), s->offset, @@ -303,10 +307,9 @@ void xen_grant_setup_dma_ops(struct device *dev) } data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); - if (!data) { - dev_err(dev, "Сannot allocate Xen grant DMA data\n"); + if (!data) goto err; - } + data->dev_domid = dev_domid; data->dev = dev; -- 2.7.4 --------------1C2D46C789FB115F1F5DE02D Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --------------1C2D46C789FB115F1F5DE02D--