From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5145C636D4 for ; Fri, 3 Feb 2023 02:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BuoBBNnyKLMctSNhoYWotz4PinoDb8tsNzkkW/ACuuM=; b=jbD8xNWNkE2l+N qoUwKfm4Y+5laD7syna6EeQ4ZnyEfJDmo4ut0xsLcOuFrDc2f/HEnap2Tf8ZM0czGpxhz11F4f6dQ 13Aydm8hEpkohy2qPLIDOvpFVB4rYd3wH60F2F4fjfPJuhsfnveUncLzC/LnuNFUpQ3H3+NYqKYDj aaP7Jnph40/Qv2cPLD0IG13i1k/dtJAtquAiGKtpXb9nq/KO16r/rSiZgGmFHYkFLpIIakoxsc9j+ hWYjUp+T3mcZT/JPOgSulftKvcYVFpkP6ZNW4xdXIVEe7KniT0OpRP+eS2m9obD9M6+f8+RcdCGb5 o755+vAdnGL9FP5CWo/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmBs-00056W-2a; Fri, 03 Feb 2023 02:52:40 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNmBo-000558-T8 for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 02:52:38 +0000 Received: by mail-ej1-x62a.google.com with SMTP id ud5so11743261ejc.4 for ; Thu, 02 Feb 2023 18:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=luv07tBojTy7MY/o/x6jvDqHfjxZ27LUynL/zLyVKVU=; b=qRqNR8+nyEtLHlZsejQjsKv1LXzYBM9Rw+XvcEOL2I9GdUGMFq474nl8SljoN3hJD0 4PagynT8yAuquNNgWmlcGwxzp8XPIZ4smQqcy9NueLPNKkCY4xAZP8tClgdbmh4KwFRB x2nscpp2uaBVoOT8z17atSE3o2M+TkTzYS2y+LIth93HBoxfq0hn5sW4pCz24ymSgzif IxU12SzVyauGvn2FU8Hv3Du6+qJLnRPMEdNh6UwbMYNpYjxiPjhFGeQb2pEu6e6v2uEb wyYJP8Kori99MNH+4DigXEknMfzoMObOUzT/NS/5IQ0QDmvDDML+DaQPpYSo/H7em8+z 1V9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=luv07tBojTy7MY/o/x6jvDqHfjxZ27LUynL/zLyVKVU=; b=phsspvQ/461fN0wiD9GvK7gTG9DoS6DgNJ3KEmjo9mcIe4HkSfLyyCDigHh7nbBH6G OFRROPxkiYG4R1OFOi04G1JPsrHe2joJM3alYLZrXLST7+OJM2Sl6wCVWez6SFDZRO2k 3dJC750oXfc52ivNS7jkXoqpaMVNdYLYdjG83/9mVVBg79pGpxqf7HQJjVpKaLM4gW6W 6VJOaO+ZOm+iKJEGMNzBD+QLSxMcs3u0ohMwIBa0WRfWFxOIEe07t5nrlogyrmMIqECR b71+1gyIvBKKSQOu1HGoZjye0494lVKs25VgUoRBvZP6KNMl623TR5cRwokG7Q9zeDGG Zx1g== X-Gm-Message-State: AO0yUKXZ2a157qO5euPGeNVcgQ5LZrIJ865vAxkYis+udju7P+j4dncW pT8SnN1pTPYv7EtjfCPXONoGhg== X-Google-Smtp-Source: AK7set+2Q+lIS7/A1H+HmFJ2+W4s8LEh9MtAQWMxacurGlMZL52NZgqFm+ulHrvoRV0ikL9R7NN3aQ== X-Received: by 2002:a17:906:261b:b0:887:d8b0:27c5 with SMTP id h27-20020a170906261b00b00887d8b027c5mr9757802ejc.52.1675392752756; Thu, 02 Feb 2023 18:52:32 -0800 (PST) Received: from [192.168.1.101] (abyl20.neoplus.adsl.tpnet.pl. [83.9.31.20]) by smtp.gmail.com with ESMTPSA id rn26-20020a170906d93a00b008845c668408sm655770ejb.169.2023.02.02.18.52.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 18:52:32 -0800 (PST) Message-ID: <3e46ab75-9b46-415e-0585-29523c5277b1@linaro.org> Date: Fri, 3 Feb 2023 03:52:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 06/23] interconnect: qcom: rpm: fix probe child-node error handling Content-Language: en-US To: Johan Hovold , Georgi Djakov Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Andy Gross , Bjorn Andersson , Sylwester Nawrocki , =?UTF-8?B?QXJ0dXIgxZp3aWdvxYQ=?= , Krzysztof Kozlowski , Alim Akhtar , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20230201101559.15529-1-johan+linaro@kernel.org> <20230201101559.15529-7-johan+linaro@kernel.org> From: Konrad Dybcio In-Reply-To: <20230201101559.15529-7-johan+linaro@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_185236_965424_624C9FFB X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1.02.2023 11:15, Johan Hovold wrote: > Make sure to clean up and release resources properly also in case probe > fails when populating child devices. > > Fixes: e39bf2972c6e ("interconnect: icc-rpm: Support child NoC device probe") > Cc: stable@vger.kernel.org # 5.17 > Signed-off-by: Johan Hovold > --- Reviewed-by: Konrad Dybcio Konrad > drivers/interconnect/qcom/icc-rpm.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index df3196f72536..91778cfcbc65 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -541,8 +541,11 @@ int qnoc_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, qp); > > /* Populate child NoC devices if any */ > - if (of_get_child_count(dev->of_node) > 0) > - return of_platform_populate(dev->of_node, NULL, NULL, dev); > + if (of_get_child_count(dev->of_node) > 0) { > + ret = of_platform_populate(dev->of_node, NULL, NULL, dev); > + if (ret) > + goto err; > + } > > return 0; > err: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel