linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: suzuki.poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support
Date: Tue, 9 Oct 2018 18:22:52 +0100	[thread overview]
Message-ID: <3e6a7a5f-3ff9-b7db-b1f6-87a8fdf5c20c@arm.com> (raw)
In-Reply-To: <1539002088-21215-3-git-send-email-gengdongjiu@huawei.com>



On 08/10/18 13:34, Dongjiu Geng wrote:
> The commit 539aee0edb9f ("KVM: arm64: Share the parts of
> get/set events useful to 32bit") shares the get/set events
> helper for arm64 and arm32, it is better also share the check
> for vcpu events capability to enable 32 bit kvm vcpu events
> support.
> 
> User space will check whether KVM supports vcpu events through
> KVM_CAP_VCPU_EVENTS IOCTL.

nit: User space will check whether KVM supports vcpu events by checking
the KVM_CAP_VCPU_EVENTS extension.

> 
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>

Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com>

> ---
> For the 32 bits kvm migration, it needs to enable the vcpu events,
> this patch will enable it. The user space QEMU patch is here:
> https://patchwork.ozlabs.org/patch/975615/
> ---
>   arch/arm64/kvm/reset.c | 1 -
>   virt/kvm/arm/arm.c     | 1 +
>   2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c
> index fd37c53..e50245e 100644
> --- a/arch/arm64/kvm/reset.c
> +++ b/arch/arm64/kvm/reset.c
> @@ -82,7 +82,6 @@ int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext)
>   		break;
>   	case KVM_CAP_SET_GUEST_DEBUG:
>   	case KVM_CAP_VCPU_ATTRIBUTES:
> -	case KVM_CAP_VCPU_EVENTS:
>   		r = 1;
>   		break;
>   	default:
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 40e79ea..64e5d97 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -212,6 +212,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext)
>   	case KVM_CAP_READONLY_MEM:
>   	case KVM_CAP_MP_STATE:
>   	case KVM_CAP_IMMEDIATE_EXIT:
> +	case KVM_CAP_VCPU_EVENTS:
>   		r = 1;
>   		break;
>   	case KVM_CAP_ARM_SET_DEVICE_ADDR:
> 

  reply	other threads:[~2018-10-09 17:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 12:34 [PATCH v2 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng
2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng
2018-10-09 16:34   ` Suzuki K Poulose
2018-10-10  2:29     ` gengdongjiu
2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng
2018-10-09 17:22   ` Suzuki K Poulose [this message]
2018-10-10  4:22     ` gengdongjiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e6a7a5f-3ff9-b7db-b1f6-87a8fdf5c20c@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).