* [PATCH v2 0/2] rename function name and enable 32bit vcpu events @ 2018-10-08 12:34 Dongjiu Geng 2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng 2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng 0 siblings, 2 replies; 7+ messages in thread From: Dongjiu Geng @ 2018-10-08 12:34 UTC (permalink / raw) To: linux-arm-kernel Rename the kvm_arch_dev_ioctl_check_extension() to kvm_arch_vm_ioctl_check_extension, because the name is not reasonable; Enable the 32 bit vcpu events support. change since v1: 1. Update patch commit messages. Dongjiu Geng (2): arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() arm/arm64: KVM: enable 32 bits kvm vcpu events support arch/arm/include/asm/kvm_host.h | 2 +- arch/arm64/include/asm/kvm_host.h | 2 +- arch/arm64/kvm/reset.c | 5 ++--- virt/kvm/arm/arm.c | 3 ++- 4 files changed, 6 insertions(+), 6 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() 2018-10-08 12:34 [PATCH v2 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng @ 2018-10-08 12:34 ` Dongjiu Geng 2018-10-09 16:34 ` Suzuki K Poulose 2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng 1 sibling, 1 reply; 7+ messages in thread From: Dongjiu Geng @ 2018-10-08 12:34 UTC (permalink / raw) To: linux-arm-kernel Rename kvm_arch_dev_ioctl_check_extension() to kvm_arch_vm_ioctl_check_extension(), because it does not have any relationship with device. Renaming this function can make code readable. Cc: James Morse <james.morse@arm.com> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> --- I remeber James also mentioned that rename this function. --- arch/arm/include/asm/kvm_host.h | 2 +- arch/arm64/include/asm/kvm_host.h | 2 +- arch/arm64/kvm/reset.c | 4 ++-- virt/kvm/arm/arm.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h index 3ad482d..3ee29db 100644 --- a/arch/arm/include/asm/kvm_host.h +++ b/arch/arm/include/asm/kvm_host.h @@ -273,7 +273,7 @@ static inline void __cpu_init_stage2(void) kvm_call_hyp(__init_stage2_translation); } -static inline int kvm_arch_dev_ioctl_check_extension(struct kvm *kvm, long ext) +static inline int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) { return 0; } diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h index 3d6d733..c20537f 100644 --- a/arch/arm64/include/asm/kvm_host.h +++ b/arch/arm64/include/asm/kvm_host.h @@ -53,7 +53,7 @@ int __attribute_const__ kvm_target_cpu(void); int kvm_reset_vcpu(struct kvm_vcpu *vcpu); -int kvm_arch_dev_ioctl_check_extension(struct kvm *kvm, long ext); +int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); void __extended_idmap_trampoline(phys_addr_t boot_pgd, phys_addr_t idmap_start); struct kvm_arch { diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c index e37c78b..fd37c53 100644 --- a/arch/arm64/kvm/reset.c +++ b/arch/arm64/kvm/reset.c @@ -55,12 +55,12 @@ static bool cpu_has_32bit_el1(void) } /** - * kvm_arch_dev_ioctl_check_extension + * kvm_arch_vm_ioctl_check_extension * * We currently assume that the number of HW registers is uniform * across all CPUs (see cpuinfo_sanity_check). */ -int kvm_arch_dev_ioctl_check_extension(struct kvm *kvm, long ext) +int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) { int r; diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index c92053b..40e79ea 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -240,7 +240,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) r = 1; break; default: - r = kvm_arch_dev_ioctl_check_extension(kvm, ext); + r = kvm_arch_vm_ioctl_check_extension(kvm, ext); break; } return r; -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() 2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng @ 2018-10-09 16:34 ` Suzuki K Poulose 2018-10-10 2:29 ` gengdongjiu 0 siblings, 1 reply; 7+ messages in thread From: Suzuki K Poulose @ 2018-10-09 16:34 UTC (permalink / raw) To: linux-arm-kernel Hi, On 08/10/18 13:34, Dongjiu Geng wrote: > Rename kvm_arch_dev_ioctl_check_extension() to > kvm_arch_vm_ioctl_check_extension(), because it does > not have any relationship with device. > > Renaming this function can make code readable. +1. The current name is not really intuitive. > > Cc: James Morse <james.morse@arm.com> > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() 2018-10-09 16:34 ` Suzuki K Poulose @ 2018-10-10 2:29 ` gengdongjiu 0 siblings, 0 replies; 7+ messages in thread From: gengdongjiu @ 2018-10-10 2:29 UTC (permalink / raw) To: linux-arm-kernel Hi Suzuki, On 2018/10/10 0:34, Suzuki K Poulose wrote: > Hi, > > On 08/10/18 13:34, Dongjiu Geng wrote: >> Rename kvm_arch_dev_ioctl_check_extension() to >> kvm_arch_vm_ioctl_check_extension(), because it does >> not have any relationship with device. >> >> Renaming this function can make code readable. > > +1. The current name is not really intuitive. > >> >> Cc: James Morse <james.morse@arm.com> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> Thanks very much for the review > > . > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support 2018-10-08 12:34 [PATCH v2 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng 2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng @ 2018-10-08 12:34 ` Dongjiu Geng 2018-10-09 17:22 ` Suzuki K Poulose 1 sibling, 1 reply; 7+ messages in thread From: Dongjiu Geng @ 2018-10-08 12:34 UTC (permalink / raw) To: linux-arm-kernel The commit 539aee0edb9f ("KVM: arm64: Share the parts of get/set events useful to 32bit") shares the get/set events helper for arm64 and arm32, it is better also share the check for vcpu events capability to enable 32 bit kvm vcpu events support. User space will check whether KVM supports vcpu events through KVM_CAP_VCPU_EVENTS IOCTL. Cc: James Morse <james.morse@arm.com> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> --- For the 32 bits kvm migration, it needs to enable the vcpu events, this patch will enable it. The user space QEMU patch is here: https://patchwork.ozlabs.org/patch/975615/ --- arch/arm64/kvm/reset.c | 1 - virt/kvm/arm/arm.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c index fd37c53..e50245e 100644 --- a/arch/arm64/kvm/reset.c +++ b/arch/arm64/kvm/reset.c @@ -82,7 +82,6 @@ int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) break; case KVM_CAP_SET_GUEST_DEBUG: case KVM_CAP_VCPU_ATTRIBUTES: - case KVM_CAP_VCPU_EVENTS: r = 1; break; default: diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 40e79ea..64e5d97 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -212,6 +212,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) case KVM_CAP_READONLY_MEM: case KVM_CAP_MP_STATE: case KVM_CAP_IMMEDIATE_EXIT: + case KVM_CAP_VCPU_EVENTS: r = 1; break; case KVM_CAP_ARM_SET_DEVICE_ADDR: -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support 2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng @ 2018-10-09 17:22 ` Suzuki K Poulose 2018-10-10 4:22 ` gengdongjiu 0 siblings, 1 reply; 7+ messages in thread From: Suzuki K Poulose @ 2018-10-09 17:22 UTC (permalink / raw) To: linux-arm-kernel On 08/10/18 13:34, Dongjiu Geng wrote: > The commit 539aee0edb9f ("KVM: arm64: Share the parts of > get/set events useful to 32bit") shares the get/set events > helper for arm64 and arm32, it is better also share the check > for vcpu events capability to enable 32 bit kvm vcpu events > support. > > User space will check whether KVM supports vcpu events through > KVM_CAP_VCPU_EVENTS IOCTL. nit: User space will check whether KVM supports vcpu events by checking the KVM_CAP_VCPU_EVENTS extension. > > Cc: James Morse <james.morse@arm.com> > Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com> > --- > For the 32 bits kvm migration, it needs to enable the vcpu events, > this patch will enable it. The user space QEMU patch is here: > https://patchwork.ozlabs.org/patch/975615/ > --- > arch/arm64/kvm/reset.c | 1 - > virt/kvm/arm/arm.c | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > index fd37c53..e50245e 100644 > --- a/arch/arm64/kvm/reset.c > +++ b/arch/arm64/kvm/reset.c > @@ -82,7 +82,6 @@ int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) > break; > case KVM_CAP_SET_GUEST_DEBUG: > case KVM_CAP_VCPU_ATTRIBUTES: > - case KVM_CAP_VCPU_EVENTS: > r = 1; > break; > default: > diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c > index 40e79ea..64e5d97 100644 > --- a/virt/kvm/arm/arm.c > +++ b/virt/kvm/arm/arm.c > @@ -212,6 +212,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > case KVM_CAP_READONLY_MEM: > case KVM_CAP_MP_STATE: > case KVM_CAP_IMMEDIATE_EXIT: > + case KVM_CAP_VCPU_EVENTS: > r = 1; > break; > case KVM_CAP_ARM_SET_DEVICE_ADDR: > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support 2018-10-09 17:22 ` Suzuki K Poulose @ 2018-10-10 4:22 ` gengdongjiu 0 siblings, 0 replies; 7+ messages in thread From: gengdongjiu @ 2018-10-10 4:22 UTC (permalink / raw) To: linux-arm-kernel Hi Suzuki On 2018/10/10 1:22, Suzuki K Poulose wrote: > > > On 08/10/18 13:34, Dongjiu Geng wrote: >> The commit 539aee0edb9f ("KVM: arm64: Share the parts of >> get/set events useful to 32bit") shares the get/set events >> helper for arm64 and arm32, it is better also share the check >> for vcpu events capability to enable 32 bit kvm vcpu events >> support. >> >> User space will check whether KVM supports vcpu events through >> KVM_CAP_VCPU_EVENTS IOCTL. > > nit: User space will check whether KVM supports vcpu events by checking > the KVM_CAP_VCPU_EVENTS extension. Thanks for the pointing out, I will update it. > >> >> Cc: James Morse <james.morse@arm.com> >> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com> > > Reviewed-by : Suzuki K Poulose <suzuki.poulose@arm.com> > >> --- >> For the 32 bits kvm migration, it needs to enable the vcpu events, >> this patch will enable it. The user space QEMU patch is here: >> https://patchwork.ozlabs.org/patch/975615/ >> --- >> ? arch/arm64/kvm/reset.c | 1 - >> ? virt/kvm/arm/arm.c???? | 1 + >> ? 2 files changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c >> index fd37c53..e50245e 100644 >> --- a/arch/arm64/kvm/reset.c >> +++ b/arch/arm64/kvm/reset.c >> @@ -82,7 +82,6 @@ int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext) >> ????????? break; >> ????? case KVM_CAP_SET_GUEST_DEBUG: >> ????? case KVM_CAP_VCPU_ATTRIBUTES: >> -??? case KVM_CAP_VCPU_EVENTS: >> ????????? r = 1; >> ????????? break; >> ????? default: >> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c >> index 40e79ea..64e5d97 100644 >> --- a/virt/kvm/arm/arm.c >> +++ b/virt/kvm/arm/arm.c >> @@ -212,6 +212,7 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) >> ????? case KVM_CAP_READONLY_MEM: >> ????? case KVM_CAP_MP_STATE: >> ????? case KVM_CAP_IMMEDIATE_EXIT: >> +??? case KVM_CAP_VCPU_EVENTS: >> ????????? r = 1; >> ????????? break; >> ????? case KVM_CAP_ARM_SET_DEVICE_ADDR: >> > > . > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-10 4:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-10-08 12:34 [PATCH v2 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng 2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng 2018-10-09 16:34 ` Suzuki K Poulose 2018-10-10 2:29 ` gengdongjiu 2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng 2018-10-09 17:22 ` Suzuki K Poulose 2018-10-10 4:22 ` gengdongjiu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).