From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD73C433F5 for ; Mon, 27 Sep 2021 17:49:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 043D860F92 for ; Mon, 27 Sep 2021 17:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 043D860F92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=9EgXXWa5HlaleNjVd0JSc9AfpbO98Dnp4gMEDaxlgtY=; b=hD/FPh4a/HNhaaIFYyVCYG/hQ+ Iwdd6jXQVOAnQHLHgeVDsForAaLaN1g8nIk35XWeaHKYY4N+VEVXZe34xewA9vu1ykydpfzz86GdH iR3sSC4oUUEcdVt1aax0QN7wfwU5+cxItq1Yh6ro+NPk2pKMWnQNyVOS7VxRK4Md7WdgiWoLD5ZJ1 lLTPM+bHmVeWKo3iL3yo/dBPi1b6dtSqIf0dY1AZ7S3Rko5pjdF/ADUUpnnfqfBKjra+FXZoRtW8v HfD50XFuoGGWlcIRst47ifmvX2v2zOvzeAUdR0YA8djjranCkjT4oM0uxbgb4MWRhXHDSM/IAQ5zk nuPPAeYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUujG-003fgY-9y; Mon, 27 Sep 2021 17:47:50 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUujB-003fdk-SQ for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 17:47:47 +0000 Received: by mail-pg1-x52a.google.com with SMTP id e7so18531390pgk.2 for ; Mon, 27 Sep 2021 10:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8NnQ5fmWzacvL/zZWYUqL5exH3PdWXZxAmvcOks4ZZ0=; b=hErXiCdFXSRg55VkQzl8DdYXIayMwIIVu0wTRRX/Kt23Qhnty+3vqEYNbPaMUb5xSC 7DLTQKmaLgdQzjnx0TRsmEa1sajeeioSWa8x+FTHFJODLgokaw1GzGCaNyOINGdB8jva VcnU+DGzpHQ2JSvt0opousmy7ZsLh8medetpefxUnstT7Nf+w+uoRztFeppQRfp+zgdj KEnw/cF5IWfZXFMuvc1fHzNhShw6XDUim4S5ZUoHLzAe/PrgygEqna1+fa5k7z6eKX3v 5mNMyfLIejlPRn+ArOOZQrJIJMQvhqO1VuZ/0TzTXASv9W3xmaxYwizv9EWBPw7x/WkV mvsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8NnQ5fmWzacvL/zZWYUqL5exH3PdWXZxAmvcOks4ZZ0=; b=THS79rvTC5A0fOjohKqLowPaeh9gIOhAry3FoXawXcSTtgy/B3bxhHVwt3MWJSLckr nK7zyN4QyHjWZgBsqs7ORSmO5VUE2a0ABbTOresZESfwfIe2XJ8T+n30hHFczAyasV8V D0vJLcxd47KKowyBRRM1bHtWsG5gXQeqgupAg/OL+UZ5raSEFLnNz+gHRLotrPE7HYfk ArIDBf5YvDa6XpVlpL1qBO8PoteCZn0ohTxH/MCfNKSb7tya3J8B+/MzWd00NnPcFm6a SUOCEifETrg1yqsaPjRpgen+jPfCmLGGg19mbpfRP50jzH9OF4LDI5evGRUD6rIWS6H7 D08A== X-Gm-Message-State: AOAM5300AW1g+KlnnmpTtlxm3kUddI+o8PtYfie9IVtFPccNrj/saV0r LM0rqsA9vUCKGrIjfAR8kTU= X-Google-Smtp-Source: ABdhPJz6fQPeWc9WXUQdnYTpow2eEkTApy2aGh2NvBRs584NTZXIEGfWblRKxvlpFw37gjuICeiq6g== X-Received: by 2002:a63:235f:: with SMTP id u31mr793854pgm.248.1632764863953; Mon, 27 Sep 2021 10:47:43 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id u12sm505547pjr.2.2021.09.27.10.47.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 10:47:43 -0700 (PDT) Subject: Re: [PATCH 03/11] genirq: Export irq_set_affinity_locked() To: Thomas Gleixner , Marc Zyngier Cc: linux-kernel@vger.kernel.org, Russell King , Ray Jui , Scott Branden , "maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE..." , Catalin Marinas , Will Deacon , Yoshinori Sato , Rich Felker , Rob Herring , Frank Rowand , Ard Biesheuvel , Mike Rapoport , Linus Walleij , Andrew Morton , Geert Uytterhoeven , Arnd Bergmann , Guenter Roeck , Kefeng Wang , Mark Rutland , Andrey Konovalov , Anshuman Khandual , Valentin Schneider , Ingo Molnar , Peter Zijlstra , "moderated list:ARM PORT" , "open list:SUPERH" , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE" References: <20210924170546.805663-1-f.fainelli@gmail.com> <20210924170546.805663-4-f.fainelli@gmail.com> <87tui8ub87.wl-maz@kernel.org> <87tui8cpwd.ffs@tglx> <87r1dccp5z.ffs@tglx> From: Florian Fainelli Message-ID: <3e73c85e-20d1-43ae-3c3a-04322ffa970e@gmail.com> Date: Mon, 27 Sep 2021 10:47:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87r1dccp5z.ffs@tglx> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_104745_964630_86EB69FD X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/25/21 2:37 PM, Thomas Gleixner wrote: > On Sat, Sep 25 2021 at 23:21, Thomas Gleixner wrote: > >> On Sat, Sep 25 2021 at 12:48, Marc Zyngier wrote: >>> On Fri, 24 Sep 2021 18:05:38 +0100, Florian Fainelli wrote: >>>> } >>>> +EXPORT_SYMBOL_GPL(irq_set_affinity_locked); >>> >>> This doesn't seem right. >>> >>> This driver seem to try and move interrupts on its own when the CPU >>> goes down. Why can't it rely on the normal CPU hotplug infrastructure >>> to do so like all the other drivers (bar some Cavium driver that does >>> the same thing)? >>> >>> I'd rather you take this opportunity to move these drivers into the >>> 21st century, so that we can kill irq_cpu_offline() and co altogether. >> >> I wanted to kill these callbacks years ago. Cavium has two variants of >> those offline/online callbacks: >> >> 1) octeon_irq_cpu_offline_ciu() which is doing the same as that BCM >> driver. These really can go away. Just remove the callback and >> everything just works. > > For BCM this works today when that chip is used on ARM[64] simply > because the only architecture which invokes irq_cpu_offline() is MIPS. That is correct. How would you recommend addressing that? In premise when this driver is used on ARM[64] it is used as a second level interrupt controller hanging off the ARM GIC (or another ARM CPU interrupt controller), so in that case I suppose I could make the irq_set_cpu_offline be dependent upon CONFIG_SMP and CONFIG_MIPS, would that be acceptable? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel