From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7FCBC4708F for ; Fri, 4 Jun 2021 06:16:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B6F2600D3 for ; Fri, 4 Jun 2021 06:16:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B6F2600D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=WI8glY1Ii1JUI8lQAufentvTtuKqBVWYVMSGjZ/6wGc=; b=AGP/vrjBtOcR5hR2TBmfLeys+a gHhOSMOE1Y6OdXFJeUZip3tSGf929PozFivapss0kWupSebW+P1XX134D61R0d1TfYbxD6Gogl+Aw 0/2ZilqxH/kuCk/WydLuZWYc9aJAlO2uXFQnmpBCZUCppEYpK5BDhH78rvqihXjLVjwYhZPHAqrMJ whhad/8GdWFzPqV847uvGnBcL00nALYEittg2osMe3FI23tWBSqSUhEhLtLW5U0HC21BITweE2U6c TlJtlL45qtSXVn0kLFadWiqGLdoixgDfw7w7PCkZUz20OrWskI1JHw3I5P+Iv9BXOQQgKnISYEMhQ +HW7yyEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp36s-00BhRa-8W; Fri, 04 Jun 2021 06:15:10 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lp36o-00BhP3-6o for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 06:15:08 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1546EwYB115747; Fri, 4 Jun 2021 01:14:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1622787298; bh=4qEDJWt0SZhUJ71xYJKiN5cbwLyBfuhRa91+nNrSIOA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=JzktDYkdU2BW41ab/6s30Vi/DIc0ORyIiYX+OXSi884Hx6+7hEuupyASe1fexiJ39 ftyH6BaKJ0vtGmToqgSX0n59ZJOb5QcwA8CyFClIF0XiWgv6rtfFPwocQ40G0SK9em 3nKrC1MmEHR9tt6Fzc7Hu5ABGXn8lEiJb8v/Pghk= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1546Ew8q100327 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 4 Jun 2021 01:14:58 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 01:14:57 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Fri, 4 Jun 2021 01:14:57 -0500 Received: from [10.250.35.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1546EuVS007115; Fri, 4 Jun 2021 01:14:56 -0500 Subject: Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding To: Wilken Gottwalt CC: Bjorn Andersson , Rob Herring , Mathieu Poirier , Maxime Ripard , Chen-Yu Tsai , , , , , References: <20210603144216.10327-1-s-anna@ti.com> <20210604065543.3d71ca53@monster.powergraphx.local> From: Suman Anna Message-ID: <3eb7afb6-629e-bac9-9a5b-7626a3f2359b@ti.com> Date: Fri, 4 Jun 2021 01:14:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210604065543.3d71ca53@monster.powergraphx.local> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_231506_539779_A62F18B5 X-CRM114-Status: GOOD ( 22.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/3/21 11:55 PM, Wilken Gottwalt wrote: > On Thu, 3 Jun 2021 09:42:16 -0500 > Suman Anna wrote: > >> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched >> $id and fails to compile the example due to undefined args specifier >> values for clocks and resets. Fix both of these issues. >> >> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock") >> Signed-off-by: Suman Anna >> --- >> Hi Wilken, >> >> This fixes the warnings for now on linux-next, but I think the example >> should be including sun6i-a31-ccu.h files instead to be accurate, and >> those files are missing the definitions for CLK_BUS_SPINLOCK and >> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental >> patch on top. >> >> regards >> Suman > > Hi Suman, > > thank you for fixing this. I would have fix it the same way for now, so it is > fine for me. But I will keep an eye on it. Thanks Will. Bjorn, Do ignore the RFC tag then, and you can pick up the patch. regards Suman > > greetings, > Will > >> .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml >> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index >> 733c3d01e56c..10e5a53e447b 100644 --- >> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++ >> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) >> %YAML 1.2 >> --- >> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml# >> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs >> @@ -36,6 +36,9 @@ additionalProperties: false >> >> examples: >> - | >> + #include >> + #include >> + >> hwlock@1c18000 { >> compatible = "allwinner,sun6i-a31-hwspinlock"; >> reg = <0x01c18000 0x1000>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel