RE: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in .pin_config_group_get() callback

Prabhakar Mahadev Lad
2026-05-05T10:49:17Z

> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: 30 April 2026 16:33
> To: Linus Walleij <linusw@kernel.org>; Lorenzo Bianconi
> <lorenzo@kernel.org>; Sean Wang <sean.wang@kernel.org>; Paul Cercueil
> <paul@crapouillou.net>; Tony Lindgren <tony@atomide.com>; Haojian Zhuang
> <haojian.zhuang@linaro.org>; Matthias Brugger <matthias.bgg@gmail.com>;
> AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: linux-gpio@vger.kernel.org; linux-mediatek@lists.infradead.org; linux-
> kernel@vger.kernel.org; linux-mips@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-omap@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; Geert Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH 5/7] pinctrl: renesas: rzg2l: Fix type in
> .pin_config_group_get() callback
>
> On 64-bit platforms, "unsigned long" is 64-bit. Hence checking if all
> "unsigned long" configuration values are equal should be done using an
> "unsigned long" temporary.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/pinctrl/renesas/pinctrl-rzg2l.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index bc2154b695149809..5b0f23af5a6cc9de 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -1647,8 +1647,9 @@ static int rzg2l_pinctrl_pinconf_group_get(struct
> pinctrl_dev *pctldev,
> unsigned int group,
> unsigned long *config)
> {
> + unsigned long prev_config = 0;
> const unsigned int *pins;
> - unsigned int i, npins, prev_config = 0;
> + unsigned int i, npins;
> int ret;
>
> ret = pinctrl_generic_get_group_pins(pctldev, group, &pins, &npins);
> --
> 2.43.0