From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC390D3C933 for ; Mon, 21 Oct 2024 04:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eCSSf1k7jvbBbq7tpGklWHi9HMsiZ3SB7BHNcg2VRDQ=; b=kpuC3IYasv9Wfpo62nR580jZWD 5jmwzQWYEXec+b8rhavX50vSn3UDfd2Eh1cXC3C5CvRXwnEWEqdDJdGzsSF+jL0hMyneGdDqbrrIN Z1T0EZlZr+jbDqCH7jciSg8nTmqwDLA9eJGyIYPHCO2Ydu+TbPY/mSSsVKqhd7WjMjGf0PC8JpbH+ 7Bfo+JLHPxPhrLDW/nxnDKZQNW0EEJCT3DZCkONebOJghmHDn4GvQGyK9X5d/faedmAdNJvg4y/y6 gouiGsod1+N1xwtGNAzpowVephJ6FINauCP1pPHKiklCaNz8AOASOTcCbg0o8KsEugtOgpUA0yYko ou+mzDhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2jl3-000000060Cx-0zxs; Mon, 21 Oct 2024 04:11:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t2jjY-0000000607N-1x27 for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2024 04:09:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25495DA7; Sun, 20 Oct 2024 21:10:01 -0700 (PDT) Received: from [10.162.16.109] (a077893.blr.arm.com [10.162.16.109]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FAE13F73B; Sun, 20 Oct 2024 21:09:28 -0700 (PDT) Message-ID: <3f1eb97e-0fa6-47d9-96d6-9fedabd969f7@arm.com> Date: Mon, 21 Oct 2024 09:39:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] arm64/hw_breakpoint: Enable FEAT_Debugv8p9 To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Jonathan Corbet , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , Mark Rutland , kvmarm@lists.linux.dev References: <20241001043602.1116991-1-anshuman.khandual@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241001043602.1116991-1-anshuman.khandual@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241020_210932_580848_2D22BC98 X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/1/24 10:05, Anshuman Khandual wrote: > This series enables FEAT_Debugv8p9 thus extending breakpoint and watchpoint > support upto 64. This series is based on v6.12-rc1 after applying the KVM > FEAT_FGT2 FGU series. > > https://lore.kernel.org/all/20241001024356.1096072-1-anshuman.khandual@arm.com/ > > Cc: Jonathan Corbet > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: James Morse > Cc: Suzuki K Poulose > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Brown > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: kvmarm@lists.linux.dev > Cc: linux-kernel@vger.kernel.org > > Changes in V1: > > - Changed FTR_STRICT to FTR_NONSTRICT for the following ID_AA64DFR1_EL1 > register fields - ABL_CMPs, DPFZS, PMICNTR, CTX_CMPs, WRPs and BRPs > > Changes in RFC V2: > > https://lore.kernel.org/linux-arm-kernel/20240620092607.267132-1-anshuman.khandual@arm.com/ > > - This series has been split from RFC V1 dealing only with arm64 breakpoints > - Restored back DBG_MDSCR_MASK definition (unrelated change) > - Added preempt_disable()/enable() blocks between selecting banks and registers > > Changes in RFC: > > https://lore.kernel.org/all/20240405080008.1225223-1-anshuman.khandual@arm.com/ > > Anshuman Khandual (3): > arm64/cpufeature: Add field details for ID_AA64DFR1_EL1 register > arm64/boot: Enable EL2 requirements for FEAT_Debugv8p9 > arm64/hw_breakpoint: Enable FEAT_Debugv8p9 > > Documentation/arch/arm64/booting.rst | 19 ++++++++++ > arch/arm64/include/asm/debug-monitors.h | 1 + > arch/arm64/include/asm/el2_setup.h | 27 +++++++++++++ > arch/arm64/include/asm/hw_breakpoint.h | 50 ++++++++++++++++++++----- > arch/arm64/include/asm/kvm_arm.h | 1 + > arch/arm64/kernel/cpufeature.c | 21 ++++++++--- > arch/arm64/kernel/debug-monitors.c | 16 ++++++-- > arch/arm64/kernel/hw_breakpoint.c | 33 ++++++++++++++++ > 8 files changed, 149 insertions(+), 19 deletions(-) > Hello, Gentle ping ! Any updates on this series ? Although I realize that this series is dependent on the other FEAT_FGT2 series [1] for MDSELR_EL1 access handling in KVM and sysreg definitions, but just wondering if proposed breakpoint and watchpoint changes are okay or something needs to be changed. Thank you. [1] https://lore.kernel.org/all/20241001024356.1096072-1-anshuman.khandual@arm.com/ - Anshuman