From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC698C4167B for ; Mon, 11 Dec 2023 17:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7kWSAIYq1q6902neh4eC8gLWw3EPbdN8uWy3WGvmOKo=; b=iuLuHsWbxX1zdm CwpXV4g4FTELWgHggDN9WhaNda03Un1cqNvwOWdba1wqKzu/1nw5ZZV1Uc/TXvq/spKUezlEVOCjo 0P7DhfYvhuNZjbIFG9XtdjGona00g1vBSlhfjgvbDYm6hF1gPPpxzArMCXgNaTRUppaTKtaH+wy37 QsUnWXtVUY9XucKTah9d091B7A/g47aDPdkTWFt9VDrfB6ph6CghGl3WoGT0HCoW2RbwsSNDgx2cj j6WKnHtpVlbcyM8Oo5Yq8JO4ulVeMsBmikx6/EVOrV4ur6IJNlypD852oZt4VveztAos4JOJ1AWjg /vwo6YsQ6LZiU2UIXAlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCjyi-006G7O-2K; Mon, 11 Dec 2023 17:22:00 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCjyg-006G5Z-0f for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 17:21:59 +0000 Received: by mail-ot1-x329.google.com with SMTP id 46e09a7af769-6d9d0d0e083so3737026a34.2 for ; Mon, 11 Dec 2023 09:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1702315317; x=1702920117; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9O17D9j4YT4XtoaSYd3/nhs4s1HCIt9uZx1EA+AxCks=; b=j7VBdDauiIA5PDqDewSS64CdrBtxc7VifY/AQWLybTm8AYLfmJTzKusiV0vMJ3yNRl EpfyV32q4rECV8Jhg0pAjCGiqusRr6rBlqP+IyJbXwIfF3UNd4shnj2ZEtP6QkSPiXLg VouNQNq/IymXDa0H4vyz5FKRbH86RBqPdVQ384VYsHtFZHot28sXP2VAUIIpLg8pSNlU t/5spV9mgcwhlnJQ2H6nTn4FOHW7mOCZ6WpIkwAnHeKhDSwawz1VkLsG+2P5MA5nWhqz ieJsRSPe9qVuZOZ+gobNcGhRng9yrjAw92kXxzSwLuQSFZeS+ycg2J3/Jm0R/sdJ5mFL OO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702315317; x=1702920117; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9O17D9j4YT4XtoaSYd3/nhs4s1HCIt9uZx1EA+AxCks=; b=JGwmNUEIsrxcBnaZXOdYWk3mndpkb9J3W9B/RgNFjMIII61TQDZh/RuD3fW3Mkpmxf Ji0fvnKqEQTfi59+o4+CFL/rh/zZ/Pl+wAn4cZhF4q4FqtgCZjV4PLSajKhXeC/AveDY tWNiL8mE0oqUZ30yKTYC+dmlxA3HJEbdhBthfHSXQF+c1OCw83sUkSS1gPiBMuKsP+EX uLZIlkKcEOYDbFQFPOSLIWk81jGucdVVS3jgzx+8AMASml0x/cGFI9zpiYf9YJbk+vdx eKpndwKe3cvC/by02mUBsm/ZTb7EIBu3vf48aNJTkI2f6G7hEMllhuGpVwSHymG6jCV6 BPqw== X-Gm-Message-State: AOJu0YzqXCVFG9hHX0BhMfBDX296XEqkSPy4Ij9WbgM6Amzp/sOrhLti 4CSprknScijoP9UI+mL5/7lbL98dVDvVRR7+JjsYtQ== X-Google-Smtp-Source: AGHT+IHy4FKXKcoa5vr1zWRR7h8ldItNotN+bq27os2Gmy1WmTZV3fGNzyOi2gfObdJOXzxcGBLOzA== X-Received: by 2002:a05:6214:1fd9:b0:67e:b878:8e48 with SMTP id jh25-20020a0562141fd900b0067eb8788e48mr4904522qvb.39.1702311375258; Mon, 11 Dec 2023 08:16:15 -0800 (PST) Received: from ?IPV6:2600:1700:2000:b002:f8a3:26ec:ac85:392e? ([2600:1700:2000:b002:f8a3:26ec:ac85:392e]) by smtp.gmail.com with ESMTPSA id d17-20020a0cf6d1000000b0067a18167533sm3380983qvo.83.2023.12.11.08.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 08:16:15 -0800 (PST) Message-ID: <3f28c1f7-f29c-461f-a90e-58d8e0996cc0@sifive.com> Date: Mon, 11 Dec 2023 10:16:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/12] riscv: Add support for kernel-mode FPU Content-Language: en-US To: Christoph Hellwig Cc: linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-arch@vger.kernel.org References: <20231208055501.2916202-1-samuel.holland@sifive.com> <20231208055501.2916202-10-samuel.holland@sifive.com> From: Samuel Holland In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_092158_257901_4F621DB8 X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-12-11 10:11 AM, Christoph Hellwig wrote: >> +#ifdef __riscv_f >> + >> +#define kernel_fpu_begin() \ >> + static_assert(false, "floating-point code must use a separate translation unit") >> +#define kernel_fpu_end() kernel_fpu_begin() >> + >> +#else >> + >> +void kernel_fpu_begin(void); >> +void kernel_fpu_end(void); >> + >> +#endif > > I'll assume this is related to trick that places code in a separate > translation unit, but I fail to understand it. Can you add a comment > explaining it? Yes, I can add a comment. Here, __riscv_f refers to RISC-V's F extension for single-precision floating point, which is enabled by CC_FLAGS_FPU. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel