From: Aradhya Bhatia <aradhya.bhatia@linux.dev>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jyri Sarha <jyri.sarha@iki.fi>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
Linus Walleij <linusw@kernel.org>,
Chaoyi Chen <chaoyi.chen@rock-chips.com>,
Vicente Bergas <vicencb@gmail.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/tidss: Fix enable/disable order
Date: Mon, 8 Dec 2025 11:26:54 +0000 [thread overview]
Message-ID: <3f2aee2b-578a-4d82-8dac-14cb9f2ada05@linux.dev> (raw)
In-Reply-To: <20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com>
On 05/12/2025 09:51, Tomi Valkeinen wrote:
> TI's OLDI and DSI encoders need to be set up before the crtc is enabled,
> but the DRM helpers will enable the crtc first. This causes various
> issues on TI platforms, like visual artifacts or crtc sync lost
> warnings.
>
> Thus drm_atomic_helper_commit_modeset_enables() and
> drm_atomic_helper_commit_modeset_disables() cannot be used, as they
> enable the crtc before bridges' pre-enable, and disable the crtc after
> bridges' post-disable.
>
> Open code the drm_atomic_helper_commit_modeset_enables() and
> drm_atomic_helper_commit_modeset_disables(), and first call the bridges'
> pre-enables, then crtc enable, then bridges' post-enable (and vice versa
> for disable).
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Cc: stable@vger.kernel.org # v6.17+
> ---
> drivers/gpu/drm/tidss/tidss_kms.c | 30 +++++++++++++++++++++++++++---
> 1 file changed, 27 insertions(+), 3 deletions(-)
>
Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
next prev parent reply other threads:[~2025-12-08 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20251205095238eucas1p1b7cf95d86a9aecf19877ac568148e265@eucas1p1.samsung.com>
2025-12-05 9:51 ` [PATCH 0/4] drm: Revert and fix enable/disable sequence Tomi Valkeinen
2025-12-05 9:51 ` [PATCH 1/4] Revert "drm/atomic-helper: Re-order bridge chain pre-enable and post-disable" Tomi Valkeinen
2025-12-08 11:23 ` Aradhya Bhatia
2025-12-05 9:51 ` [PATCH 2/4] Revert "drm/mediatek: dsi: Fix DSI host and panel bridge pre-enable order" Tomi Valkeinen
2025-12-05 9:51 ` [PATCH 3/4] drm/atomic-helper: Export and namespace some functions Tomi Valkeinen
2025-12-08 11:24 ` Aradhya Bhatia
2025-12-05 9:51 ` [PATCH 4/4] drm/tidss: Fix enable/disable order Tomi Valkeinen
2025-12-08 11:26 ` Aradhya Bhatia [this message]
2025-12-05 12:36 ` [PATCH 0/4] drm: Revert and fix enable/disable sequence Linus Walleij
2025-12-05 14:25 ` Marek Szyprowski
2025-12-08 11:06 ` Maxime Ripard
2025-12-12 14:21 ` Tomi Valkeinen
2025-12-14 11:14 ` Linus Walleij
2025-12-14 12:42 ` Tomi Valkeinen
2025-12-22 23:18 ` Linus Walleij
2025-12-23 11:48 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f2aee2b-578a-4d82-8dac-14cb9f2ada05@linux.dev \
--to=aradhya.bhatia@linux.dev \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaoyi.chen@rock-chips.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=lumag@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).