From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D60B3D3B7E2 for ; Mon, 8 Dec 2025 11:27:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KS9+fkJURzUJE1mmvUiBXK04jhbhsrgQmnTnkE10avY=; b=j3HspFMVV5fVu0/l9X1WJPNHR1 ZS4RI2aySBNQODF27AhcS3ppjvQ5nJQCPNMkkJhJhGItzFvw+hAmGMzexs/GU+u1S7heqoUiK9iTN bgr+DmLXGQdZeO+WVebwUNK1wtB1CFSEB7gLu7c+668LIBl3uRh890YgYc86pBZfwzx25NBMlcspI EeIInomKCoun5Ds9MoA251nPw6VeoQOHapW3bUa5XqTUsjMypgRb7NecllBvlOTTJPMTm1mGVfLgh 9ILjmdut0lx41fE6k31Hd3OEazQr97UEuOP9Om2OF5ZegtUe2Dyp1NM4ohKUZ/8V1WUuTszrux5AA bM9LMevw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSZOa-0000000D0ee-3o53; Mon, 08 Dec 2025 11:27:12 +0000 Received: from out-172.mta0.migadu.com ([91.218.175.172]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vSZOW-0000000D0dF-3ij8 for linux-arm-kernel@lists.infradead.org; Mon, 08 Dec 2025 11:27:10 +0000 Message-ID: <3f2aee2b-578a-4d82-8dac-14cb9f2ada05@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765193224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KS9+fkJURzUJE1mmvUiBXK04jhbhsrgQmnTnkE10avY=; b=RZdoCdds7YbZnHkW/nYm6bY4Esp1KjkxKwlJIihYgTfYeYRjDlUR+QMDbixZCFIL3ijkfb MRc4SImvpFbKrkzgt+mxIM/1RqwJgHViy1Bvvv5PWU7XWqKJfJYPOIEoDHWSHfQFq+aJD9 6YpG+e5x6gt+bZ2igvQFu1iLzobsD64= Date: Mon, 8 Dec 2025 11:26:54 +0000 MIME-Version: 1.0 Subject: Re: [PATCH 4/4] drm/tidss: Fix enable/disable order To: Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Dmitry Baryshkov , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Jyri Sarha Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski , Louis-Alexis Eyraud , Linus Walleij , Chaoyi Chen , Vicente Bergas , Marek Vasut , stable@vger.kernel.org References: <20251205-drm-seq-fix-v1-0-fda68fa1b3de@ideasonboard.com> <20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Aradhya Bhatia In-Reply-To: <20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251208_032709_111203_B5FCB5E3 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/12/2025 09:51, Tomi Valkeinen wrote: > TI's OLDI and DSI encoders need to be set up before the crtc is enabled, > but the DRM helpers will enable the crtc first. This causes various > issues on TI platforms, like visual artifacts or crtc sync lost > warnings. > > Thus drm_atomic_helper_commit_modeset_enables() and > drm_atomic_helper_commit_modeset_disables() cannot be used, as they > enable the crtc before bridges' pre-enable, and disable the crtc after > bridges' post-disable. > > Open code the drm_atomic_helper_commit_modeset_enables() and > drm_atomic_helper_commit_modeset_disables(), and first call the bridges' > pre-enables, then crtc enable, then bridges' post-enable (and vice versa > for disable). > > Signed-off-by: Tomi Valkeinen > Cc: stable@vger.kernel.org # v6.17+ > --- > drivers/gpu/drm/tidss/tidss_kms.c | 30 +++++++++++++++++++++++++++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > Reviewed-by: Aradhya Bhatia