From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63B86C433FE for ; Tue, 18 Oct 2022 13:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nq6aIUdHimBhbQPEMgi7O6HiSrgPTwc1desjmNWzCG0=; b=U6Wgf97lqESnv7 t0Xcr9xUIqhXE8gyab1eWb+icrXM+XhZqcgVzAyjloDz6pVtEAVYthIM4ZcNjq+Zo/RkjqJmOvkmp yMN+spxPOjHB3hLvVhnn2H1ZnETEv0WoIhwTkXASXTny9gcJCcMfVcFhqB5epBmZk6pn85adkeimh 8uQNlcGm9eFpEBvMRR3flZbM4LsZl7PgT832ohdnbXRcVmmw/R12iAOcUN3UxWsnaRaRAi66apTFD NzMuw+k0OEzYhE9m1FOzKgYO/JvSYhiMvtzpWABRPAp8dI5MXPfjCPTEK2GnqjX9QZYkdKZopz1m8 HV84O6Mu8MZYkXlmBWVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1okmM7-006vgT-GT; Tue, 18 Oct 2022 13:10:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1okmM2-006vde-GK for linux-arm-kernel@lists.infradead.org; Tue, 18 Oct 2022 13:10:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA56EB81F1D; Tue, 18 Oct 2022 13:09:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 547D7C433D6; Tue, 18 Oct 2022 13:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666098593; bh=Gjhm/s/yibZyBOljamtWhCKr3oz98vC+6kbBR7ZDIqk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O+J3ODY7IbDk8Am1Z+2eYA2tfMHUPa58Q7kZiiS0fVSCZFjIgrya+Zy3LnR0nvhJC rZU4weULmKd2kkng4j+NaO7qZGRD70Vl3lOXhK/VfqVghwyh8TdIltzo+YeNj7WM7r ZSYkb1zX/CieMaZ1pLE/9KaTLImhkj9sIWhWup7jFZi7Q0lPNybnfiFchuzOrYlVcw nC2KaQ4SUOAGHA7Bj+QAykiaYWFaZ2MJx+iWgFwuPED8Ez0STSIbPolquWgARnjgIV v8bE/QXI/GscOh6blTxhnABZFX11zWzLMC28MdRzIPVBOuRecfoKrrfuLuNkbeanGb vHeWOFcxVPMYg== Message-ID: <3f2f8e87-3d9e-5742-408a-17f96df6f9ca@kernel.org> Date: Tue, 18 Oct 2022 09:09:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT schema for MFC Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, linux-fsd@tesla.com, smitha.t@samsung.com References: <20221011122516.32135-1-aakarsh.jain@samsung.com> <20221011122516.32135-2-aakarsh.jain@samsung.com> <87380fdb-4053-e8dc-e997-b7c42be025ca@kernel.org> <000001d8e233$04db73d0$0e925b70$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <000001d8e233$04db73d0$0e925b70$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_060958_886081_FFC69957 X-CRM114-Status: GOOD ( 18.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/10/2022 10:16, Aakarsh Jain wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] >> Sent: 12 October 2022 18:27 >> To: aakarsh jain ; linux-arm- >> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux- >> kernel@vger.kernel.org; devicetree@vger.kernel.org >> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com; >> mchehab@kernel.org; hverkuil-cisco@xs4all.nl; >> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com; >> benjamin.gaignard@collabora.com; stanimir.varbanov@linaro.org; >> dillon.minfei@gmail.com; david.plowman@raspberrypi.com; >> mark.rutland@arm.com; robh+dt@kernel.org; krzk+dt@kernel.org; >> andi@etezian.org; alim.akhtar@samsung.com; aswani.reddy@samsung.com; >> pankaj.dubey@samsung.com; linux-fsd@tesla.com; smitha.t@samsung.com >> Subject: Re: [Patch v3 01/15] dt-bindings: media: s5p-mfc: Add new DT >> schema for MFC >> >> On 11/10/2022 08:25, aakarsh jain wrote: >>> From: Smitha T Murthy >>> >>> Convert DT schema for s5p-mfc in yaml format >> >> Convert S5P-MFC bindings to DT schema. >> >> You also missed full-stop. >> > Ok will address it in next series. > >> My second comment was ignored here. >> > I missed one review comment which was related to change in commit message. Will address it in next series. >>> >>> Cc: linux-fsd@tesla.com >>> Signed-off-by: Smitha T Murthy >>> Signed-off-by: Aakarsh Jain >>> --- >>> .../devicetree/bindings/media/s5p-mfc.txt | 75 -------- >>> .../bindings/media/samsung,s5p-mfc.yaml | 163 >> ++++++++++++++++++ >>> 2 files changed, 163 insertions(+), 75 deletions(-) create mode >>> 100644 Documentation/devicetree/bindings/media/samsung,s5p-mfc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt >>> b/Documentation/devicetree/bindings/media/s5p-mfc.txt >>> index aa54c8159d9f..8b137891791f 100644 >>> --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt >>> +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all requested >> changes or keep discussing them. >> >> Thank you. >> > Apart from your second review comment I guess we have addressed all your review comments in the current patch. > Please review other changes as well and let us know if any changes required. No, as I said you did not. Instead of bouncing back immediately, go through previous emails and through reviews. I already reviewed this patch and it did not apply all my comments. Asking me to review second time is not the solution here. The solution here is for you to go through the comments and implement them, or answer and keep discussion going. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel