From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml
Date: Tue, 12 Apr 2022 11:00:50 +0200 [thread overview]
Message-ID: <3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org> (raw)
In-Reply-To: <20220411111858.16814-1-tony@atomide.com>
On 11/04/2022 13:18, Tony Lindgren wrote:
> Let's update the TI timer binding to use yaml. As this binding is specific
> to the TI dual-mode timers also known as dm-timers, let's use file name
> ti,timer-dm.yaml to avoid confusion with other timers.
>
> We also correct the issue with the old binding that was out of date for
> several properties.
>
> The am43 related timers are undocumented, but compatible with the am3
> timers. Let's add the am43 timers too.
>
> The dm814 and dm816 timers are missing, let's add them.
>
> Some timers on some SoCs are dual mapped, like the ABE timers on omap4
> and 5. The reg property maxItems must be updated to 2.
(...)
> + reg:
> + minItems: 1
> + maxItems: 2
> + description: Timer IO register range
> +
Apart from what Grygorii said, it would be useful if you add "if:then:"
case constraining it per implementation (as I understood from commit msg
only some use double mapping).
This looks like:
https://elixir.bootlin.com/linux/v5.18-rc2/source/Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml#L53
Similarly should be done for clocks, unless it's impossible (same
compatible uses different setups of clocks).
BTW, it's a bit confusing it is not a v2...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-12 9:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 11:18 [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Tony Lindgren
2022-04-11 11:18 ` [PATCH 2/2] dt-bindings: timer: Add compatible for am6 for TI timer-dm Tony Lindgren
2022-04-12 8:52 ` Krzysztof Kozlowski
2022-04-12 8:38 ` [PATCH 1/2] dt-bindings: timer: Update TI timer to yaml Grygorii Strashko
2022-04-12 8:51 ` Tony Lindgren
2022-04-12 9:48 ` Grygorii Strashko
2022-04-12 9:00 ` Krzysztof Kozlowski [this message]
2022-04-12 9:10 ` Tony Lindgren
2022-04-12 9:13 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2022-04-12 13:16 [PATCHv3 0/2] Convert TI dmtimer binding " Tony Lindgren
2022-04-12 13:16 ` [PATCH 1/2] dt-bindings: timer: Update TI timer " Tony Lindgren
2022-04-12 17:06 ` Krzysztof Kozlowski
2022-04-13 6:04 ` Tony Lindgren
2022-04-13 8:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f3ec103-a7d8-b56d-afff-94a0379dffec@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).