From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4740CEE4993 for ; Tue, 22 Aug 2023 09:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cfIxJoHOFtU9b0uairoYy52XH3yP9nShqLeEBFPIAbg=; b=JsKx9EVUR2w4ku zQym+sqpnl2lPY6S5R2BzNoPYW98YNc+5Ji9blYuK1+mjR1teSHusUhUojps8yANY/A9NfSVIYSpM mjlMCvmh2OYssoq4tX6J4RjJwAfCiBC5i6kjr2oDZBwdaHjFF+n8K/T+dd3J1mELythsvEVP47nDL BM66Yl/EPcwgmcFy6JHMYGi/54n9CR0y7Zs25US8wfQ28aKhZxq561fao/6TZCoI4CFU32/pwfbv8 xWfIa1awDS7GjSnOOOh/W8Oq+xsTe3W7Nt6fyvlZ1UQsbP8aiu2DtHZjtKuz909tGAvn8CebgyXT2 g81QdMuZrDW+lRHCl5NA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYNir-00FYGv-21; Tue, 22 Aug 2023 09:30:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qYNip-00FYFi-03 for linux-arm-kernel@lists.infradead.org; Tue, 22 Aug 2023 09:30:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 615A511FB; Tue, 22 Aug 2023 02:31:23 -0700 (PDT) Received: from [10.57.5.95] (unknown [10.57.5.95]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0EE1F3F64C; Tue, 22 Aug 2023 02:30:40 -0700 (PDT) Message-ID: <3f630d3d-c59a-f454-14db-2bf9b8e76877@arm.com> Date: Tue, 22 Aug 2023 10:30:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: Add a max_tlbi_ops for __arm_smmu_tlb_inv_range() Content-Language: en-GB To: Nicolin Chen , will@kernel.org, jgg@nvidia.com Cc: joro@8bytes.org, jean-philippe@linaro.org, apopple@nvidia.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev References: <3ba332e141102d31b756326cdc4078cac1f5ab1c.1692693557.git.nicolinc@nvidia.com> From: Robin Murphy In-Reply-To: <3ba332e141102d31b756326cdc4078cac1f5ab1c.1692693557.git.nicolinc@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230822_023047_174450_7861A8E8 X-CRM114-Status: GOOD ( 27.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-08-22 09:45, Nicolin Chen wrote: > When receiving an __arm_smmu_tlb_inv_range() call with a large size, there > could be a long latency at this function call: one part is coming from a > large software overhead in the routine of building commands, and the other > part is coming from CMDQ hardware consuming the large number of commands. > This latency could be significantly large on an SMMU that does not support > range invalidation commands, i.e. no ARM_SMMU_FEAT_RANGE_INV. > > One way to optimize this is to replace a large number of VA invalidation > commands with one single per-asid or per-vmid invalidation command, if an > invalidation size reaches a preset threshold using the number of entries > per io-pgtable, similar to the MAX_TLBI_OPS in arm64's tlbflush.h. > > Add a max_tlbi_ops in arm_smmu_domain, and convert a large number of per- > granule TLBI commands to one single per-asid or per-vmid TLBI command, on > SMMUs without ARM_SMMU_FEAT_RANGE_INV. > > Signed-off-by: Nicolin Chen > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 10 +++++++++- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 + > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index d6c647e1eb01..3f0db30932bd 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -1897,7 +1897,14 @@ static void __arm_smmu_tlb_inv_range(struct arm_smmu_cmdq_ent *cmd, > if (!size) > return; > > - if (smmu->features & ARM_SMMU_FEAT_RANGE_INV) { > + if (!(smmu->features & ARM_SMMU_FEAT_RANGE_INV)) { > + /* > + * When the size reaches a threshold, replace per-granule TLBI > + * commands with one single per-asid or per-vmid TLBI command. > + */ > + if (size >= granule * smmu_domain->max_tlbi_ops) > + return arm_smmu_tlb_inv_domain(smmu_domain); This looks like it's at the wrong level - we should have figured this out before we got as far as low-level command-building. I'd have thought it would be a case of short-circuiting directly from arm_smmu_tlb_inv_range_domain() to arm_smmu_tlb_inv_context(). > + } else { > /* Get the leaf page size */ > tg = __ffs(smmu_domain->domain.pgsize_bitmap); > > @@ -2258,6 +2265,7 @@ static int arm_smmu_domain_finalise(struct iommu_domain *domain, > } > > smmu_domain->pgtbl_ops = pgtbl_ops; > + smmu_domain->max_tlbi_ops = pgtbl_cfg.nents_per_pgtable; And now we're carrying *three* copies of the same information around everywhere? Honestly, just pull cfg->bits_per_level out of the io_pgtable_ops at the point where you need it, like the pagetable code itself manages to do perfectly happily. Wrap it in an io-pgtable helper if you think that's cleaner. Thanks, Robin. > return 0; > } > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > index dcab85698a4e..f68c95a2e24f 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h > @@ -721,6 +721,7 @@ struct arm_smmu_domain { > struct io_pgtable_ops *pgtbl_ops; > bool stall_enabled; > atomic_t nr_ats_masters; > + unsigned long max_tlbi_ops; > > enum arm_smmu_domain_stage stage; > union { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel