From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 637BDC6FA8F for ; Wed, 30 Aug 2023 14:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TwFOdWxug6fl4QlrMMFY1CYSy8EDaJtkuWSvPuKOciU=; b=QsQY3jtmn5bvNZ O8siPxzOF59HO31k+/+tCtSuuiSuCw4u8GBezAx2bGgE5e3LxYXmYIuAk/kPwb8vhUqtUK7vJ7my8 ugahFoZFso2fINXqK4kGKk3MTsKDNvntOzU9GM+DFFkiBY7R6MP7cj78XMFtKJ/NmeZ99RnVzrZQ5 ntN3ezoZt89g+6yT071cSoiRPyTi8KUDKVyMi+4wSIxd3GQwhorUz5FBBh4uFJpMLR1L2noIa4exT wQtHf6qukiMioxem7RGX9I83xmPTuarkIcUToTSewpJt5jMwNVh5KJCP0vl1gmFnlhcck2UO2qCt8 RAhtJDQO+IQMjfjhfZEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qbMDt-00Dfuo-11; Wed, 30 Aug 2023 14:31:09 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qbMDq-00DfuC-2q for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2023 14:31:08 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5009969be25so8815982e87.3 for ; Wed, 30 Aug 2023 07:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693405862; x=1694010662; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZY0deiTnO9HqTmhq+9BgjkHv5GVPaKmFZj60VWc3fuQ=; b=WQ7QFcBvJHMsWjByxYXlVJU3NwFwlvcmF1esQ5hWk1wCGOkDAzV+EikjpBpT8M4nmf al0YaFE02Z0e4oWreUYw/CZLlOw/J8bTQTqFDVzSKAl1NIMPYvm25h1HeoQvv8E/BXlR 8tTOiX2KR41mPQ9aZ5PKIQOE4yB0F5Z7nEKAH/CWUrdGdoDtGwUqsYVqm6SL4Xq02eaS 9ItatICUQNkyBbF6CG0l/EoUqXs9IT/hSg+vagGu4tjCEwhV3khwm+W7fPHw7q54AqX1 kMGNin2C51aQ2lhMXfk+ElGT4vkBHrIoV9YErK096BnZbgFbttHWwOn9f8QTl6HppPrR 1cdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693405862; x=1694010662; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZY0deiTnO9HqTmhq+9BgjkHv5GVPaKmFZj60VWc3fuQ=; b=UitgNPp9dqp3jUOStSuM06RVSycXPcIdeXq1KP046d57hQwYMvu7XtJbSaVl5y/bKs pDBya4gRu2SnINR0IgyiWi0in5aJ4s0GBsgpFLMQCKVKsKLsuT3ay6Owrktei/6H8K7a dyhZWISRtEBOhyGsl4OAiRtmVLgqdfPj858uiszNQ9VA/Rd2M/g1tKlHU38tLyUhybg2 T+Tg/NoZo9F512AtzYhkkW4vegXQgqe6t+jDmr1xwnXn/MnFlwNvqhc8iaEx1xHRv0ff FHIWreCP+RIrQJXKbY4VHFO44F0sMsXNY0uiIqWvyu2QjOzMnXMSSywfj68IGVPh2nHV wUEQ== X-Gm-Message-State: AOJu0Yx9TDLtajxZKwQWZxKdmZKhwKVh0ed3hkaU9n62Ic9z/EL+mxfk nFHPgkBEv9rkkUChohYxeQbXZg== X-Google-Smtp-Source: AGHT+IGWIQNzv/lcLcwsBoqxI/zsSA+mv5sN7MpUDDHR/4HMuhQG491t3VHz0giePI4M6CLRnRQv0g== X-Received: by 2002:a05:6512:220d:b0:4f8:752f:df48 with SMTP id h13-20020a056512220d00b004f8752fdf48mr1753066lfu.29.1693405862090; Wed, 30 Aug 2023 07:31:02 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id b17-20020a1709062b5100b009a219ecbaf1sm7241362ejg.85.2023.08.30.07.31.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 07:31:01 -0700 (PDT) Message-ID: <3f7f6427-51eb-a251-f8dd-f7922b9fcfd7@linaro.org> Date: Wed, 30 Aug 2023 16:31:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 05/11] dt-bindings: document the Qualcomm TEE Shared Memory Bridge Content-Language: en-US To: Bartosz Golaszewski , Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Arnd Bergmann , Alex Elder , Srini Kandagatla , kernel@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230828192507.117334-1-bartosz.golaszewski@linaro.org> <20230828192507.117334-6-bartosz.golaszewski@linaro.org> <9b69a4a6-b011-f0e8-217f-5f91d9a00382@linaro.org> <48feda07-525d-4319-ba09-14928ab1fd29@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230830_073106_929118_AAF65777 X-CRM114-Status: GOOD ( 20.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2023 15:48, Bartosz Golaszewski wrote: > On Tue, 29 Aug 2023 at 11:30, Konrad Dybcio wrote: >> >> On 29.08.2023 10:02, Krzysztof Kozlowski wrote: >>> On 28/08/2023 21:25, Bartosz Golaszewski wrote: >>>> Add Device Tree bindings for Qualcomm TEE Shared Memory Brige - a >>>> mechanism that allows sharing memory buffers between trustzone and the >>>> kernel. >>> >>> Subject prefix: >>> dt-bindings: firmware: >>> >>> >>> >>>> >>>> Signed-off-by: Bartosz Golaszewski >>>> --- >>>> .../bindings/firmware/qcom,shm-bridge.yaml | 36 +++++++++++++++++++ >>>> 1 file changed, 36 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/firmware/qcom,shm-bridge.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,shm-bridge.yaml b/Documentation/devicetree/bindings/firmware/qcom,shm-bridge.yaml >>>> new file mode 100644 >>>> index 000000000000..f660962b7b86 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/firmware/qcom,shm-bridge.yaml >>>> @@ -0,0 +1,36 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/firmware/qcom,shm-bridge.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: QCOM Shared Memory Bridge >>>> + >>>> +description: | >>> >>> Do not need '|' unless you need to preserve formatting. >>> >>>> + Qualcomm TEE Shared Memory Bridge allows sharing limited areas of kernel's >>>> + virtual memory with the trustzone in order to avoid mapping the entire RAM. >>>> + >>>> +maintainers: >>>> + - Bjorn Andersson >>>> + - Konrad Dybcio >>>> + - Bartosz Golaszewski >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - qcom,shm-bridge-sa8775p >>>> + - qcom,shm-bridge-sm8150 >>>> + - qcom,shm-bridge-sm8450 >>>> + - const: qcom,shm-bridge >>>> + >>> >>> Looks quite empty... Why this cannot be part of qcom,scm? IOW, why do >>> you need new binding if you do not have any resources here and the block >>> is essentially feature of qcom,scm firmware? >> Since it's "discoverable" (via retval of an scm call), I'd second the >> idea of probing this from within the SCM driver. >> >> Konrad > > Downstream has a bunch of DT switches that we don't support for now > upstream. I disagree about shoehorning this into the SCM driver. It > really is a layer on top of SCM but also SCM is a user of this > interface. Sure, for the driver makes sense, but it does not really explain why DT node is needed. It is not separate hardware. I doubt it is even separate firmware, but part of SCM. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel