From: Marc Zyngier <maz@kernel.org>
To: Qian Cai <quic_qiancai@quicinc.com>
Cc: James Morse <james.morse@arm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY
Date: Wed, 27 Oct 2021 08:46:44 +0100 [thread overview]
Message-ID: <3fac8ddb626205286f79adde96ea527b@kernel.org> (raw)
In-Reply-To: <20211026210913.57006-1-quic_qiancai@quicinc.com>
On 2021-10-26 22:09, Qian Cai wrote:
> TRNG_NO_ENTROPY was unused when introduced and now. This is also caught
> by
> GCC (W=2):
>
> arch/arm64/kvm/trng.c:17: warning: macro "TRNG_NO_ENTROPY" is not used
> [-Wunused-macros]
> 17 | #define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> Signed-off-by: Qian Cai <quic_qiancai@quicinc.com>
> ---
> arch/arm64/kvm/trng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/trng.c b/arch/arm64/kvm/trng.c
> index 99bdd7103c9c..6a46b3ac3970 100644
> --- a/arch/arm64/kvm/trng.c
> +++ b/arch/arm64/kvm/trng.c
> @@ -14,7 +14,6 @@
> #define TRNG_SUCCESS 0UL
> #define TRNG_NOT_SUPPORTED ((unsigned long)-1)
> #define TRNG_INVALID_PARAMETER ((unsigned long)-2)
> -#define TRNG_NO_ENTROPY ((unsigned long)-3)
>
> #define TRNG_MAX_BITS64 192
That's an architectural definition that doesn't cause any problem.
If anything, that's documentation.
We have *tons* of other definitions with no user all over the
arm64 code. They save the exact same purpose.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 7:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 21:09 [PATCH] KVM: arm64: Remove unused TRNG_NO_ENTROPY Qian Cai
2021-10-27 7:37 ` Will Deacon
2021-10-27 7:46 ` Marc Zyngier [this message]
2021-10-27 15:17 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fac8ddb626205286f79adde96ea527b@kernel.org \
--to=maz@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_qiancai@quicinc.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).