public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: uniphier: delete i2c aliases
Date: Fri, 23 Oct 2015 22:16:29 +0200	[thread overview]
Message-ID: <4000897.7Un1B3qMyp@wuerfel> (raw)
In-Reply-To: <1445427390-22750-3-git-send-email-yamada.masahiro@socionext.com>

On Wednesday 21 October 2015 20:36:28 Masahiro Yamada wrote:
> The user space should not expect that a particular I2C channel is
> always visible through the same character device.
> No reason to fix the I2C indexes with aliases.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 

As I said in my reply to the earlier mail, I didn't really like the
idea of having holes in the numbering for the i2c controllers, but
this new approach also doesn't look ideal.

We should have stable bus numbers on any given board, and the aliases
work well for that. I just don't think the aliases need to be stable
between different boards just because they are based on the same
SoC.

I'd suggest staying with the current slightly awkward approach though,
to avoid regressions. Please send a follow-up patch to add the same
aliases on the new boards and drop this patch, unless someone else
can come up with a better idea.

	Arnd

  reply	other threads:[~2015-10-23 20:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-21 11:36 [PATCH 0/4] ARM: dts: uniphier: DTS updates for UniPhier SoCs for Linux 4.14-rc1 (2nd try) Masahiro Yamada
2015-10-21 11:36 ` [PATCH 1/4] ARM: dts: uniphier: use stdout-path instead of console Masahiro Yamada
2015-10-23 20:11   ` Arnd Bergmann
2015-10-21 11:36 ` [PATCH 2/4] ARM: dts: uniphier: delete i2c aliases Masahiro Yamada
2015-10-23 20:16   ` Arnd Bergmann [this message]
2015-10-24  3:24     ` Masahiro Yamada
2015-10-21 11:36 ` [PATCH 3/4] ARM: dts: uniphier: add ProXstream2 Gentil board support Masahiro Yamada
2015-10-23 20:11   ` Arnd Bergmann
2015-10-21 11:36 ` [PATCH 4/4] ARM: dts: uniphier: add ProXstream2 Vodka " Masahiro Yamada
2015-10-23 20:12   ` Arnd Bergmann
2015-10-21 11:40 ` [PATCH 0/4] ARM: dts: uniphier: DTS updates for UniPhier SoCs for Linux 4.14-rc1 (2nd try) Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4000897.7Un1B3qMyp@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox