From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D45C7C43217 for ; Wed, 19 Oct 2022 11:10:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Agm81fzJCLPFLp+3DDV4rAd/Ae/Ia8l0/cGEtUn28S8=; b=yJ3RHAJOY6Y0ffMzf4JDoS2cyL z31v8eS8QHwKtKDL71dgqm8a4mSbrIR/xGLURiQ2V8IepmS1ojLh8JgtMH5QmG18tgbRA+Zq5biHP FsK5I7a/0PxU/hYHvobMuHxRkSIPdus9Et7qCLDMAplw6ijqqJxv06b2jD58DApr20qUSaxHBZ9lT aYS8RoAokeVXZp2EDyRvUILHp07klIuXpRMDqxzbUyG+//1Gr5Xmx75r7GqPqsiGj2zVD7h6WVsHy 4EG2RZPINW/2iBIDAEof8d+FlRauWORMk6LVffUjvzqoYckzELXGjlBNulyRt3tO03qvom+5XwhLa b/kNfoAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol6wd-000o9g-7x; Wed, 19 Oct 2022 11:09:07 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol6wZ-000o21-Vr for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 11:09:05 +0000 Received: by mail-wr1-x42a.google.com with SMTP id bu30so28534893wrb.8 for ; Wed, 19 Oct 2022 04:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=nXFGzSS2/u4bVAOtY2OBuez9ms3I4wdkLTeUoseOY3A=; b=dAwR0NuwlhUCkeBGQ6sh1KnbolBlC0LAC8xBMz3KtBC/YA7DtkI/75dUzKhfABYoom 1F29QCCJDyyv+oypS5Q5HFIZOQNSuQKQ4piod2wBha4ZeUBgM48TzD5ThK0h0BkhezNU PPvBXURYF7ZhVtKZ2auhrbnW+kCQX9YH/YMA+3g38rm1DR6n5H2mVl0739mUr8a9cD9c lVv5PT/D3VkyWmo5RyY1K0fdMQsDmr3/bxK1O0JIEwJUhG4tu3D4c07HN5ZBm+EUvIjY k0fTnJ75ht8At1VXZANo36FPJ/BUUI7E4NEh3QjnekedsnJp64CKp4vs10F7ejxqNGoG 4jjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nXFGzSS2/u4bVAOtY2OBuez9ms3I4wdkLTeUoseOY3A=; b=YwfLe9k+bmrdntndQ2/O82j7ZYc2tXQTVlxcZX9++RGyecpXnBwLWFQ+PTFeOm8dkF ScUWLtgld8pLDkVgtZPHBQ9bgD3Va2hcr0qDt0ZRA3vDFBRX5wkfd0xpKFNGlh1aA/ZJ h777q8k6+jDKF4WJPyPSvh4hJ8MWtfSMFB7/wvNBzoAjcmJvP5lxiiKY/7Q9A+w/RCqJ z6ZHScXaTEHN+lpYr1UePtzEPgxdsGChYG2bVx3OUbeSdmP4D3Hq+bCCQ8qIUhSMno/k n3zy11MO0bCzMJ4H0cYTkE/vOfp1VRFmNMeYYpeNrywWybfpdJZ4sl3xdHYj3AycR/cA sbjA== X-Gm-Message-State: ACrzQf1qJ/BAu4tKK9VhhpSnKsoR2tcuVYhwKHfEOaorJOdixBMUIRtZ 0Q+x1UtEIZJ6lxCrPRvyDfNoJw== X-Google-Smtp-Source: AMsMyM6R+x5K/qnLw6cpJ0EZKFwazhL6E5XYy0THkjOXdiu8+PRsamzUWkh2rEIb+FAD6dQLyr2RWQ== X-Received: by 2002:a05:6000:1568:b0:22e:6691:57aa with SMTP id 8-20020a056000156800b0022e669157aamr4569795wrz.708.1666177740730; Wed, 19 Oct 2022 04:09:00 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:b15b:4b56:592a:c397? ([2a01:e0a:982:cbb0:b15b:4b56:592a:c397]) by smtp.gmail.com with ESMTPSA id e26-20020a05600c4b9a00b003a5537bb2besm15694485wmp.25.2022.10.19.04.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 04:09:00 -0700 (PDT) Message-ID: <402500e8-b4fe-9b8f-d634-e329191af1b8@linaro.org> Date: Wed, 19 Oct 2022 13:08:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: Neil Armstrong Subject: Re: [PATCH] arm64: dts: meson: Enable active coling using gpio-fan on Odroid N2/N2+ Content-Language: en-US To: Anand Moon , Martin Blumenstingl Cc: Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221018195122.8877-1-linux.amoon@gmail.com> Organization: Linaro Developer Services In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_040904_070494_7DC345D7 X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Anand, On 19/10/2022 11:48, Anand Moon wrote: > Hi Martin, > > On Wed, 19 Oct 2022 at 08:36, Anand Moon wrote: >> >> Hi Martin, >> >> On Wed, 19 Oct 2022 at 02:46, Martin Blumenstingl >> wrote: >>> >>> Hello Anand, >>> >>> On Tue, Oct 18, 2022 at 9:53 PM Anand Moon wrote: >>>> >>>> Odroid N2/N2+ support active cooling via gpio-fan controller. >>>> Add fan controls and tip point for cpu and ddr thermal sensor >>>> on this boards. >>> In the schematics for board rev 0.6 [0] I cannot find any information >>> about a fan connector. >>> The schematics for board rev 0.3 [1] on the other hand document a PWM >>> based fan connector on page 16. >>> So now I am not sure whether your patch only applies to certain board >>> revisions, the schematics are incorrect, etc. >>> >>> Can you please provide some details about the fan connector on >>> Odroid-N2/N2+ and which hardware revisions are supported (and which >>> aren't) by your patch? >>> >>> >> Ok I got this wrong the schematics below there is pwm controller, not >> gpio controller >> GPIOAO.BIT10 (PWM) >> I will correct the patch sorry for the mistake I did not look more carefully. >> > > As per the schematics GPIOAO_10 is controlled by PWMAO_D > But looking into the datasheet [0] I could not find the relevant > PWMAO_D pmw ip block to link the fan to the PWM controller. > > [0] https://dn.odroid.com/S922X/ODROID-N2/Datasheet/S922X_Public_Datasheet_V0.2.pdf > > I could get the PWM node but is not working for me. > > @@ -547,6 +588,14 @@ &pwm_ab { > status = "okay"; > }; > > +&pwm_AO_ab { &pwm_AO_cd not _ab > + pinctrl-1 = <&pwm_ao_d_10_pins>; > + pinctrl-names = "default"; > + clocks = <&xtal>; > + clock-names = "clkin0"; > + status = "okay"; > +}; > + > > Thanks > -Anand > > >>> Thank you! >>> Martin >>> >>> >>> [0] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.6_20210121.pdf >>> [1] https://dn.odroid.com/S922X/ODROID-N2/Schematic/odroid-n2_rev0.3_20190117.pdf >> Thanks >> -Anand Neil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel