From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6547EC433DF for ; Thu, 25 Jun 2020 09:07:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C21720720 for ; Thu, 25 Jun 2020 09:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LLD9FLOn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C21720720 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SxoaIxlkpuhstG+e/u1frX29Pr5ZWEwdUkvlyt7FTfw=; b=LLD9FLOnA0miMkpsWWVkMzatT P+hNAGAMRYGCuwbl58/i3e4ftwicQv7PPn1FX0DaYZ0jkkV6AV4FZLNkvQnP1ifLUeKRmcPKMjNNB CdkPtmmNTUtxSwT+kxT+5rK6LG2ECIk8XusSMkR9JCIleIeVcD9dQx4pq/foiKUjKW1d94WD8XGVd iyDJkuU7t035yOdvcQuuMHZjLKq2TgUh9bMy+3JgDrc81crv5j53p/aFK6Fb6FZVtaY5L+W1nzbHB n19aaLrR+k0YhHz/VF2dzWMYS2bvvFjFJICwDAl9EBBRUYI6RXfjASemBihljzrct/+8sgRReD3jL ReGO7NUzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joNow-0003r2-AW; Thu, 25 Jun 2020 09:05:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joNos-0003q2-Fs for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 09:05:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E916CC0A; Thu, 25 Jun 2020 02:05:16 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BB5F3F6CF; Thu, 25 Jun 2020 02:05:15 -0700 (PDT) Subject: Re: [PATCH v5 21/25] mm: Add arch hooks for saving/restoring tags To: Andrew Morton , Catalin Marinas References: <20200624175244.25837-1-catalin.marinas@arm.com> <20200624175244.25837-22-catalin.marinas@arm.com> <20200624114534.9520ba5ed235bc32bf1af3a2@linux-foundation.org> From: Steven Price Message-ID: <40250ed8-50fe-3945-d7d3-331e03b2abe8@arm.com> Date: Thu, 25 Jun 2020 10:04:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200624114534.9520ba5ed235bc32bf1af3a2@linux-foundation.org> Content-Language: en-GB X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Szabolcs Nagy , Andrey Konovalov , Kevin Brodsky , Peter Collingbourne , linux-mm@kvack.org, Vincenzo Frascino , Will Deacon , Dave P Martin , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/2020 19:45, Andrew Morton wrote: > On Wed, 24 Jun 2020 18:52:40 +0100 Catalin Marinas wrote: > >> From: Steven Price >> >> Arm's Memory Tagging Extension (MTE) adds some metadata (tags) to >> every physical page, when swapping pages out to disk it is necessary to >> save these tags, and later restore them when reading the pages back. >> >> Add some hooks along with dummy implementations to enable the >> arch code to handle this. >> >> Three new hooks are added to the swap code: >> * arch_prepare_to_swap() and >> * arch_swap_invalidate_page() / arch_swap_invalidate_area(). >> One new hook is added to shmem: >> * arch_swap_restore_tags() >> >> ... >> >> --- a/include/linux/pgtable.h >> +++ b/include/linux/pgtable.h >> @@ -631,6 +631,29 @@ static inline int arch_unmap_one(struct mm_struct *mm, >> } >> #endif >> >> +#ifndef __HAVE_ARCH_PREPARE_TO_SWAP >> +static inline int arch_prepare_to_swap(struct page *page) >> +{ >> + return 0; >> +} >> +#endif >> + >> +#ifndef __HAVE_ARCH_SWAP_INVALIDATE >> +static inline void arch_swap_invalidate_page(int type, pgoff_t offset) >> +{ >> +} >> + >> +static inline void arch_swap_invalidate_area(int type) >> +{ >> +} >> +#endif >> + >> +#ifndef __HAVE_ARCH_SWAP_RESTORE_TAGS >> +static inline void arch_swap_restore_tags(swp_entry_t entry, struct page *page) >> +{ >> +} >> +#endif > > Presumably these three __HAVE_ARCH_ macros are to be defined in asm/pgtable.h? That would be the idea (see patch 22). However: Catalin - you've renamed __HAVE_ARCH_SWAP_RESTORE_TAGS in patch 22, but not here! Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel