From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 557C9C54E60 for ; Sat, 16 Mar 2024 13:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XDN3Axmu/mLR4kaFE7M3IHr2VAF1w1JPMXg5RRlcBqw=; b=4UC5vHP8kT81/D W44n5M6PnzwlZR0Gyv5Bz/kTi0nyGECUFxQBjxQHCZ2fGmSzN707CaXB5FAcnnxUhJz2uouuvn86K th4vwPOmHA6d5K4PDs5LDLXlpwbsUoafNIlchNNRDlavo4IGQriLkMcxN0alNl/JSok00szjLFV4r tBi7zkE+UzPN96YfsuksJH3qSgZwRhPcUjXTRjZBiy5xcZxo6uJFPLEabTVCE8+mO1rkPzx4MLzhO bmU2cQWPfVBao3FtGQOA/M9tZmI/Sm+8WumVkFEC3HLPvtUG3whd+qhZcqs3k+8p06PXOyOPnOaty zHXDrSRFCnnbCW7SMEow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlTku-00000003A0O-3hNU; Sat, 16 Mar 2024 13:07:20 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlTkp-000000039zV-2mwc for linux-arm-kernel@lists.infradead.org; Sat, 16 Mar 2024 13:07:17 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1def142ae7bso13995985ad.3 for ; Sat, 16 Mar 2024 06:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710594428; x=1711199228; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O29l49W9XGARXAl4J0N7LLsgN9XT4ySMJ5Apk0iOPvg=; b=Z3ATB5ywFqg+25F3HFZ2dOTUKHv2GTeRIo6QjATLgXFFy1oynS0aSDED+lUKz27Sdb 0TwZlxLKCUC62wzPcLJ+qrzpVNlMEl35GlvDzYlE2ayqaK1bvTX+OOQKFl8edm56ZNvT V2Au6Wt+T0ZFQ0PRyws2zhhMbJS7XofWvEKK1cYZc2Appk9NoGul2A5wRrQo4Vmesm0v aF//jAswD7vZgEV3biGUA8tLqfHwUyaTAQUnKmox/SdyvpLAnBlZrXEH6MJW4/GeOgea iqPMB/n0/XFGxhL7gjV1aocVBahSxaHyrlY7Vlx7NVHyTCLUs2r7k8/08refKgyha8Ft eW7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710594428; x=1711199228; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O29l49W9XGARXAl4J0N7LLsgN9XT4ySMJ5Apk0iOPvg=; b=YqL49e4iApk/JUYZOmkYE2O+8cu5SRGwPG9IPPUpt/vwyUi1IwIbq9tyyf8uEqXR8t lTODsaxH5StsHs4VZNWKAB2QNVFaoOwVbBYN9eg6lAIL3/dgoQOBq7/TuwMuYpW2fC3M eAQ0QIQFxWnB1iAiV7dVPucFsPEzpzSS+Idl9Z9fwfUehchEFF5yKDSphISmnKBhnYC/ BCnPOMrUIq8SWSmPXdGzGvj8WOx6OA1GchvZVz3XWLAVC0jvuK/Xs9edvdWopqadkik9 Lfzdeqw8xJboVcjKJgONIm+8sptEg3LLA5oOrmk2WxTgyv0qVWlPQGCYnq1DPE896b+2 gp0w== X-Forwarded-Encrypted: i=1; AJvYcCUCSQgugs9bbd5BA4dUM30tmRLQlAUVFQmKoAgb3hw/bsgxZ3GoAkOXu1au8cMw8pPdIaSlDR7fzPOtLuyh8i4Ztf7Z6GH2w//mDppRHH9Z0IDhZSg= X-Gm-Message-State: AOJu0Yx6etZ5ssH8ddHVl+fPJK1PW6RqpCroA5kf8M95rOiyN6VscG8R 26I2xVa94dOQQ82hn8utiMBENzGFl2ok5HyEvP9Eh7bD9JEeaGkW X-Google-Smtp-Source: AGHT+IGPmM31pP4/EeJlrKrXYxjvW5slggKxA8CfUGLf9CovlmWxJIz6/FceDn5U368qBNv0iNC5FQ== X-Received: by 2002:a17:902:e88f:b0:1dd:6965:5888 with SMTP id w15-20020a170902e88f00b001dd69655888mr10251961plg.47.1710594428433; Sat, 16 Mar 2024 06:07:08 -0700 (PDT) Received: from [172.16.116.58] ([103.15.228.94]) by smtp.gmail.com with ESMTPSA id q6-20020a170902a3c600b001dede7dd3c7sm5277814plb.111.2024.03.16.06.07.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Mar 2024 06:07:08 -0700 (PDT) Message-ID: <402d1296-0a0c-4f85-a096-be7993869f94@gmail.com> Date: Sat, 16 Mar 2024 18:36:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: jkridner@beagleboard.org, robertcnelson@beagleboard.org, Vaishnav M A , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Jiri Slaby , Johan Hovold , Alex Elder , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, greybus-dev@lists.linaro.org References: <20240315184908.500352-1-ayushdevel1325@gmail.com> <20240315184908.500352-8-ayushdevel1325@gmail.com> <8799b216-57a7-451b-80a3-3d4ae9693e0b@linaro.org> From: Ayush Singh In-Reply-To: <8799b216-57a7-451b-80a3-3d4ae9693e0b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240316_060715_764392_6F63ABBC X-CRM114-Status: GOOD ( 10.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Are you sure this fits in Linux coding style limit (not checkpatch limit, but the limit expressed by Linux coding style)? Well, I am just using clang-format with column width of 100 instead of 80. The docs now say 80 is prefered rather than mandatory, so well I was using 100 since I prefer that. If 80 is necessary or would make review easier than I can just switch to it. I will remove serdev, pwm, clickID and send a new patch with the minimal driver and better commit messages as suggested with Vaishnav. It is important to have good support for mikroBUS boards without clickID as well. Thanks for all your feedback and time. Ayush Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel