From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: ep93xx: add dma_masks for the M2P and M2M DMA controllers
Date: Mon, 01 Dec 2014 18:58:49 +0100 [thread overview]
Message-ID: <4031997.JKQRhrzkna@wuerfel> (raw)
In-Reply-To: <DC148C5AA1CEBA4E87973D432B1C2D88260702F5@P3PWEX4MB008.ex4.secureserver.net>
On Monday 01 December 2014 17:16:18 Hartley Sweeten wrote:
> On Friday, November 28, 2014 4:36 AM, Arnd Bergmann wrote:
> > On Friday 21 November 2014, H Hartley Sweeten wrote:
> >> The dma_mask and coherent_dma_mask need to be set or DMA memory allocations
> >> will fail with error messages like this:
> >>
> >> ep93xx-dma ep93xx-dma-m2p: coherent DMA mask is unset
> >>
> >> ep93xx-dma ep93xx-dma-m2m: coherent DMA mask is unset
> >>
> >> Add the missing information to the ep93xx-dma-m2p and ep93xx-dma-m2m
> >> devices.
> >>
> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >> Reported-by: Jeremy Moles <cubicool@gmail.com>
> >> Tested-by: Alexander Sverdlin <subaparts@yandex.ru>
> >> Cc: Ryan Mallon <rmallon@gmail.com>
> >
> > Applied to next/fixes-non-critical. I couldn't tell from your description
> > whether you want this on 3.18 or even backported to older releases,
> > which I guess would make sense.
> >
> > If you want a backport, let me know.
>
> Arnd,
>
> I think the ep93xx audio got broken around this commit:
>
> commit e27e8a60cb4ca8e3b047c5d6ee9afff9c4c5b61a
> Author: Lars-Peter Clausen <lars@metafoo.de>
> Date: Sat Apr 20 19:29:05 2013 +0200
>
> ASoC: ep93xx: Use generic dmaengine PCM
>
> But I'm not sure exactly where. I will try to narrow it down.
>
> There appear to be a number of ep93xx users still out there but
> they are mostly still using 2.6 kernels. It might be ok to just get
> this fix in for 3.18 and then wait to see if anyone complains about
> the sound not working in older kernels.
Is there any harm in applying the fix on older kernels? If not, I'd just
mark it as stable for 3.11, which will cause it to get backported to
3.17, 3.14 and 3.12 but not 3.10 or older longerm releases.
Arnd
next prev parent reply other threads:[~2014-12-01 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 17:23 [PATCH] arm: ep93xx: add dma_masks for the M2P and M2M DMA controllers H Hartley Sweeten
2014-11-28 11:35 ` Arnd Bergmann
2014-11-28 22:30 ` Hartley Sweeten
2014-12-01 17:16 ` Hartley Sweeten
2014-12-01 17:58 ` Arnd Bergmann [this message]
2014-12-01 21:14 ` Hartley Sweeten
2014-12-04 16:08 ` Arnd Bergmann
[not found] <1416415519-4903-1-git-send-email-hsweeten@visionengravers.com>
2014-11-19 17:55 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4031997.JKQRhrzkna@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).