From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Allen-KH Cheng <allen-kh.cheng@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
Stephen Boyd <sboyd@kernel.org>, Ikjoon Jang <ikjn@chromium.org>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>
Subject: Re: [PATCH v2 5/6] dt-bindings: arm: mediatek: Add missing power-domains property
Date: Wed, 21 Dec 2022 11:33:06 +0100 [thread overview]
Message-ID: <403b0310-070f-1ecc-2188-95c22859bae1@linaro.org> (raw)
In-Reply-To: <ec927229-cf03-136c-5629-22719110313a@collabora.com>
On 21/12/2022 11:22, AngeloGioacchino Del Regno wrote:
> Il 21/12/22 04:44, Allen-KH Cheng ha scritto:
>> The "mediatek,mt8192-scp_adsp" binding requires a power domain to be
>> specified.
>>
>> Fixes: 4a803990aeb1 ("dt-bindings: ARM: Mediatek: Add new document bindings of MT8192 clock")
>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
>> ---
>> .../arm/mediatek/mediatek,mt8192-clock.yaml | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> index b57cc2e69efb..ce8dd2bfb533 100644
>> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
>> @@ -40,6 +40,9 @@ properties:
>> reg:
>> maxItems: 1
>>
>> + power-domains:
>> + maxItems: 1
>> +
>> '#clock-cells':
>> const: 1
>>
>> @@ -47,13 +50,27 @@ required:
>> - compatible
>> - reg
>>
>> +allOf:
>
> allOf is unnecessary here.
If you mean that "if:" can be without it, then it is better to have
allOf. It grows often, so you avoid useless indentation change later.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-21 10:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 3:44 [PATCH v2 0/6] Add ADSP power domains controller support for MT8192 Allen-KH Cheng
2022-12-21 3:44 ` [PATCH v2 1/6] soc: mediatek: pm-domains: Add buck isolation offset and mask to power domain data Allen-KH Cheng
2022-12-21 10:18 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 2/6] soc: mediatek: pm-domains: Add buck isolation setting in power domain Allen-KH Cheng
2022-12-21 10:20 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 3/6] dt-bindings: power: Add MT8192 ADSP " Allen-KH Cheng
2022-12-21 10:21 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 4/6] soc: mediatek: pm-domains: Add ADSP power domain data for MT8192 Allen-KH Cheng
2022-12-21 10:21 ` AngeloGioacchino Del Regno
2023-02-03 13:07 ` Matthias Brugger
2022-12-21 3:44 ` [PATCH v2 5/6] dt-bindings: arm: mediatek: Add missing power-domains property Allen-KH Cheng
2022-12-21 8:18 ` Krzysztof Kozlowski
2022-12-29 10:15 ` Chen-Yu Tsai
2022-12-21 10:22 ` AngeloGioacchino Del Regno
2022-12-21 10:33 ` Krzysztof Kozlowski [this message]
2022-12-21 10:34 ` AngeloGioacchino Del Regno
2022-12-21 3:44 ` [PATCH v2 6/6] arm64: dts: mediatek: Add the missing ADSP power domains controller for MT8192 Allen-KH Cheng
2022-12-21 10:23 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403b0310-070f-1ecc-2188-95c22859bae1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=ikjn@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox