From: Johan Jonker <jbx6244@gmail.com>
To: wens@kernel.org
Cc: devicetree@vger.kernel.org, heiko@sntech.de, pavel@ucw.cz,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
wens@csie.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
dmurphy@ti.com
Subject: Re: [PATCH v2 1/3] dt-bindings: leds: common: Drop enumeration for linux,default-triggers
Date: Mon, 27 Apr 2020 10:33:27 +0200 [thread overview]
Message-ID: <4044214d-5385-94b6-d985-e1f824a60c5e@gmail.com> (raw)
In-Reply-To: <20200427073132.29997-2-wens@kernel.org>
Hi Chen-Yu,
> From: Chen-Yu Tsai <wens@csie.org>
>
> The bindings currently list a very small subset of valid triggers for
> LEDs. Since many drivers or subsystems in Linux register custom
> triggers, the list would become very hard to maintain.
>
> Instead, just drop the list and allow free form strings.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> .../devicetree/bindings/leds/common.yaml | 21 +------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 4c270fde4567..3b3cdab3fc15 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -79,26 +79,7 @@ properties:
> description:
> This parameter, if present, is a string defining the trigger assigned to
> the LED.
> - allOf:
> - - $ref: /schemas/types.yaml#definitions/string
> - enum:
> - # LED will act as a back-light, controlled by the framebuffer system
> - - backlight
> - # LED will turn on (but for leds-gpio see "default-state" property in
> - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> - - default-on
> - # LED "double" flashes at a load average based rate
> - - heartbeat
> - # LED indicates disk activity
> - - disk-activity
> - # LED indicates IDE disk activity (deprecated), in new implementations
> - # use "disk-activity"
> - - ide-disk
> - # LED flashes at a fixed, configurable rate
> - - timer
> - # LED alters the brightness for the specified duration with one software
> - # timer (requires "led-pattern" property)
> - - pattern
> + $ref: /schemas/types.yaml#definitions/string
This makes it free form, but deletes the documentation of options that
are standard available for people without custom driver.
Where should that info go?
>
> led-pattern:
> description: |
> --
> 2.26.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-27 8:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 7:31 [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
2020-04-27 7:31 ` [PATCH v2 1/3] dt-bindings: leds: common: Drop enumeration for linux, default-triggers Chen-Yu Tsai
2020-04-27 8:33 ` Johan Jonker [this message]
2020-04-27 9:21 ` Chen-Yu Tsai
2020-05-11 23:12 ` [PATCH v2 1/3] dt-bindings: leds: common: Drop enumeration for linux,default-triggers Rob Herring
2020-04-27 7:31 ` [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Chen-Yu Tsai
2020-04-27 8:57 ` Johan Jonker
2020-04-27 9:17 ` Chen-Yu Tsai
2020-04-27 10:08 ` Johan Jonker
2020-04-27 10:33 ` Chen-Yu Tsai
2020-04-27 10:55 ` Johan Jonker
2020-04-27 14:12 ` Johan Jonker
2020-04-27 14:45 ` Chen-Yu Tsai
2020-04-27 15:13 ` Robin Murphy
2020-04-27 7:31 ` [PATCH v2 3/3] arm64: dts: rockchip: rk3328-roc-cc: Set dr_mode to "host" for OTG Chen-Yu Tsai
2020-05-05 6:24 ` [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4044214d-5385-94b6-d985-e1f824a60c5e@gmail.com \
--to=jbx6244@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).