From mboxrd@z Thu Jan 1 00:00:00 1970 From: jianxin.pan@amlogic.com (Jianxin Pan) Date: Wed, 24 Oct 2018 16:51:27 +0800 Subject: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver In-Reply-To: <154037087711.53599.12246779227164118041@swboyd.mtv.corp.google.com> References: <1539839245-13793-1-git-send-email-jianxin.pan@amlogic.com> <1539839245-13793-4-git-send-email-jianxin.pan@amlogic.com> <153988282130.5275.17528969137837015544@swboyd.mtv.corp.google.com> <154037087711.53599.12246779227164118041@swboyd.mtv.corp.google.com> Message-ID: <40509901-a793-971d-eb2e-40230b67f490@amlogic.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2018/10/24 16:47, Stephen Boyd wrote: > Quoting Jianxin Pan (2018-10-23 23:29:24) >> On 2018/10/19 1:13, Stephen Boyd wrote: >>> Quoting Jianxin Pan (2018-10-17 22:07:25) >> [...] >>>> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c >>>> new file mode 100644 >>>> index 0000000..5555e3f >>>> --- /dev/null >>>> +++ b/drivers/clk/meson/mmc-clkc.c >>>> @@ -0,0 +1,296 @@ >>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>> +/* >>>> + * Amlogic Meson MMC Sub Clock Controller Driver >>>> + * >>>> + * Copyright (c) 2017 Baylibre SAS. >>>> + * Author: Jerome Brunet >>>> + * >>>> + * Copyright (c) 2018 Amlogic, inc. >>>> + * Author: Yixun Lan >>>> + */ >>>> + >>>> +#include >>> >>> clk-provider.h instead of clk.h?> >> Maybe we need to keep clk.h >> devm_clk_get() is called in mmc_clkc_register_mux() to get parent in from DTS. >> I'm sorry to miss this in previous reply. > > OK. But also include clk-provider.h if provider APIs are being used > here. OK. I will add it. Thank you. > > . >