From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526FFC433DF for ; Wed, 8 Jul 2020 16:19:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 196C820786 for ; Wed, 8 Jul 2020 16:19:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kHiNah14" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 196C820786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JYfnsUtljTAEK5HY1opc49t5GyDOM02s1HWOI4yGGlw=; b=kHiNah140pjr+ungU7FWzOJ9t qXj4G5vThI2QqmHYk6O9FoBTrA0xRskTPvKjbH714Dwan5P+fgB3RIab90GR+bZyDEBpaUpD53oVj UEv+M5Ya3TJ2R/euoev1bWuaYmUMaqaZCqTGsiqmUrBy/B/PvvGC5AH42v6L6Vj3aKvxzfh9t1/HD nldR740qQvUtQQU5iDEBVmmGWXaNOBIgjSmqdfKEYBHap4ZEk2W772zQ6eaWwmKAbCzXaU7K1x9UE pDRMbfXs85Wpnp1qNLAS1Iq0anR7HBBhT6XD5nRji1sWNPnOsYwhe0QSVXMmV8ARdHfilujfHrAy4 iJHVahl9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtCln-0000mP-BR; Wed, 08 Jul 2020 16:18:03 +0000 Received: from mailoutvs48.siol.net ([185.57.226.239] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtClk-0000kk-F1 for linux-arm-kernel@lists.infradead.org; Wed, 08 Jul 2020 16:18:01 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 4A96C524C57; Wed, 8 Jul 2020 18:17:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id oLEpCQVAM4I0; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id D452E524C76; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-194-152-20-232.static.triera.net [194.152.20.232]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 47E03524BD7; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= , Maxime Ripard Subject: Re: [PATCH 08/16] arm64: dts: allwinner: h6: Add HDMI audio node Date: Wed, 08 Jul 2020 18:17:57 +0200 Message-ID: <4073007.RJdR9ZcIkj@jernej-laptop> In-Reply-To: <20200706052937.ygjjllrsj7rvynkq@gilmour.lan> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-9-peron.clem@gmail.com> <20200706052937.ygjjllrsj7rvynkq@gilmour.lan> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200708_121800_651959_F70FF3FE X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-sunxi@googlegroups.com, Takashi Iwai , Jaroslav Kysela , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi! Dne ponedeljek, 06. julij 2020 ob 07:29:37 CEST je Maxime Ripard napisal(a): > Hi, > = > On Sat, Jul 04, 2020 at 01:38:54PM +0200, Cl=E9ment P=E9ron wrote: > > From: Jernej Skrabec > > = > > Add a simple-soundcard to link audio between HDMI and I2S. > > = > > Signed-off-by: Jernej Skrabec > > Signed-off-by: Marcus Cooper > > Signed-off-by: Cl=E9ment P=E9ron > > --- > > = > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > 78b1361dfbb9..ae169d07b939 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -67,6 +67,25 @@ de: display-engine { > > = > > status =3D "disabled"; > > = > > }; > > = > > + hdmi_sound: hdmi-sound { > > + compatible =3D "simple-audio-card"; > > + simple-audio-card,format =3D "i2s"; > > + simple-audio-card,name =3D "sun50i-h6-hdmi"; > > + simple-audio-card,mclk-fs =3D <128>; > > + simple-audio-card,frame-inversion; > = > Have you figured that one out? > = > > + status =3D "disabled"; > > + > > + simple-audio-card,codec { > > + sound-dai =3D <&hdmi>; > > + }; > > + > > + simple-audio-card,cpu { > > + sound-dai =3D <&i2s1>; > > + dai-tdm-slot-num =3D <2>; > > + dai-tdm-slot-width =3D <32>; > = > I'm not sure why you need to use the TDM stuff here. IIRC the HDMI > controller can output on up to 6 channels, so how would that work out? dai-tdm-slot-width is needed to override automatic slot width selection. It = should always be 32 for HDMI, no matter what is actual physical sample widt= h. = In this case this property is abused to set width also for I2S mode of = operation. IMO there is no sense to duplicate code because I2S variant woul= d = work exactly the same, except name would be different. I'm not sure about dai-tdm-slot-num. Marcus, can you explain the need for t= his = property? Would it be better to implement separate link driver instead of using simpl= e- card to hide all this properties into the code? Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel