From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver
Date: Wed, 20 Nov 2013 13:06:56 +0100 [thread overview]
Message-ID: <40736575.jvgUcOHqUx@wuerfel> (raw)
In-Reply-To: <20131120113704.GT5914@e106331-lin.cambridge.arm.com>
On Wednesday 20 November 2013 11:37:05 Mark Rutland wrote:
> > +static void phy_rd(void *addr, u32 *val)
> > +{
> > + *val = readl(addr);
> > +#if defined(XGENE_DBG1_CSR)
> > + pr_debug("SATAPHY CSR RD: 0x%p value: 0x%08x\n", addr, *val);
>
> Can you not use dev_dbg here as you do elsehere?
>
> Either that or make your own debug print function, with the ifdefs
> hidden in its definition.
>
pr_debug() is already conditional on #ifdef DEBUG, the extra #if
can just get removed here.
Arnd
next prev parent reply other threads:[~2013-11-20 12:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 23:53 [PATCH v2 0/4] ata: Add APM X-Gene SoC 6.0Gbps SATA PHY support Loc Ho
2013-11-19 23:53 ` [PATCH v2 1/4] PHY: Add function set_speed to generic PHY framework Loc Ho
2013-11-19 23:53 ` [PATCH v2 2/4] Documentation: Add APM X-Gene SoC 6.0Gbps SATA PHY driver binding documentation Loc Ho
2013-11-19 23:53 ` [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver Loc Ho
2013-11-19 23:53 ` [PATCH v2 4/4] arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries Loc Ho
2013-11-20 0:08 ` Loc Ho
2013-11-20 11:39 ` Mark Rutland
2013-11-20 18:03 ` Sergei Shtylyov
2013-11-20 18:48 ` Arnd Bergmann
2013-11-20 8:57 ` [PATCH v2 3/4] ata: add APM X-Gene SoC 6.0Gbps SATA PHY driver Ming Lei
2013-11-20 19:16 ` Loc Ho
2013-11-20 11:37 ` Mark Rutland
2013-11-20 12:06 ` Arnd Bergmann [this message]
2013-11-20 15:06 ` Tejun Heo
2013-11-20 15:41 ` Arnd Bergmann
2013-11-20 15:49 ` Tejun Heo
2013-11-20 18:46 ` Arnd Bergmann
2013-11-20 22:23 ` Loc Ho
2013-11-20 9:43 ` [PATCH v2 2/4] Documentation: Add APM X-Gene SoC 6.0Gbps SATA PHY driver binding documentation Mark Rutland
2013-11-20 20:07 ` Loc Ho
2013-11-22 9:37 ` Mark Rutland
2013-11-20 18:06 ` [PATCH v2 1/4] PHY: Add function set_speed to generic PHY framework Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40736575.jvgUcOHqUx@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox