* [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
@ 2013-11-13 23:39 Magnus Damm
2013-11-13 23:57 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2013-11-13 23:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Add a total of 13 GPIO DT device nodes for r7s72100.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/r7s72100.dtsi | 131 +++++++++++++++++++++++++++++++++++++++
1 file changed, 131 insertions(+)
--- 0001/arch/arm/boot/dts/r7s72100.dtsi
+++ work/arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000 +0900
@@ -14,6 +14,22 @@
#address-cells = <1>;
#size-cells = <1>;
+ aliases {
+ gpio0 = &p0;
+ gpio1 = &p1;
+ gpio2 = &p2;
+ gpio3 = &p3;
+ gpio4 = &p4;
+ gpio5 = &p5;
+ gpio6 = &p6;
+ gpio7 = &p7;
+ gpio8 = &p8;
+ gpio9 = &p9;
+ gpio10 = &p10;
+ gpio11 = &p11;
+ gpio12 = &jp0;
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
@@ -33,4 +49,119 @@
reg = <0xe8201000 0x1000>,
<0xe8202000 0x1000>;
};
+
+ p0: gpio at fcfe3100 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3100 0x4>, /* PSR */
+ <0xfcfe3200 0x2>, /* PPR */
+ <0xfcfe3800 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p1: gpio at fcfe3104 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3104 0x4>, /* PSR */
+ <0xfcfe3204 0x2>, /* PPR */
+ <0xfcfe3804 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p2: gpio at fcfe3108 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3108 0x4>, /* PSR */
+ <0xfcfe3208 0x2>, /* PPR */
+ <0xfcfe3808 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p3: gpio at fcfe310c {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe310c 0x4>, /* PSR */
+ <0xfcfe320c 0x2>, /* PPR */
+ <0xfcfe380c 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p4: gpio at fcfe3110 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3110 0x4>, /* PSR */
+ <0xfcfe3210 0x2>, /* PPR */
+ <0xfcfe3810 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p5: gpio at fcfe3114 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3114 0x4>, /* PSR */
+ <0xfcfe3214 0x2>, /* PPR */
+ <0xfcfe3814 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p6: gpio at fcfe3118 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3118 0x4>, /* PSR */
+ <0xfcfe3218 0x2>, /* PPR */
+ <0xfcfe3818 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p7: gpio at fcfe311c {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe311c 0x4>, /* PSR */
+ <0xfcfe321c 0x2>, /* PPR */
+ <0xfcfe381c 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p8: gpio at fcfe3120 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3120 0x4>, /* PSR */
+ <0xfcfe3220 0x2>, /* PPR */
+ <0xfcfe3820 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p9: gpio at fcfe3124 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3124 0x4>, /* PSR */
+ <0xfcfe3224 0x2>, /* PPR */
+ <0xfcfe3824 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p10: gpio at fcfe3128 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe3128 0x4>, /* PSR */
+ <0xfcfe3228 0x2>, /* PPR */
+ <0xfcfe3828 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ p11: gpio at fcfe312c {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe312c 0x4>, /* PSR */
+ <0xfcfe322c 0x2>, /* PPR */
+ <0xfcfe382c 0x4>; /* PMSR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+
+ jp0: gpio at fcfe7b20 {
+ compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
+ reg = <0xfcfe7b20 0x2>; /* JPPR */
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
};
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
2013-11-13 23:39 [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ Magnus Damm
@ 2013-11-13 23:57 ` Laurent Pinchart
2013-11-14 8:39 ` Magnus Damm
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2013-11-13 23:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi Magnus,
Thank you for the patch.
On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Add a total of 13 GPIO DT device nodes for r7s72100.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/boot/dts/r7s72100.dtsi | 131 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 131 insertions(+)
>
> --- 0001/arch/arm/boot/dts/r7s72100.dtsi
> +++ work/arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000
+0900
> @@ -14,6 +14,22 @@
> #address-cells = <1>;
> #size-cells = <1>;
>
> + aliases {
> + gpio0 = &p0;
> + gpio1 = &p1;
> + gpio2 = &p2;
> + gpio3 = &p3;
> + gpio4 = &p4;
> + gpio5 = &p5;
> + gpio6 = &p6;
> + gpio7 = &p7;
> + gpio8 = &p8;
> + gpio9 = &p9;
> + gpio10 = &p10;
> + gpio11 = &p11;
I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter names
may clash with something else later.
> + gpio12 = &jp0;
What is this special GPIO controller instance ?
> + };
> +
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -33,4 +49,119 @@
> reg = <0xe8201000 0x1000>,
> <0xe8202000 0x1000>;
> };
> +
> + p0: gpio at fcfe3100 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3100 0x4>, /* PSR */
> + <0xfcfe3200 0x2>, /* PPR */
> + <0xfcfe3800 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p1: gpio at fcfe3104 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3104 0x4>, /* PSR */
> + <0xfcfe3204 0x2>, /* PPR */
> + <0xfcfe3804 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p2: gpio at fcfe3108 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3108 0x4>, /* PSR */
> + <0xfcfe3208 0x2>, /* PPR */
> + <0xfcfe3808 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p3: gpio at fcfe310c {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe310c 0x4>, /* PSR */
> + <0xfcfe320c 0x2>, /* PPR */
> + <0xfcfe380c 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p4: gpio at fcfe3110 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3110 0x4>, /* PSR */
> + <0xfcfe3210 0x2>, /* PPR */
> + <0xfcfe3810 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p5: gpio at fcfe3114 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3114 0x4>, /* PSR */
> + <0xfcfe3214 0x2>, /* PPR */
> + <0xfcfe3814 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p6: gpio at fcfe3118 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3118 0x4>, /* PSR */
> + <0xfcfe3218 0x2>, /* PPR */
> + <0xfcfe3818 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p7: gpio at fcfe311c {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe311c 0x4>, /* PSR */
> + <0xfcfe321c 0x2>, /* PPR */
> + <0xfcfe381c 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p8: gpio at fcfe3120 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3120 0x4>, /* PSR */
> + <0xfcfe3220 0x2>, /* PPR */
> + <0xfcfe3820 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p9: gpio at fcfe3124 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3124 0x4>, /* PSR */
> + <0xfcfe3224 0x2>, /* PPR */
> + <0xfcfe3824 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p10: gpio at fcfe3128 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe3128 0x4>, /* PSR */
> + <0xfcfe3228 0x2>, /* PPR */
> + <0xfcfe3828 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + p11: gpio at fcfe312c {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe312c 0x4>, /* PSR */
> + <0xfcfe322c 0x2>, /* PPR */
> + <0xfcfe382c 0x4>; /* PMSR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +
> + jp0: gpio at fcfe7b20 {
> + compatible = "renesas,gpio-r7s72100", "renesas,gpio-rz";
> + reg = <0xfcfe7b20 0x2>; /* JPPR */
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
2013-11-13 23:57 ` Laurent Pinchart
@ 2013-11-14 8:39 ` Magnus Damm
2013-11-14 13:22 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2013-11-14 8:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Laurent,
On Thu, Nov 14, 2013 at 8:57 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Magnus,
>
> Thank you for the patch.
>
> On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Add a total of 13 GPIO DT device nodes for r7s72100.
>>
>> Signed-off-by: Magnus Damm <damm@opensource.se>
>> ---
>>
>> arch/arm/boot/dts/r7s72100.dtsi | 131 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 131 insertions(+)
>>
>> --- 0001/arch/arm/boot/dts/r7s72100.dtsi
>> +++ work/arch/arm/boot/dts/r7s72100.dtsi 2013-11-13 22:33:56.000000000
> +0900
>> @@ -14,6 +14,22 @@
>> #address-cells = <1>;
>> #size-cells = <1>;
>>
>> + aliases {
>> + gpio0 = &p0;
>> + gpio1 = &p1;
>> + gpio2 = &p2;
>> + gpio3 = &p3;
>> + gpio4 = &p4;
>> + gpio5 = &p5;
>> + gpio6 = &p6;
>> + gpio7 = &p7;
>> + gpio8 = &p8;
>> + gpio9 = &p9;
>> + gpio10 = &p10;
>> + gpio11 = &p11;
>
> I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter names
> may clash with something else later.
I see. In this case the p0-p11 names match with the datasheet. Would
you prefer "port0" to match "Port 0" in the data sheet instead?
>> + gpio12 = &jp0;
>
> What is this special GPIO controller instance ?
It is called "jp0" or "JTAG Port 0" in the data sheet. It's a
read-only port for some pins associated with the JTAG connector.
Of course, it is possible to use gpio0 -> gpio12 but that is IMO more
difficult to use since those won't match with the data sheet or
schematics.
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ
2013-11-14 8:39 ` Magnus Damm
@ 2013-11-14 13:22 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-11-14 13:22 UTC (permalink / raw)
To: linux-arm-kernel
Hi Magnus,
On Thursday 14 November 2013 17:39:08 Magnus Damm wrote:
> On Thu, Nov 14, 2013 at 8:57 AM, Laurent Pinchart wrote:
> > On Thursday 14 November 2013 08:39:27 Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Add a total of 13 GPIO DT device nodes for r7s72100.
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> arch/arm/boot/dts/r7s72100.dtsi | 131 +++++++++++++++++++++++++++++++++
> >> 1 file changed, 131 insertions(+)
> >>
> >> --- 0001/arch/arm/boot/dts/r7s72100.dtsi
> >> +++ work/arch/arm/boot/dts/r7s72100.dtsi 2013-11-13
> >> 22:33:56.000000000 +0900
> >> @@ -14,6 +14,22 @@
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >>
> >> + aliases {
> >> + gpio0 = &p0;
> >> + gpio1 = &p1;
> >> + gpio2 = &p2;
> >> + gpio3 = &p3;
> >> + gpio4 = &p4;
> >> + gpio5 = &p5;
> >> + gpio6 = &p6;
> >> + gpio7 = &p7;
> >> + gpio8 = &p8;
> >> + gpio9 = &p9;
> >> + gpio10 = &p10;
> >> + gpio11 = &p11;
> >
> > I would have called the phandles gpio[0-9]* instead of p[0-9]*. Shorter
> > names may clash with something else later.
>
> I see. In this case the p0-p11 names match with the datasheet. Would
> you prefer "port0" to match "Port 0" in the data sheet instead?
>
> >> + gpio12 = &jp0;
> >
> > What is this special GPIO controller instance ?
>
> It is called "jp0" or "JTAG Port 0" in the data sheet. It's a
> read-only port for some pins associated with the JTAG connector.
>
> Of course, it is possible to use gpio0 -> gpio12 but that is IMO more
> difficult to use since those won't match with the data sheet or
> schematics.
Would port0 -> port 11 and jtag-port be fine ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-14 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-13 23:39 [PATCH] ARM: shmobile: r7s72100 GPIO DT nodes for GPIO RZ Magnus Damm
2013-11-13 23:57 ` Laurent Pinchart
2013-11-14 8:39 ` Magnus Damm
2013-11-14 13:22 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).