From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37026C4363D for ; Wed, 23 Sep 2020 07:40:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E18B214D8 for ; Wed, 23 Sep 2020 07:40:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZPUJxyTb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E18B214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gmuzb/FSDutlMwnrl6kHskE4uud9E9RNhcf8sy0JdU4=; b=ZPUJxyTbpAdXZ9QzS4QmqNiWJ KnjSzR8R92SMmDw2vxKkfTTyKeVaTFePQfp1Dmnv61wfiUx0LGR9MMEDNdQpxSGVfuElkLqjSZWPJ V7aCWciwpw22ItS7HqGQ7Y306BEu2wvgPQT7SKpYgyGWSHWrcAbQApu7tGcJ8fZuq75Ko7+oFwAAE 0JAvRgMjVqd0ZxBZCuEtjwiMyKWngAIdsCqpEvT5yybKsw7YLyHgiHdojVzLQjIzI+jPSkZiAq5ch JNbWybSgeOW2IY+ld4QbKnHmHDD5lNH9H8zYeCDMkJPohHN3At56+KNs1wY6WUAwozkO5UnywYb+6 4VHA2SePA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKzMF-0007ff-UR; Wed, 23 Sep 2020 07:38:32 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKzMD-0007fH-BU; Wed, 23 Sep 2020 07:38:30 +0000 Received: from ip5f5aa64a.dynamic.kabel-deutschland.de ([95.90.166.74] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kKzM1-0005G0-UU; Wed, 23 Sep 2020 09:38:17 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: David Airlie , Daniel Vetter , Jian-Hong Pan Subject: Re: [PATCH] drm/rockchip: skip probed failed device Date: Wed, 23 Sep 2020 09:38:17 +0200 Message-ID: <4075212.IPEHUSCvie@diego> In-Reply-To: <20200923065900.658666-1-jhp@endlessos.org> References: <20200923065900.658666-1-jhp@endlessos.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_033829_405021_3E96EC5D X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jian-Hong Pan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux@endlessm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 23. September 2020, 08:59:00 CEST schrieb Jian-Hong Pan: > The cdn-dp sub driver probes the device failed on PINEBOOK Pro. > > kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy > kernel: cdn-dp: probe of fec00000.dp failed with error -22 > > Then, the device halts all of the DRM related device jobs. For example, > the operations: vop_component_ops, vop_component_ops and > rockchip_dp_component_ops cannot be bound to corresponding devices. So, > Xorg cannot find the correct DRM device. > > This patch skips the probing failed devices to fix this issue. > > Link: http://lists.infradead.org/pipermail/linux-rockchip/2020-September/022352.html > Signed-off-by: Jian-Hong Pan > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index 0f3eb392fe39..de13588602b4 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -331,6 +331,12 @@ static struct component_match *rockchip_drm_match_add(struct device *dev) > > if (!d) > break; > + if (!d->driver) { > + DRM_DEV_ERROR(d, > + "%s did not probe successfully", > + drv->driver.name); > + continue; > + } How does this relate to drivers doing EPROBE_DEFER? Very often you have sub-drivers defering probe as they still need another resource, so excluding them in that case would not work? Heiko > > device_link_add(dev, d, DL_FLAG_STATELESS); > component_match_add(dev, &match, compare_dev, d); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel