From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A57AC433EF for ; Mon, 13 Jun 2022 10:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R6MHzH93jQzYApVSxMx4a6q3vA6p3FYZrXFjL4xuNv4=; b=kjfA3vBZvgNRav V69JuEORkoQcTlr7o0bOOzmzluUIm9T/byQ+ugP4/KyojOlGiTGFlL18tcDyOHpB1mmx3meuJwAO8 Cg6IXaXErp922Wlt8TILuwcy6e1wkjYD9505oFBFC+D6j+Ixad6vw0BOFwWDuJ5NLOkKaU7GDyeRB yFHj+DAM9h/DfRXucL8s9WQKlUuMG1Ic92cwa4q6Y7eitrfaw11LTb5+CRBd749OESA7/J6vOqXDq tMZce1kN5t1jcwpGktoZS+EhwqN2/90/m3lpD4pwO/Sttml/uDIQb+C+e6CFoQGukevqabne0IvXG HGfkX6L//gxRotxxNLdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0hIQ-002tiz-UF; Mon, 13 Jun 2022 10:27:47 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0hIN-002ti3-Lu for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 10:27:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655116063; x=1686652063; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cJw4UTUEc+RWc+ehCramYX9/m6K3edEpj+3lirTKgJs=; b=fiSzytvUVUTh8fW61PotVsSua8QiZ8f0FGV39ZJj9GTfqlz5gjFyQGqk h9O3vehUEvpGR2UnBCZMsLQKvQRIKDPru5XSDNNy85U9uU8pcJBRPOQNP Xfo+YUpzu9v1Xc0SR43UqVioYxrEyZRTdTTzwKhdbjf9xCOpVVLDfOuH+ tCsh5GQUfAympCvefzYSZtDYhJXQemoq+rCJLid2oLZQer+C253HK4i3h s8QHIvIjiWPgLTYsKkLfTYH6PpyJbE2L4/bquuRP6IDOCrw+jwlJ2K1WE Xab5EYgZeYGdCb/cbOvXFS276LDA5CmaI0ZfOLkt24IJOoB6UZAX3EV11 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="258681310" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="258681310" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 03:27:42 -0700 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="639662230" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.252.58.193]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 03:27:38 -0700 Message-ID: <40b8507e-1da3-7ab8-cd11-e0d692e08352@intel.com> Date: Mon, 13 Jun 2022 13:27:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH] mmc: sdhci-brcmstb: Initialize base_clk to NULL in sdhci_brcmstb_probe() Content-Language: en-US To: Nathan Chancellor , Al Cooper , Ulf Hansson , Kamal Dasu , Florian Fainelli Cc: bcm-kernel-feedback-list@broadcom.com, Nick Desaulniers , Tom Rix , Justin Stitt , Dan Carpenter , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev, patches@lists.linux.dev, kernel test robot References: <20220608152757.82529-1-nathan@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: <20220608152757.82529-1-nathan@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_032743_781000_193CC2C4 X-CRM114-Status: GOOD ( 18.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/06/22 18:27, Nathan Chancellor wrote: > Clang warns a few times along the lines of: > > drivers/mmc/host/sdhci-brcmstb.c:302:6: warning: variable 'base_clk' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if (res) > ^~~ > drivers/mmc/host/sdhci-brcmstb.c:376:24: note: uninitialized use occurs here > clk_disable_unprepare(base_clk); > ^~~~~~~~ > > base_clk is used in the error path before it is initialized. Initialize > it to NULL, as clk_disable_unprepare() calls clk_disable() and > clk_unprepare(), which both handle NULL pointers gracefully. > > Fixes: 2cecaac1b21c ("mmc: sdhci-brcmstb: Add ability to increase max clock rate for 72116b0") > Link: https://github.com/ClangBuiltLinux/linux/issues/1650 > Reported-by: kernel test robot > Signed-off-by: Nathan Chancellor Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-brcmstb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c > index f8dff8537920..28e9cf995c41 100644 > --- a/drivers/mmc/host/sdhci-brcmstb.c > +++ b/drivers/mmc/host/sdhci-brcmstb.c > @@ -256,7 +256,7 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev) > struct sdhci_host *host; > struct resource *iomem; > struct clk *clk; > - struct clk *base_clk; > + struct clk *base_clk = NULL; > int res; > > match = of_match_node(sdhci_brcm_of_match, pdev->dev.of_node); > > base-commit: 10980053142d8a3e86eb4d3014574424b42b7a45 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel