From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C246EC00140 for ; Wed, 10 Aug 2022 15:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+jc2b1N9m90LXfyoYeiLwuWQWIEPUQyHmzy8z1ITis0=; b=fUZn8qh8AqlZOs KyjzCUKmhBbNDJen3q08uyV+LB5xbQk7kE4RC/npqOf4DwTV8RcqfqFwpEVQ/FgLQhayBcaA78PsI luIphXg/w2clyZTuUQJU/DY13b2xlCAUopJ26ZZRlRaTIEch9ElYticWIsXT8GcJNTTpZFHnzHgye 1rBLGXMFmJeagRtBkQ3fGy8AQ/racB5QfI35Aj5QC8DpFokEXeCMBuYjP7oST3ZrqXuU/E0q/xeAc d4fZPBfUeUnHMrWsEUGl4IWG8mixJJa2FStwtDcu7tnrr+0lZuRmM0AvPDAELYexpwMBaari/Rq7X gOELuJbG1kQtL35bbffw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLnuL-00Ce7i-Mx; Wed, 10 Aug 2022 15:46:09 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLnuI-00Ce5l-D2 for linux-arm-kernel@lists.infradead.org; Wed, 10 Aug 2022 15:46:07 +0000 Received: by mail-lj1-x22e.google.com with SMTP id j3so9336155ljo.0 for ; Wed, 10 Aug 2022 08:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=DCCjTYZ0qN8vBfPF1lwOb8EOTQj5fWe2+onwYOWjKsw=; b=BNTZtwqIPvOw5SsHSMFNsnlLhZ49JLS1j+DZDiuYlnDZ4zNxuI5qux+fn/wm783Joc m6fdIrPnJBco0EhE1TvkXC2uVOudAz3Qz/+T3W1v+Yp8bZusjPHFYuApNfGqg6O3qmc0 WkON1bYYV/3nx+l+jMkK1p+md86rty447/XrPh0CTuY+w4B9rhsQrMTykBrdYVrGUbx7 1UBt4hs/6oyTNMhruBx6y8EOsRVrRz3HCjg30qUOe9nD2fQcL/FRyIOZ6TBMTFTIFlXS vu2cBYpoly76o4eS85rLv0rQZ/eLprt9bxMplRMq+m/6klWJzinblrjV7uaOH0SvHamZ ANsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=DCCjTYZ0qN8vBfPF1lwOb8EOTQj5fWe2+onwYOWjKsw=; b=MvgptcjATYW6zr+sB3Sx5VTgu8xc4KKCskQHrEVZqK5q07hhlAVm9B4S+fEIA6EA6M AsBkI3j+XF7o4JnQ14htQkTTKd0YF7bnsQLoUbEpi9hdJjQUU69t2iSHReZjlqMyqHoz Zdi2JXQOd/Rpppjexc4nsmYpkCzNaO+d7smOZMrBgoJZgZS11otYfcgsHkVjUVzBgDUE V0IKFjkwAJs4hrUIfGboljVqQy/3tLMxwPzAhdKHYy0nlzZ1GNYvLJSET5d+TjyyxwGM sq5Tl+jKb2NG3+BkL0npPxKDEUTKrflKkL9epjfnvhNqFoNfD9RUPIqUXYbgjtTdAsAC 9sGw== X-Gm-Message-State: ACgBeo3i/861wv/Iu7+LI16NZOBy+gzHsErn2qaSmx6WU2Kg+COlA8Us QmWC+uBsALRx4qc0Kjo8sMi3Mw== X-Google-Smtp-Source: AA6agR5sH0ECkekUtJa3azyuIaHtiF8N4pVi6n1YrHGKr9bBBmKnyPTJAXXs3TI9F7mXBtYTGiz2rA== X-Received: by 2002:a2e:9e17:0:b0:25d:8897:2a77 with SMTP id e23-20020a2e9e17000000b0025d88972a77mr8720646ljk.441.1660146362059; Wed, 10 Aug 2022 08:46:02 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id w4-20020a19c504000000b0048af6242892sm388217lfe.14.2022.08.10.08.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 08:46:01 -0700 (PDT) Message-ID: <40ca4f73-aed5-3e2a-7fb6-cd3a2cb74cb9@linaro.org> Date: Wed, 10 Aug 2022 18:45:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings Content-Language: en-US To: Shenwei Wang , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "imx@lists.linux.dev" References: <20220810133005.74653-1-shenwei.wang@nxp.com> <20220810133005.74653-2-shenwei.wang@nxp.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220810_084606_488710_294CD1FA X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/08/2022 18:23, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Wednesday, August 10, 2022 9:46 AM >> To: Shenwei Wang ; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org; linus.walleij@linaro.org; brgl@bgdev.pl; >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; >> festevam@gmail.com; dl-linux-imx >> Cc: devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux- >> gpio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev >> Subject: [EXT] Re: [PATCH v3 1/3] dt-bindings: gpio: Add imx scu gpio driver >> bindings >> >> Caution: EXT Email >> >> On 10/08/2022 16:30, Shenwei Wang wrote: >>> Add binding document for the imx scu gpio driver. >>> >>> Signed-off-by: Shenwei Wang >>> --- >>> .../bindings/gpio/fsl,imx-sc-gpio.yaml | 40 +++++++++++++++++++ >>> +properties: >>> + compatible: >>> + enum: >>> + - fsl,imx8qxp-sc-gpio >>> + - fsl,imx-scu-gpio >> >> >> This is too generic compatible and it even conflicts with the above... >> Your driver binds to both without driver data which is even more confusing. >> Make the compatible specific for one, given SoC. >> > > Oh, that's my bad. It is a typo. The generic compatible should be "fsl,imx-sc-gpio". > So far there is no driver data required for both imx8qxp and imx8dxl, but it might be > required sometimes later in case the scu firmware is customized for a specified use case. > That's why I put the generic one here. That's not a proper reason to add generic one. Either all implementations are compatible or not. If you are unsure, this should be assumed as not and just use specific compatible. If you are 100% sure, then use fallback, not two compatibles, and properly justify it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel