From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99446CCD193 for ; Thu, 23 Oct 2025 07:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SF5pybulDBHW18c8HlGOwb18Vw0zJMzWb3/sOP7yWg4=; b=EgTzNYd/h8pIkdCgM6NWZX6e/s lUmh2mjWSp+Oz2j+JgRk2K5NsmLKuVv0GIEton6x+AzJ62M139q7Whzit4KebbeujcnlwZSeQ4DdX 97lp+hnC8c9fWjQaCWl7qTFUiWXgpSTU3PqiprsJ48pWjIys5VBzGc5ehZXGg1beNmE+UaJTcQlvv GFdr46qHqKc3UKMkvtB2Ica0NPvu9gOyvtN93f+ocOqfR4bGsEl+lTCufYc0YleFY72VVnSJbdc8L Me6gVhYlsk6BagJzO4md2VsDpL6XxDGjuA1oLmQwt02YxCutSYJrQFu6TxAjNtKiDWOzkEA6A6Hp/ MgnfUBaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBpbg-00000005KZ4-3MjK; Thu, 23 Oct 2025 07:19:32 +0000 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBpbe-00000005KXf-2hfb; Thu, 23 Oct 2025 07:19:31 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1761203954; cv=none; d=zohomail.com; s=zohoarc; b=bsCzS5MDHjxtBJy/3QQFflmrjRjP7+ij7mjvcpmJiVSO9IBjSQQM5C+NSbK6yoChcyE93a8+bTAr7+kIVJWRULaFPG11IwMZ3WWzoX6SRUIHDMxK/i5cFrX6ehbezhmHibQdMECFR8H03JqtHlDHDKEbPztexGSzIGjf9oMA6nk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761203954; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=SF5pybulDBHW18c8HlGOwb18Vw0zJMzWb3/sOP7yWg4=; b=K6gwCYSwTLEtYSOy4h2jFuHn+3XWcEyPbxPsb1wQlGLIbF5+/BgBuUMey41TiyBaXduGmi2nM8ks69qEK9ix1B5w2w2e+J3ILdm6WHoGf1PwON8jxd0fd0li8TCyDuIHDPiA8DlhlFW1pUeFUSkTQoNXINUVDOKyCp2tTWEgHdw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1761203954; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=SF5pybulDBHW18c8HlGOwb18Vw0zJMzWb3/sOP7yWg4=; b=iKy0yYd5IOtoKBRwSPCKhVi9FFId6Ye3aOop8qPa2+O2cHYN3UWhjtdHh4X1+yjG Q0AJNOmzRt4ophYTGgJDDO6C9IjCLulhIKjVwwj6tAxj0imhEVNGEc4Noq3KBRtoIqL 2Kp8ddw0qOQjca+mU5BsgLOAxGQn4mdxpS/Qhj0s= Received: by mx.zohomail.com with SMTPS id 1761203953036917.0062959568356; Thu, 23 Oct 2025 00:19:13 -0700 (PDT) Message-ID: <40d18130-4aab-47ad-9ed4-00ff6f594cc3@collabora.com> Date: Thu, 23 Oct 2025 10:19:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] drm/rockchip: Set VOP for the DRM DMA device To: Heiko Stuebner , Sandy Huang , Andy Yan , Robin Murphy , Sebastian Reichel , Daniel Stone Cc: kernel@collabora.com, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20251022161948.199731-1-dmitry.osipenko@collabora.com> <3705026.LM0AJKV5NW@phil> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: <3705026.LM0AJKV5NW@phil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251023_001930_724196_1FB5C87D X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/23/25 09:56, Heiko Stuebner wrote: > Hi Dmitry, > > Am Mittwoch, 22. Oktober 2025, 18:19:48 Mitteleuropäische Sommerzeit schrieb Dmitry Osipenko: >> Use VOP for DMA operations performed by DRM core. Rockchip DRM driver >> is backed by a virtual device that isn't IOMMU-capable, while VOP is the >> actual display controller device backed by IOMMU. Fixes "swiotlb buffer >> is full" warning messages originated from GEM prime code paths. >> >> Note, that backporting is non-trivial as this depends on 143ec8d3f9396 >> ("drm/prime: Support dedicated DMA device for dma-buf imports"), which >> landed in v6.16 and 421be3ee36a4 ("drm/rockchip: Refactor IOMMU >> initialisation"), which landed in v5.19. >> >> Reported-by: Daniel Stone >> Fixes: 2048e3286f34 ("drm: rockchip: Add basic drm driver") >> Cc: stable@vger.kernel.org # v6.16+ >> Reviewed-by: Sebastian Reichel >> Signed-off-by: Dmitry Osipenko > > just a process remark for now. This v1 so it definitly shouldn't come > with any Reviewed-by-s pre-applied, because this should happen in public. > > It's not a huge issue here, because I do trust the people involved (you, > Sebastian, Daniel) and the change is small enough, but please for future > changes, let Review happen on the list, not on private channels. > > > Will look at the change itself when back home. Thanks. I also felt uncomfortable adding r-b to v1. There was no much discussion on the change that you can find on [1] and the change is indeed small, so I just added the r-b. Should've linked it the patch. [1] https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/issues/50 -- Best regards, Dmitry