From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A231C433EF for ; Tue, 1 Mar 2022 08:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GCWEsi5vJZtBF+dd+fcbhWOEH/K79FsR5seahAdoD8w=; b=fvAUs/p8nPIVHJ NDSpnfnN7t7ikHk1kfJazTUk28KBAZ18/n6KmGRB4qJZ5ei2XNEPfBtReMaazG8C80t2uRKnRc/N/ FdLWhXdxcmdg17wtlxNz3f3YzzyVqoS3wfe8kLwzx4S1tDS3J6kSzcBbkZG4pt1ZdnGkcmQIE8vSj q2D+vUhQ4bfs0h1QfHmW6TgYeGDec8TSBY9bBJ8tgpBxij88aWc3E2s0upq8s0XgCHrc5u58UQ4AF J1bJv9FrvfpGwdQGtx9d9q8C5H+KWfvl5C1gfqxnmm+IZnGhuD9fN1yBZKt84gKHyjar/fmltIrYj 5cKFnLBl7u04/QDqBAJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyCZ-00FgXt-Hf; Tue, 01 Mar 2022 08:49:47 +0000 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyCT-00FgV0-EF for linux-arm-kernel@lists.infradead.org; Tue, 01 Mar 2022 08:49:43 +0000 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id ECCD33FCAC for ; Tue, 1 Mar 2022 08:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646124577; bh=i5oNvJtWT2nQMVMnHuzSOVOeJhkbSN882hqbqowwmW8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c88GyFPPo6sEwnpjjs3fjMh3NHJh3kPCBNjrInIgh23e3G6SGRqawoNFlPTEhiSNv kMwZtbcAsIMxQnsmp/VwSYAhTq/d2UdLvP2SilIXIGcne16HbqKsqrWWJqsLxzyokQ jkVQWxuqQS0w+but44E/uhUYGq3cQsbVg6tz8cPD/WNQVl5JOHDpCG0YPkSogwoY77 9iuOk7l3lLbvUxgY2Cu/vroMtp3i3nFNSWZREgrt7JsXjM3BTXUvxwQJx787KoL1/T VUR8tdZg2d+SWk/O4NWqHXPvozKPf0FOICkJ6N4R28PJ/4K9+UH1/l5S7KBIEW/zPi LxXxlJZgCkoTA== Received: by mail-ed1-f70.google.com with SMTP id z24-20020a50cd18000000b00414d5314c35so709889edi.21 for ; Tue, 01 Mar 2022 00:49:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=i5oNvJtWT2nQMVMnHuzSOVOeJhkbSN882hqbqowwmW8=; b=7NpEtebml4NCQbQcLKc5fKZm5a9MpUAbIVKn2PSQWZJ0YJ0w93avFs2r651hSqzs5a x6/EM375KNT9loJMoP3WtFWdBIRIHQsgfhAuzvXBPzt1cwDUPM3gOMeuKsZ7aNSKMbLp GLroU9qpJh/emYFqqlOnZS/+f7m7bMcOrbi3Cn8sZNgfcsgJ4ZRpufOeB+X+C1npnBPk DgTLP2dsWE1BoAPXrO+x3zFSIF/cJKAL6uVYlIVa2gPOPvGd0kdMttNdTUXWPQjc2Sqj VawWA6iL1DmU5fp+8b0s92kUuTWvlvh3hTYhzSPBldGZNGIUrxynUWpN8hWudGy/b0uv V5Hw== X-Gm-Message-State: AOAM531fPmrcMCFjnlkfJDBK4iRPh+9cq8/6AtlekFWuUkrlFkxBw98W /gf3ih2Cie2ndN/uIeQTct/GjWjHDRthjLnybJ2IkMWK2b6HSBAi/Xe9h99OM+Ax27KXvJQ6ank Ih6hyBlG4oEAG1b9lF+hlHRWtv+tOEyZBba2wPEsnYFJfM6Lz8SKE X-Received: by 2002:aa7:db47:0:b0:413:7649:c2bb with SMTP id n7-20020aa7db47000000b004137649c2bbmr18696627edt.123.1646124577530; Tue, 01 Mar 2022 00:49:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0Ji57X8BPtLBdo02/7Aw5hrJyfazNqZcwT3ns08IlVBGD/uW7vhmHoqEKLaS5kqGFV7Hlhw== X-Received: by 2002:aa7:db47:0:b0:413:7649:c2bb with SMTP id n7-20020aa7db47000000b004137649c2bbmr18696608edt.123.1646124577357; Tue, 01 Mar 2022 00:49:37 -0800 (PST) Received: from [192.168.0.136] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id y14-20020a50eb8e000000b00410a2e7798dsm6893213edr.38.2022.03.01.00.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Mar 2022 00:49:36 -0800 (PST) Message-ID: <40d9b2ad-2f8a-42c8-54cf-b22e24d78538@canonical.com> Date: Tue, 1 Mar 2022 09:49:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 01/11] driver: platform: Add helper for safer setting of driver_override Content-Language: en-US To: Bjorn Helgaas Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes References: <20220228200326.GA516164@bhelgaas> From: Krzysztof Kozlowski In-Reply-To: <20220228200326.GA516164@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_004941_724608_50FEAF05 X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/02/2022 21:03, Bjorn Helgaas wrote: > On Sun, Feb 27, 2022 at 02:52:04PM +0100, Krzysztof Kozlowski wrote: >> Several core drivers and buses expect that driver_override is a >> dynamically allocated memory thus later they can kfree() it. > >> +int driver_set_override(struct device *dev, const char **override, >> + const char *s, size_t len) >> +{ >> + const char *new, *old; >> + char *cp; >> + >> + if (!dev || !override || !s) >> + return -EINVAL; >> + >> + /* We need to keep extra room for a newline */ > > It would help a lot to extend this comment with a hint about where the > room for a newline is needed. It was confusing even before, but it's > much more so now that the check is in a completely different file than > the "show" functions that need the space. > Indeed, this needs explanation. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel