From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A57BFD68BF2 for ; Sun, 17 Nov 2024 10:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PYcx8Jr5yUiktUasgz5b5XQtP7bTYoN5a4bcgqpVpuE=; b=STED1BMx7I131Ht0Tob/qhBpMD 4B8noZa7j3ZWgp6J3lAXJUJUsDvts2393ZtKiqo6AagzWGwnfFgpGMUANxYoR4hN3br/2KMggHwKP J1tKR/ckl58PjFMF711SnmC+yfTkrjDwdMfIR4g2TJ005RH/MU8NAGk43qy/amsUk3BTcM72+ZtaU 8KOtUrZ9zp8fsA+wubYzGZNU2mv2mHxAbU11WftkprwSbeIz+OXI5d3QUnI34sHhIAviSEZ9NhpqH ys7cnV3eMX7FwY1ZvoI+XDsFRHYImqpPdNtRv/HMFy2PHNj88nh/xVGdoBfnziwclikngj+bRz8V7 Ocg8xhBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tCcM9-000000078td-2wHy; Sun, 17 Nov 2024 10:18:13 +0000 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tCcLE-000000078nD-0q1k for linux-arm-kernel@lists.infradead.org; Sun, 17 Nov 2024 10:17:18 +0000 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.stl.internal (Postfix) with ESMTP id 64E9A2540088; Sun, 17 Nov 2024 05:17:12 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Sun, 17 Nov 2024 05:17:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731838632; x=1731925032; bh=PYcx8Jr5yUiktUasgz5b5XQtP7bTYoN5a4bcgqpVpuE=; b= YCe1xk09UAc666jKEwasOftYhYuiHV2LzAWg7lnaBuGYe7FhJ5hqDdqz0A0UaatY 7peGQCQdzrKwO0vzq2i1w1YB2CHzl2wuVPRC9j4/aA+OpZbnkfFxdFYDywbIBND0 dzKEttcDhkHq4+KnnYFKHS/72ztZzYt3Y/O9uGJ/8oVNu+6ClqZ0UJR5jnabxySu /pWqEPnf10XvABlLR61hNKwczvAph7hi4aMZBeoVi8LLps1CXxs5cwhbFXgzx324 83REJNe0fYPX6TgEYqPtuFjA25fRzzxJvxV0aooFwSBDP36g5EQrUpmOG1lSbG2p i9NhVEVwRahSNGEDbylMww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731838632; x= 1731925032; bh=PYcx8Jr5yUiktUasgz5b5XQtP7bTYoN5a4bcgqpVpuE=; b=c SJCmSdBVsElQFPWJRzH4fOyiT/kF29Qo2/BCQsYRosU/bWNQOb+boZnrV3JYvPBO yUPAX8alYPYpUhKXLSPYj705onP6ekrX+5tAeTkh2051IufGkHKucZOvCrvsSK6J KvtmIW2xTzfbJU94zYi7t6dDBew2swTF9kZkiYS713YWeBb3iMw67YIyjiTABMSD b42XOgkDTslJ/+8TFTu5A8Kn3H2JkEiikSakhg45f5lMuT34x5H9ySGVLfo3uSkz EK0nydhF+y+p8MOSx2VbArOYY9xzChZsPRjoEkBbuLeaB2/AwKltY26sTHOrWxvN EDVlP3C/L+gkVSBcl6xyg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdekgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredttden ucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdrug gvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteefgffg vedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedujedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheptghrihhsthhirghnrdhmrghruhhssh hisegrrhhmrdgtohhmpdhrtghpthhtohepshhuuggvvghprdhhohhllhgrsegrrhhmrdgt ohhmpdhrtghpthhtohepfhgvshhtvghvrghmsehgmhgrihhlrdgtohhmpdhrtghpthhtoh eplhhgihhrugifohhougesghhmrghilhdrtghomhdprhgtphhtthhopegrrhhnugeskhgv rhhnvghlrdhorhhgpdhrtghpthhtohepsghrohhonhhivgeskhgvrhhnvghlrdhorhhgpd hrtghpthhtohepshhhrgifnhhguhhosehkvghrnhgvlhdrohhrghdprhgtphhtthhopehl ihhnuhigqdgrrhhmqdhkvghrnhgvlheslhhishhtshdrihhnfhhrrgguvggrugdrohhrgh dprhgtphhtthhopehimhigsehlihhsthhsrdhlihhnuhigrdguvghv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id D13482220071; Sun, 17 Nov 2024 05:17:10 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Sun, 17 Nov 2024 11:16:49 +0100 From: "Arnd Bergmann" To: "Cristian Marussi" , "Arnd Bergmann" Cc: "Sudeep Holla" , "Shawn Guo" , "Sascha Hauer" , "Mark Brown" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Liam Girdwood" , "Jaroslav Kysela" , "Takashi Iwai" , "Peng Fan" , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org Message-Id: <40fd6f5c-e3d8-4e75-b479-00d3f81423a8@app.fastmail.com> In-Reply-To: References: <20241115230555.2435004-1-arnd@kernel.org> Subject: Re: [PATCH] firmware: arm_scmi: fix i.MX build dependency Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241117_021717_012489_1C7F1E3D X-CRM114-Status: GOOD ( 32.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 17, 2024, at 11:03, Cristian Marussi wrote: > On Sat, Nov 16, 2024 at 12:05:18AM +0100, Arnd Bergmann wrote: >> >> arm-linux-gnueabi-ld: sound/soc/fsl/fsl_mqs.o: in function `fsl_mqs_sm_write': >> fsl_mqs.c:(.text+0x1aa): undefined reference to `scmi_imx_misc_ctrl_set' >> arm-linux-gnueabi-ld: sound/soc/fsl/fsl_mqs.o: in function `fsl_mqs_sm_read': >> fsl_mqs.c:(.text+0x1ee): undefined reference to `scmi_imx_misc_ctrl_get' >> > > The SCMI drivers, like the newly added IMX_SCMI_MISC_DRV, generally make > ue of the related vendor protocol like IMX_SCMI_MISC_EXT, BUT the SCMI > stack is designed in a way that NO symbols are needed to be exported by > the protocol layer (to avoid a huge and growing number of symbols > exports)...so usually the current DRV-->PROTO dependency is fine. > > In this case, AFAIU, it is the SCMI driver that in turn exports a few > helpers that are used by another driver fsl_mqs, which in turn could be > compiled and work with or without the SCMI stack, so with this patch we > are artificially reversing the DRV<--PROTO dependency to solve this > scenario in all the compillation scenarios... > > ....BUT given that the IMX_SCMI_MISC_DRV is the one that should export > the missing symbols could NOT this solved in a cleaner way, without > adding the fake reverse dependency, by instead modifying the header of > the driver with something like the classic: > --->8----- > diff --git a/include/linux/firmware/imx/sm.h b/include/linux/firmware/imx/sm.h > index 9b85a3f028d1..3a7a3ec367c5 100644 > --- a/include/linux/firmware/imx/sm.h > +++ b/include/linux/firmware/imx/sm.h > @@ -17,7 +17,19 @@ > #define SCMI_IMX_CTRL_SAI4_MCLK 4 /* WAKE SAI4 MCLK */ > #define SCMI_IMX_CTRL_SAI5_MCLK 5 /* WAKE SAI5 MCLK */ > > +#ifdef IMX_SCMI_MISC_DRV > int scmi_imx_misc_ctrl_get(u32 id, u32 *num, u32 *val); > int scmi_imx_misc_ctrl_set(u32 id, u32 val); > +#else > +static inline int scmi_imx_misc_ctrl_get(u32 id, u32 *num, u32 *val) > +{ > + return 0; > +} > + > +static inline int scmi_imx_misc_ctrl_set(u32 id, u32 val) > +{ > + return 0; > +} > +#endif This usually doesn't work if the provider of these interfaces can be in a loadable module. The #ifdef above means this won't be usable when CONFIG_IMX_SCMI_MISC_DRV=m, while changing it to IS_ENABLED(CONFIG_IMX_SCMI_MISC_DRV) still produces a link error when the consumer is built-in. Changing it to IS_REACHABLE() in turn is even worse because it avoids the link failure but makes it silently do the wrong thing in some configurations. > #endif > ----->8----------- > > ....to just support compilation in all the scenarios. > >> This however only works after changing the dependency in the SND_SOC_FSL_MQS >> driver as well, which uses 'select IMX_SCMI_MISC_DRV' to turn on a >> driver it depends on. This is generally a bad idea, so the best solution >> is to change that into a dependency. >> >> To allow the ASoC driver to keep building with the SCMI support, this >> needs to be an optional dependency that enforces the link-time >> dependency if IMX_SCMI_MISC_DRV is a loadable module but not >> depend on it if that is disabled. >> > > ...and maybe with the above additions you could avoid also these other > dep changes... > > ...not sure if I am missing something and I have definitely not tested > any of my babbling above... In my experience, there is no way to avoid reflecting the dependencies correctly in Kconfig: if one driver has an EXPORT_SYMBOL that gets picked up by another driver, you need a matching 'depends on'. Arnd