From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B11D5C6FD1D for ; Wed, 15 Mar 2023 16:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GwVPCG5q9nGnnSXIjVH/Dk28eSPTIsI02bpwl+2UFEU=; b=ikDoCS5xSvNgzS ZyTT8vMqJjx7gDaI/KWT3Obbcj6P6Y478+PaMtaVw/j2A1cTrzseq4KqgCp8X+krmsobYs4QFY1pC 5/FTTR+d1376IvDqSwHd0gzNbiFgyqtD4+qjjDoAjCj+8cSr7p0HskEVxjEp46lK+Rl1fivERTb4E RsUO/Nk31srg3ASQ9vJy/FtSqpvf3LVJuDNGTV+6YSKgRnJ1ACvRKkJBS4k6JkxfzysVdZrrsjryq CGdqh+ERwNDNxRMwfTEsX92GamKbRoFXmUy7ngSacAyeALPMV6IwrCVI/3eVsLLom0CepXJNAkI4F jo8bZZG+tlDdo46jhY/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcTd6-00E0MQ-0I; Wed, 15 Mar 2023 16:05:32 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcTd2-00E0K4-0Q for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 16:05:30 +0000 Received: by mail-ed1-x52f.google.com with SMTP id r11so25863518edd.5 for ; Wed, 15 Mar 2023 09:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678896326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YYGX99pO1QhMCjaMfA2tt6x0aDGPLDNKPraVBhA8mfY=; b=OLQvLwhqfZHoCdUd/CB/heb6Rkub5zLWqQ38FphV9KG8d+V2dnKGE7Bxfw22JsCW/E gVMJose6qpqyl3T3eZb0IpEVaKi2c+Ci3EM560ZAyfil/YUE41QJBT8+m96IUCfripPt Ofctldl7TlC9G6UqCH8PolRbTmhmYStv5U+j5fCHM2uBzS4Q04ACs/vyGP7hnezZiSJv TL72vXaeZXEDWMdcaLJW+t/4PTcQ0NQsDVtvemmGH0GQ9JKMoGq65FNZ/T92/ibbBCI7 hRRHXCEBFirLBfq8zxBlCannFFvVZVbqO89r0rfcixvjNo++uaHeFcaFz4osjuwZRhgw Wbgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678896326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YYGX99pO1QhMCjaMfA2tt6x0aDGPLDNKPraVBhA8mfY=; b=XcSEqbYSbl2msE3/91dZRhJWH5Tj9DTrb1Ep8xZEKfBxXD6u5OsDp6vG/tmMgew4np XQ82exuIWc9s5Fo8GsLr8WHOKWlz5+yKpKCDytBmLpR8Hzd2/us7hiVCxvcNz06i0vdv GgFHr0BG1O2IAPAO2lhu7mjCYGJl09Hl+qTMEIPKGYCgCDG266aQB9mwFg5WbRGuORwG +gbzLaba0OT+uYaZgzRmFmF0eg0KhuB3bS9kVy5TqpIChGavhqzzSgj2diTbaUGwJ6nM ovebDiWxhDy5M4D567wQCqF6smnpD40ABNE0iZ4xHl+xjTFwBIJ43MOVIA0154tUB7TI ZPFg== X-Gm-Message-State: AO0yUKU6RCt7QuOUmYwypjrqT4CtSW443TsPqk5th793WpwB0tboASn2 Y8kBJXOwkATPr4e5ICXW1Ak= X-Google-Smtp-Source: AK7set/5iYiiCkiPNXJhp+k6XG0KokT/w7XIYCxSgGW7s6z/i1G3KHv3tbWMDV5m8dnbU+bgoCcLsw== X-Received: by 2002:a17:906:4c4d:b0:888:db6b:5fa9 with SMTP id d13-20020a1709064c4d00b00888db6b5fa9mr8133172ejw.67.1678896325683; Wed, 15 Mar 2023 09:05:25 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-233.dynamic.telemach.net. [82.149.1.233]) by smtp.gmail.com with ESMTPSA id dt5-20020a170906b78500b008e82cb55195sm2704185ejb.203.2023.03.15.09.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 09:05:25 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Ban Tao , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de Subject: Re: [PATCH 143/173] ASoC: sunxi: sun50i-dmic: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 17:05:23 +0100 Message-ID: <4127320.1IzOArtZ34@jernej-laptop> In-Reply-To: <20230315150745.67084-144-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> <20230315150745.67084-144-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_090528_184849_A21B6ECD X-CRM114-Status: GOOD ( 21.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne sreda, 15. marec 2023 ob 16:07:15 CET je Uwe Kleine-K=F6nig napisal(a): > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Acked-by: Jernej Skrabec Best regards, Jernej > --- > sound/soc/sunxi/sun50i-dmic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > = > diff --git a/sound/soc/sunxi/sun50i-dmic.c b/sound/soc/sunxi/sun50i-dmic.c > index 069c993acb31..c10439b9e0a2 100644 > --- a/sound/soc/sunxi/sun50i-dmic.c > +++ b/sound/soc/sunxi/sun50i-dmic.c > @@ -373,13 +373,11 @@ static int sun50i_dmic_probe(struct platform_device > *pdev) return ret; > } > = > -static int sun50i_dmic_remove(struct platform_device *pdev) > +static void sun50i_dmic_remove(struct platform_device *pdev) > { > pm_runtime_disable(&pdev->dev); > if (!pm_runtime_status_suspended(&pdev->dev)) > sun50i_dmic_runtime_suspend(&pdev->dev); > - > - return 0; > } > = > static const struct dev_pm_ops sun50i_dmic_pm =3D { > @@ -394,7 +392,7 @@ static struct platform_driver sun50i_dmic_driver =3D { > .pm =3D &sun50i_dmic_pm, > }, > .probe =3D sun50i_dmic_probe, > - .remove =3D sun50i_dmic_remove, > + .remove_new =3D sun50i_dmic_remove, > }; > = > module_platform_driver(sun50i_dmic_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel