From: <Codrin.Ciubotariu@microchip.com>
To: <cgel.zte@gmail.com>
Cc: alexandre.belloni@bootlin.com, arnd@arndb.de, lv.ruyi@zte.com.cn,
zealci@zte.com.cn, linux-kernel@vger.kernel.org,
Claudiu.Beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] misc: atmel-ssc: fix error check return value of platform_get_irq()
Date: Fri, 15 Apr 2022 06:47:26 +0000 [thread overview]
Message-ID: <413afa94-5b9c-02e5-a735-db1b26f06722@microchip.com> (raw)
In-Reply-To: <20220413093222.2538066-1-lv.ruyi@zte.com.cn>
On 13.04.2022 12:32, cgel.zte@gmail.com wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> platform_get_irq() return negative value on failure, so null check of
> ssc->irq is incorrect. Fix it by comparing whether it is less than zero.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-04-15 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 9:32 [PATCH] misc: atmel-ssc: fix error check return value of platform_get_irq() cgel.zte
2022-04-15 6:47 ` Codrin.Ciubotariu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413afa94-5b9c-02e5-a735-db1b26f06722@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=cgel.zte@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).