From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes
Date: Fri, 26 Aug 2016 11:56:16 +0200 [thread overview]
Message-ID: <4142998.LszVVqOYjE@wuerfel> (raw)
In-Reply-To: <1899384.M1jdqOztqi@wuerfel>
On Friday, August 26, 2016 11:41:21 AM CEST Arnd Bergmann wrote:
>
> I think this breaks machines that declare a device that just lists
> SMC91X_USE_32BIT but not SMC91X_USE_16BIT. Right now, the way this
> is interpreted is to use 32-bit accessors for most things, but
> not avoiding 16-bit reads.
I guess my patch has the same problem here, with the
if (SMC_CAN_USE_8BIT && !SMC_16BIT(lp))
check that is true when a platform device is declared with 32-bit
I/O only but all three are enabled at compile-time. The best check
I can think of here (aside from redefining how the flags work)
would be
#define SMC_8BIT_ONLY(p) \
(((p)->cfg.flags & (SMC91X_USE_8BIT |SMC91X_USE_16BIT | SMC91X_USE_32BIT)) == \
SMC91X_USE_8BIT)
Arnd
next prev parent reply other threads:[~2016-08-26 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 14:43 [PATCH] smc91x: remove ARM hack for unaligned 16-bit writes Arnd Bergmann
2016-08-25 14:45 ` Arnd Bergmann
2016-08-25 18:02 ` Robert Jarzmik
2016-08-25 22:37 ` Russell King - ARM Linux
2016-08-26 9:41 ` Arnd Bergmann
2016-08-26 9:56 ` Arnd Bergmann [this message]
2016-08-26 11:38 ` Russell King - ARM Linux
2016-08-26 12:29 ` Russell King - ARM Linux
2016-08-27 15:30 ` Robert Jarzmik
2016-08-27 15:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4142998.LszVVqOYjE@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox