Re: [PATCH v2 04/12] arm64: dts: fsd: Add CSI nodes

[Krzysztof Kozlowski <krzk@kernel.org>]

On 22/08/2025 15:57, Inbaraj E wrote:
> 
> Hi Krzysztof,
> 
> Thanks for the review.
> 
>>
>> On 14/08/2025 16:09, Inbaraj E wrote:
>>> There is a csi dma and csis interface that bundles together to allow
>>
>> CSI DMA?
>> What is CSIS?
>>
>>> csi2 capture.
>>
>> CSI2?
> 
> CSIS stands for Camera Serial Interface Slave.

Googling for "MIPI CSIS" gives me 0 results, so I still claim this is
not a generic name.

> 
> Samsung v4.3 CSIS IP bundles both the CSIS link operation and the CSIS
> DMA operation. The DMA-related operation are referred to as CSIS DMA and
> are handled by the fsd-csis driver. The link related operations are
> referred to simply as CSIS and are integrated into imx-mipi-csis driver.
> 
> I'll update the commit message and commit description accordingly,
> and maintain consistency across the patches.
> 
>>
>>>
>>> Signed-off-by: Inbaraj E <inbaraj.e@samsung.com>
>>> ---
>>>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  96 +++++
>>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> @@ -493,6 +493,558 @@ clock_mfc: clock-controller@12810000 {
>>>  			clock-names = "fin_pll";
>>>  		};
>>>
>>> +		mipicsis0: mipi-csis@12640000 {
>>
>> Messed ordering. See DTS coding style.
> 
> I'll fix the ordering in next patchset.
> 
>>
>> Node names should be generic. See also an explanation and list of examples
>> (not exhaustive) in DT specification:
>> https://protect2.fireeye.com/v1/url?k=a30d23f8-c28636dd-a30ca8b7-
>> 74fe485cbff6-ee12f8a711c584c8&q=1&e=b96506d8-2d5d-4303-b9e8-
>> 0e1189db1585&u=https%3A%2F%2Fdevicetree-
>> specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-
>> basics.html%23generic-names-recommendation
>>
> 
> There is no generic name directly related to CSI apart from camera. That's
> why I used mipi-csis. If preferred, I can move the name to csis or simply csi.
> Please let me know which one is more appropriate.

I don't think you really tried to solve this. How this device is called
in all other vendors?

Best regards,
Krzysztof